diff --git a/.gitignore b/.gitignore
index 482f2643b5..282fa5fb48 100644
--- a/.gitignore
+++ b/.gitignore
@@ -5,3 +5,4 @@ local/
frontend/src/routes/test.svelte
CaddyfileRemoteMalo
*.swp
+**/.idea/
diff --git a/frontend/src/lib/components/S3FilePicker.svelte b/frontend/src/lib/components/S3FilePicker.svelte
index be5b2c6c9d..d0300aec9d 100644
--- a/frontend/src/lib/components/S3FilePicker.svelte
+++ b/frontend/src/lib/components/S3FilePicker.svelte
@@ -38,6 +38,7 @@
let workspaceSettingsInitialized = true
+ export let fromWorkspaceSettings: boolean = false
export let readOnlyMode: boolean
export let initialFileKey: { s3: string } | undefined = undefined
@@ -431,22 +432,32 @@
documentationLink="https://www.windmill.dev/docs/integrations/s3"
>
{#if workspaceSettingsInitialized === false}
-
-
-
- The workspace needs to be connected to an S3 storage to use this feature. You can configure it here.
-
-
-
-
+ {#if fromWorkspaceSettings}
+
+
+
+ Double check the S3 resource fields and try again.
+
+
+
+ {:else}
+
+
+
+ The workspace needs to be connected to an S3 storage to use this feature. You can configure it here.
+
+
+
+
+ {/if}
{:else}
@@ -629,10 +640,12 @@
uploadModalOpen = true
}}>Upload File
-
+ {#if !fromWorkspaceSettings}
+
+ {/if}
{/if}
@@ -702,6 +715,10 @@
on:confirmed={() => {
uploadFileToS3()
}}
+ on:close={() => {
+ fileUploadCancelled = true
+ uploadModalOpen = false
+ }}
bind:progressPct={fileUploadProgress}
bind:errorMsg={fileUploadErrorMsg}
/>
diff --git a/frontend/src/lib/components/common/fileUpload/FileUploadModal.svelte b/frontend/src/lib/components/common/fileUpload/FileUploadModal.svelte
index 0669986898..b604817ac9 100644
--- a/frontend/src/lib/components/common/fileUpload/FileUploadModal.svelte
+++ b/frontend/src/lib/components/common/fileUpload/FileUploadModal.svelte
@@ -3,7 +3,7 @@
import { createEventDispatcher } from 'svelte'
import { fade } from 'svelte/transition'
import Button from '../button/Button.svelte'
- import { FileUp, Loader2 } from 'lucide-svelte'
+ import { FileUp, Loader2, X } from 'lucide-svelte'
export let title: string
export let open: boolean = false
@@ -44,9 +44,19 @@
)}
>
-
- {title}
-
+
+
+ {title}
+
+
{:else if tab == 'git_sync'}