From db873be43ba7f93f3929a2e089ca11fb2fc8ced0 Mon Sep 17 00:00:00 2001
From: Ruben Fiszel <ruben@rubenfiszel.com>
Date: Sat, 31 May 2025 05:15:24 +0200
Subject: [PATCH] nit editors reactivity on change

---
 frontend/src/lib/components/Editor.svelte         | 10 ++++------
 frontend/src/lib/components/SimpleEditor.svelte   | 10 ++++------
 frontend/src/lib/components/TemplateEditor.svelte | 10 ++++------
 3 files changed, 12 insertions(+), 18 deletions(-)

diff --git a/frontend/src/lib/components/Editor.svelte b/frontend/src/lib/components/Editor.svelte
index 13aafe1491..82db22bf99 100644
--- a/frontend/src/lib/components/Editor.svelte
+++ b/frontend/src/lib/components/Editor.svelte
@@ -367,13 +367,13 @@
 		}
 	}
 
-	function updateCode(): boolean {
+	function updateCode() {
 		const ncode = getCode()
 		if (code == ncode) {
-			return false
+			return
 		}
 		code = ncode
-		return true
+		dispatch('change', ncode)
 	}
 
 	export function append(code: string): void {
@@ -1287,9 +1287,7 @@
 		editor?.onDidChangeModelContent((event) => {
 			timeoutModel && clearTimeout(timeoutModel)
 			timeoutModel = setTimeout(() => {
-				if (updateCode()) {
-					dispatch('change', code)
-				}
+				updateCode()
 			}, changeTimeout)
 
 			ataModel && clearTimeout(ataModel)
diff --git a/frontend/src/lib/components/SimpleEditor.svelte b/frontend/src/lib/components/SimpleEditor.svelte
index 72d9048c14..ac69ded87f 100644
--- a/frontend/src/lib/components/SimpleEditor.svelte
+++ b/frontend/src/lib/components/SimpleEditor.svelte
@@ -163,13 +163,13 @@
 		editor?.setValue(ncode)
 	}
 
-	function updateCode(): boolean {
+	function updateCode() {
 		const ncode = getCode()
 		if (code == ncode) {
-			return false
+			return
 		}
 		code = ncode
-		return true
+		dispatch('change', ncode)
 	}
 
 	function updatePlaceholderVisibility(value: string) {
@@ -379,9 +379,7 @@
 			suggestion = ''
 			timeoutModel && clearTimeout(timeoutModel)
 			timeoutModel = setTimeout(() => {
-				if (updateCode()) {
-					dispatch('change', { code })
-				}
+				updateCode()
 			}, 200)
 		})
 
diff --git a/frontend/src/lib/components/TemplateEditor.svelte b/frontend/src/lib/components/TemplateEditor.svelte
index 4bd4e46577..b7027633ca 100644
--- a/frontend/src/lib/components/TemplateEditor.svelte
+++ b/frontend/src/lib/components/TemplateEditor.svelte
@@ -472,22 +472,20 @@
 			editor.addCommand(KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.Digit7, function () {})
 		})
 
-		function updateCode(): boolean {
+		function updateCode() {
 			const ncode = getCode()
 			if (code == ncode) {
-				return false
+				return
 			}
 			code = ncode
-			return true
+			dispatch('change', code)
 		}
 
 		let timeoutModel: NodeJS.Timeout | undefined = undefined
 		editor.onDidChangeModelContent((event) => {
 			timeoutModel && clearTimeout(timeoutModel)
 			timeoutModel = setTimeout(() => {
-				if (updateCode()) {
-					dispatch('change', { code })
-				}
+				updateCode()
 			}, 200)
 		})