From dc8f76080526789536fa240fcae1e266881d2c5d Mon Sep 17 00:00:00 2001
From: AlexRV12 <71396855+AlexRV12@users.noreply.github.com>
Date: Thu, 3 Sep 2026 10:24:17 +0200
Subject: [PATCH] refactor: drop the job status icon props nothing passes

---
 .../lib/components/runs/JobStatusIcon.svelte  | 60 +++++++------------
 1 file changed, 20 insertions(+), 40 deletions(-)

diff --git a/frontend/src/lib/components/runs/JobStatusIcon.svelte b/frontend/src/lib/components/runs/JobStatusIcon.svelte
index 0a99530609..5f93f8b6dd 100644
--- a/frontend/src/lib/components/runs/JobStatusIcon.svelte
+++ b/frontend/src/lib/components/runs/JobStatusIcon.svelte
@@ -18,43 +18,28 @@
 		job: Job
 		isExternal?: boolean
 		roundedFull?: boolean
-		/** Icon size in px, and the padding around it. Defaults are the runs page's; the chat's
-		 * tool rows ask for a smaller one, since a 30px badge would set the height of a row of
-		 * 11px text. */
-		size?: number
-		badgeClass?: string
 	}
 
-	let {
-		job,
-		isExternal = false,
-		roundedFull = false,
-		size = 14,
-		badgeClass = undefined
-	}: Props = $props()
+	let { job, isExternal = false, roundedFull = false }: Props = $props()
 </script>
 
 <div class="flex items-center justify-start">
 	{#if isExternal}
-		<Badge color="gray" {roundedFull} baseClass={roundedFull ? '' : '!px-1.5'}
-			class={badgeClass}>
-			<ShieldQuestion size={size} />
+		<Badge color="gray" {roundedFull} baseClass={roundedFull ? '' : '!px-1.5'}>
+			<ShieldQuestion size={14} />
 		</Badge>
 	{:else if job.canceled && 'success' in job}
-		<Badge color="gray" {roundedFull} baseClass={roundedFull ? '' : '!px-1.5'}
-			class={badgeClass} title="Canceled">
-			<Ban size={size} />
+		<Badge color="gray" {roundedFull} baseClass={roundedFull ? '' : '!px-1.5'} title="Canceled">
+			<Ban size={14} />
 		</Badge>
 	{:else if 'success' in job && job.success}
 		{#if job.is_skipped}
-			<Badge color="green" {roundedFull} baseClass={roundedFull ? '' : ''}
-				class={badgeClass}>
-				<FastForward size={size} />
+			<Badge color="green" {roundedFull} baseClass={roundedFull ? '' : ''}>
+				<FastForward size={14} />
 			</Badge>
 		{:else}
-			<Badge color="green" {roundedFull} baseClass={roundedFull ? '' : '!px-1.5'}
-			class={badgeClass}>
-				<Check size={size} />
+			<Badge color="green" {roundedFull} baseClass={roundedFull ? '' : '!px-1.5'}>
+				<Check size={14} />
 			</Badge>
 		{/if}
 	{:else if 'success' in job && job.resolved}
@@ -62,34 +47,29 @@
 			color="orange"
 			{roundedFull}
 			baseClass={roundedFull ? '' : '!px-1.5'}
-			class={badgeClass}
 			title="Failed, marked as resolved"
 		>
-			<Wrench size={size} />
+			<Wrench size={14} />
 		</Badge>
 	{:else if 'success' in job}
-		<Badge color="red" {roundedFull} baseClass={roundedFull ? '' : '!px-1.5'}
-			class={badgeClass}>
-			<X size={size} />
+		<Badge color="red" {roundedFull} baseClass={roundedFull ? '' : '!px-1.5'}>
+			<X size={14} />
 		</Badge>
 	{:else if 'running' in job && job.running && job.suspend}
-		<Badge color="violet" {roundedFull} baseClass={roundedFull ? '' : '!px-1.5'}
-			class={badgeClass} title="Suspended">
-			<Hourglass size={size} />
+		<Badge color="violet" {roundedFull} baseClass={roundedFull ? '' : '!px-1.5'} title="Suspended">
+			<Hourglass size={14} />
 		</Badge>
 	{:else if 'running' in job && job.running}
-		<Badge color="yellow" {roundedFull} baseClass={roundedFull ? '' : '!px-1.5'}
-			class={badgeClass}>
-			<Play size={size} />
+		<Badge color="yellow" {roundedFull} baseClass={roundedFull ? '' : '!px-1.5'}>
+			<Play size={14} />
 		</Badge>
 	{:else if job && 'running' in job && job.scheduled_for && forLater(job.scheduled_for)}
-		<Badge color="blue" {roundedFull} baseClass={roundedFull ? '' : '!px-1.5'}
-			class={badgeClass}>
-			<Calendar size={size} />
+		<Badge color="blue" {roundedFull} baseClass={roundedFull ? '' : '!px-1.5'}>
+			<Calendar size={14} />
 		</Badge>
 	{:else}
-		<Badge {roundedFull} baseClass={roundedFull ? '' : '!px-1.5'} class={badgeClass}>
-			<Hourglass size={size} />
+		<Badge {roundedFull} baseClass={roundedFull ? '' : '!px-1.5'}>
+			<Hourglass size={14} />
 		</Badge>
 	{/if}
 </div>