mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-09-08 08:04:25 +00:00
feat: add codex PR review workflow
This commit is contained in:
centdix
@@ -0,0 +1,252 @@
|
||||
name: Codex Auto Review
|
||||
|
||||
on:
|
||||
pull_request:
|
||||
types: [ready_for_review, opened]
|
||||
|
||||
concurrency:
|
||||
group: codex-review-${{ github.event.pull_request.number }}
|
||||
cancel-in-progress: true
|
||||
|
||||
jobs:
|
||||
codex-review:
|
||||
runs-on: ubuntu-latest
|
||||
if: (github.event.pull_request.draft == false || github.event.pull_request.ready_for_review == true) && github.event.pull_request.head.repo.fork == false
|
||||
permissions:
|
||||
contents: read
|
||||
pull-requests: write
|
||||
outputs:
|
||||
review_json: ${{ steps.run_codex.outputs.final-message }}
|
||||
steps:
|
||||
- name: Check Codex configuration
|
||||
id: codex_config
|
||||
env:
|
||||
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
|
||||
run: |
|
||||
if [ -n "$OPENAI_API_KEY" ]; then
|
||||
echo "enabled=true" >> "$GITHUB_OUTPUT"
|
||||
else
|
||||
echo "enabled=false" >> "$GITHUB_OUTPUT"
|
||||
echo "OPENAI_API_KEY is not configured; skipping Codex review."
|
||||
fi
|
||||
|
||||
- name: Checkout repository
|
||||
if: steps.codex_config.outputs.enabled == 'true'
|
||||
uses: actions/checkout@v5
|
||||
with:
|
||||
ref: refs/pull/${{ github.event.pull_request.number }}/merge
|
||||
fetch-depth: 1
|
||||
|
||||
- name: Pre-fetch base and head refs for the PR
|
||||
if: steps.codex_config.outputs.enabled == 'true'
|
||||
env:
|
||||
PR_BASE_REF: ${{ github.event.pull_request.base.ref }}
|
||||
PR_NUMBER: ${{ github.event.pull_request.number }}
|
||||
run: |
|
||||
git fetch --no-tags origin \
|
||||
"$PR_BASE_REF" \
|
||||
"+refs/pull/$PR_NUMBER/head"
|
||||
|
||||
- name: Write Codex review context
|
||||
if: steps.codex_config.outputs.enabled == 'true'
|
||||
env:
|
||||
PR_REPOSITORY: ${{ github.repository }}
|
||||
PR_NUMBER: ${{ github.event.pull_request.number }}
|
||||
PR_BASE_SHA: ${{ github.event.pull_request.base.sha }}
|
||||
PR_HEAD_SHA: ${{ github.event.pull_request.head.sha }}
|
||||
PR_TITLE: ${{ github.event.pull_request.title }}
|
||||
PR_BODY: ${{ github.event.pull_request.body || '' }}
|
||||
run: |
|
||||
mkdir -p .github/codex
|
||||
node <<'NODE'
|
||||
const fs = require('fs');
|
||||
const lines = [
|
||||
`Repository: ${process.env.PR_REPOSITORY}`,
|
||||
`PR number: ${process.env.PR_NUMBER}`,
|
||||
`Base SHA: ${process.env.PR_BASE_SHA}`,
|
||||
`Head SHA: ${process.env.PR_HEAD_SHA}`,
|
||||
'',
|
||||
'PR title:',
|
||||
process.env.PR_TITLE || '(empty)',
|
||||
'',
|
||||
'PR body:',
|
||||
process.env.PR_BODY || '(empty)',
|
||||
'',
|
||||
'Changed commits command:',
|
||||
`git log --oneline ${process.env.PR_BASE_SHA}...${process.env.PR_HEAD_SHA}`,
|
||||
'',
|
||||
'Changed files command:',
|
||||
`git diff --stat ${process.env.PR_BASE_SHA}...${process.env.PR_HEAD_SHA}`,
|
||||
'',
|
||||
'Full review diff command:',
|
||||
`git diff --unified=0 ${process.env.PR_BASE_SHA}...${process.env.PR_HEAD_SHA}`
|
||||
];
|
||||
fs.writeFileSync('.github/codex/pr-review-context.md', `${lines.join('\n')}\n`);
|
||||
NODE
|
||||
|
||||
- name: Run Codex review
|
||||
if: steps.codex_config.outputs.enabled == 'true'
|
||||
id: run_codex
|
||||
uses: openai/codex-action@v1
|
||||
with:
|
||||
openai-api-key: ${{ secrets.OPENAI_API_KEY }}
|
||||
prompt-file: .github/codex/pr-review.prompt.md
|
||||
output-schema-file: .github/codex/review-output.schema.json
|
||||
model: gpt-5.4
|
||||
effort: xhigh
|
||||
sandbox: read-only
|
||||
safety-strategy: drop-sudo
|
||||
|
||||
post-review:
|
||||
runs-on: ubuntu-latest
|
||||
needs: codex-review
|
||||
if: needs.codex-review.outputs.review_json != ''
|
||||
permissions:
|
||||
pull-requests: write
|
||||
steps:
|
||||
- name: Post Codex review
|
||||
uses: actions/github-script@v7
|
||||
env:
|
||||
CODEX_REVIEW_JSON: ${{ needs.codex-review.outputs.review_json }}
|
||||
PR_HEAD_SHA: ${{ github.event.pull_request.head.sha }}
|
||||
with:
|
||||
github-token: ${{ github.token }}
|
||||
script: |
|
||||
const raw = process.env.CODEX_REVIEW_JSON?.trim();
|
||||
if (!raw) {
|
||||
core.info('No Codex review payload found.');
|
||||
return;
|
||||
}
|
||||
|
||||
let payload;
|
||||
try {
|
||||
payload = JSON.parse(raw);
|
||||
} catch (error) {
|
||||
core.setFailed(`Codex review payload was not valid JSON: ${error.message}`);
|
||||
return;
|
||||
}
|
||||
|
||||
const summary = typeof payload.summary === 'string' && payload.summary.trim()
|
||||
? payload.summary.trim()
|
||||
: 'No high-signal issues found.';
|
||||
const reproduction = typeof payload.reproduction_instructions === 'string' && payload.reproduction_instructions.trim()
|
||||
? payload.reproduction_instructions.trim()
|
||||
: 'Not enough UI context in the diff to provide reproduction instructions.';
|
||||
const findings = Array.isArray(payload.findings) ? payload.findings : [];
|
||||
|
||||
const parseChangedLines = (patch) => {
|
||||
const changedLines = new Set();
|
||||
if (!patch) {
|
||||
return changedLines;
|
||||
}
|
||||
|
||||
let nextNewLine = null;
|
||||
for (const line of patch.split('\n')) {
|
||||
const hunk = line.match(/^@@ -\d+(?:,\d+)? \+(\d+)(?:,(\d+))? @@/);
|
||||
if (hunk) {
|
||||
nextNewLine = Number.parseInt(hunk[1], 10);
|
||||
continue;
|
||||
}
|
||||
if (nextNewLine === null || !line) {
|
||||
continue;
|
||||
}
|
||||
if (line.startsWith('+') && !line.startsWith('+++')) {
|
||||
changedLines.add(nextNewLine);
|
||||
nextNewLine += 1;
|
||||
continue;
|
||||
}
|
||||
if (line.startsWith('-') && !line.startsWith('---')) {
|
||||
continue;
|
||||
}
|
||||
if (!line.startsWith('\\')) {
|
||||
nextNewLine += 1;
|
||||
}
|
||||
}
|
||||
|
||||
return changedLines;
|
||||
};
|
||||
|
||||
const files = await github.paginate(github.rest.pulls.listFiles, {
|
||||
owner: context.repo.owner,
|
||||
repo: context.repo.repo,
|
||||
pull_number: context.payload.pull_request.number,
|
||||
per_page: 100
|
||||
});
|
||||
|
||||
const changedLinesByPath = new Map(
|
||||
files.map((file) => [file.filename, parseChangedLines(file.patch)])
|
||||
);
|
||||
|
||||
const reviewComments = [];
|
||||
const summaryOnlyFindings = [];
|
||||
|
||||
for (const finding of findings) {
|
||||
const title = typeof finding.title === 'string' ? finding.title.trim() : '';
|
||||
const body = typeof finding.body === 'string' ? finding.body.trim() : '';
|
||||
const path = typeof finding.path === 'string' ? finding.path.trim() : '';
|
||||
const severity = typeof finding.severity === 'string' ? finding.severity.trim() : 'medium';
|
||||
const reason = typeof finding.reason === 'string' ? finding.reason.trim() : 'bug';
|
||||
const line = Number.isInteger(finding.line) ? finding.line : null;
|
||||
|
||||
if (!title || !body) {
|
||||
continue;
|
||||
}
|
||||
|
||||
const formattedBody = `[${severity}][${reason}] ${title}\n\n${body}`;
|
||||
const changedLines = changedLinesByPath.get(path);
|
||||
if (path && line !== null && changedLines?.has(line)) {
|
||||
reviewComments.push({
|
||||
path,
|
||||
line,
|
||||
side: 'RIGHT',
|
||||
body: formattedBody
|
||||
});
|
||||
} else {
|
||||
summaryOnlyFindings.push({
|
||||
path,
|
||||
line,
|
||||
severity,
|
||||
reason,
|
||||
title,
|
||||
body
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
const bodyLines = [
|
||||
'## Codex Review',
|
||||
'',
|
||||
summary
|
||||
];
|
||||
|
||||
if (summaryOnlyFindings.length > 0) {
|
||||
bodyLines.push('', '### Additional findings');
|
||||
summaryOnlyFindings.forEach((finding, index) => {
|
||||
const location = finding.path
|
||||
? `${finding.path}${finding.line ? `:${finding.line}` : ''}`
|
||||
: 'general';
|
||||
bodyLines.push(
|
||||
'',
|
||||
`${index + 1}. [${finding.severity}][${finding.reason}] ${location} - ${finding.title}`,
|
||||
'',
|
||||
finding.body
|
||||
);
|
||||
});
|
||||
}
|
||||
|
||||
bodyLines.push('', '### Reproduction instructions', '', reproduction);
|
||||
|
||||
const reviewPayload = {
|
||||
owner: context.repo.owner,
|
||||
repo: context.repo.repo,
|
||||
pull_number: context.payload.pull_request.number,
|
||||
commit_id: process.env.PR_HEAD_SHA,
|
||||
event: 'COMMENT',
|
||||
body: bodyLines.join('\n')
|
||||
};
|
||||
|
||||
if (reviewComments.length > 0) {
|
||||
reviewPayload.comments = reviewComments;
|
||||
}
|
||||
|
||||
await github.rest.pulls.createReview(reviewPayload);
|
||||
Reference in New Issue
Block a user