From e00cb430b0125bf80ca35cb6ff0478ec3080a0eb Mon Sep 17 00:00:00 2001
From: Ruben Fiszel <ruben@windmill.dev>
Date: Wed, 19 Mar 2025 17:02:32 +0100
Subject: [PATCH] feat: eager app mode

---
 .../components/inputs/AppDateTimeInput.svelte | 49 ++++++++++---
 .../apps/editor/RecomputeAllComponents.svelte |  2 +-
 .../apps/editor/SubGridEditor.svelte          |  2 +-
 .../editor/contextPanel/LazyModePanel.svelte  | 70 +++++++++++++------
 frontend/src/lib/components/apps/types.ts     |  1 +
 5 files changed, 89 insertions(+), 35 deletions(-)

diff --git a/frontend/src/lib/components/apps/components/inputs/AppDateTimeInput.svelte b/frontend/src/lib/components/apps/components/inputs/AppDateTimeInput.svelte
index 7dc67ad5a6..276d542b79 100644
--- a/frontend/src/lib/components/apps/components/inputs/AppDateTimeInput.svelte
+++ b/frontend/src/lib/components/apps/components/inputs/AppDateTimeInput.svelte
@@ -1,11 +1,13 @@
 <script lang="ts">
-	import { getContext } from 'svelte'
+	import { getContext, onDestroy } from 'svelte'
 	import { initConfig, initOutput } from '../../editor/appUtils'
 	import type {
 		AppViewerContext,
 		ComponentCustomCSS,
 		VerticalAlignment,
-		RichConfigurations
+		RichConfigurations,
+		ListContext,
+		ListInputs
 	} from '../../types'
 	import { initCss } from '../../utils'
 	import AlignWrapper from '../helpers/AlignWrapper.svelte'
@@ -27,24 +29,36 @@
 	const { app, worldStore, componentControl, selectedComponent } =
 		getContext<AppViewerContext>('AppViewerContext')
 
+	const iterContext = getContext<ListContext>('ListWrapperContext')
+	const listInputs: ListInputs | undefined = getContext<ListInputs>('ListInputs')
+
 	let resolvedConfig = initConfig(
 		components['datetimeinputcomponent'].initialData.configuration,
 		configuration
 	)
 
-	let value: string | undefined = undefined
-
-	$componentControl[id] = {
-		setValue(nvalue: string) {
-			value = nvalue
-		}
-	}
-
 	let outputs = initOutput($worldStore, id, {
 		result: undefined as string | undefined,
 		validity: true as boolean | undefined
 	})
 
+	let initValue = outputs?.result.peak()
+	let value: string | undefined =
+		!iterContext && initValue != undefined ? initValue : resolvedConfig.defaultValue
+
+	$componentControl[id] = {
+		setValue(nvalue: string) {
+			value = nvalue
+			outputs?.result.set(value)
+		}
+	}
+
+	onDestroy(() => {
+		listInputs?.remove(id)
+	})
+
+	let initialHandleDefault = true
+
 	$: handleDefault(resolvedConfig.defaultValue)
 
 	function formatDate(dateString: string, formatString: string = 'dd.MM.yyyy HH:mm') {
@@ -62,7 +76,8 @@
 
 	$: {
 		if (value) {
-			outputs?.result.set(formatDate(value, resolvedConfig.outputFormat))
+			const r = formatDate(value, resolvedConfig.outputFormat)
+			outputs?.result.set(r)
 			const valueDate = new Date(value)
 
 			if (resolvedConfig.minDateTime) {
@@ -95,12 +110,24 @@
 					outputs?.validity.set(false)
 				}
 			}
+			if (iterContext && listInputs) {
+				listInputs.set(id, value)
+			}
 		} else {
 			outputs?.result.set(undefined)
+			if (iterContext && listInputs) {
+				listInputs.set(id, undefined)
+			}
 		}
 	}
 
 	function handleDefault(defaultValue: string | undefined) {
+		if (initialHandleDefault) {
+			initialHandleDefault = false
+			if (value != undefined) {
+				return
+			}
+		}
 		value = defaultValue
 	}
 
diff --git a/frontend/src/lib/components/apps/editor/RecomputeAllComponents.svelte b/frontend/src/lib/components/apps/editor/RecomputeAllComponents.svelte
index 5ad24e52de..52c12b8e96 100644
--- a/frontend/src/lib/components/apps/editor/RecomputeAllComponents.svelte
+++ b/frontend/src/lib/components/apps/editor/RecomputeAllComponents.svelte
@@ -40,7 +40,7 @@
 		// 	initialized?.length ==
 		// 		allItems(app.grid, app.subgrids).length + (app.hiddenInlineScripts?.length ?? 0)
 		// )
-		if (app.lazyInitRequire == undefined) {
+		if (app.eagerRendering || app.lazyInitRequire == undefined) {
 			return (
 				initialized?.length ==
 				allItems(app.grid, app.subgrids).length + (app.hiddenInlineScripts?.length ?? 0)
diff --git a/frontend/src/lib/components/apps/editor/SubGridEditor.svelte b/frontend/src/lib/components/apps/editor/SubGridEditor.svelte
index 3fdb7728f1..a707900b6f 100644
--- a/frontend/src/lib/components/apps/editor/SubGridEditor.svelte
+++ b/frontend/src/lib/components/apps/editor/SubGridEditor.svelte
@@ -177,7 +177,7 @@
 	}
 </script>
 
-{#if everVisible}
+{#if everVisible || $app.eagerRendering}
 	<div
 		class="translate-x-0 translate-y-0 w-full subgrid {visible
 			? 'visible'
diff --git a/frontend/src/lib/components/apps/editor/contextPanel/LazyModePanel.svelte b/frontend/src/lib/components/apps/editor/contextPanel/LazyModePanel.svelte
index f60f053fe9..b78debafee 100644
--- a/frontend/src/lib/components/apps/editor/contextPanel/LazyModePanel.svelte
+++ b/frontend/src/lib/components/apps/editor/contextPanel/LazyModePanel.svelte
@@ -3,12 +3,19 @@
 	import type { AppViewerContext } from '../../types'
 
 	import Alert from '$lib/components/common/alert/Alert.svelte'
-	import Toggle from '$lib/components/Toggle.svelte'
 	import JsonEditor from '$lib/components/JsonEditor.svelte'
 	import Section from '$lib/components/Section.svelte'
+	import ToggleButtonGroup from '$lib/components/common/toggleButton-v2/ToggleButtonGroup.svelte'
+	import ToggleButton from '$lib/components/common/toggleButton-v2/ToggleButton.svelte'
 
 	const { app } = getContext<AppViewerContext>('AppViewerContext')
 	let code = JSON.stringify($app.lazyInitRequire)
+
+	let selectedRendering = $app.eagerRendering
+		? 'eager'
+		: $app.lazyInitRequire
+		? 'lazy'
+		: 'semi-lazy'
 </script>
 
 <div class="flex flex-col gap-8" style="all:none;">
@@ -19,32 +26,51 @@
 		When lazy mode is enabled, components are not rendered until they are needed. This can significantly
 		improve the performance of your app, especially on mobile devices.
 		<br />
-		You can enable lazy mode below, but you will need to declare the list of components whose initialization
-		is expected to see initialized before the initial refresh of the app happens.
+		Semi-Lazy mode is enabled by default, where components are initialized but are in a hidden state.
+		Lazy mode is when components are not initialized at all.
 	</Alert>
 
-	<Toggle
-		label="Lazy mode"
-		checked={Boolean($app.lazyInitRequire != undefined)}
-		on:change={(e) => {
-			$app.lazyInitRequire = e.detail ? [] : undefined
-			code = JSON.stringify($app.lazyInitRequire)
+	<ToggleButtonGroup
+		label="Rendering"
+		bind:selected={selectedRendering}
+		on:selected={(e) => {
+			if (e.detail == 'eager') {
+				$app.eagerRendering = true
+				$app.lazyInitRequire = undefined
+			} else if (e.detail == 'semi-lazy') {
+				$app.eagerRendering = undefined
+				$app.lazyInitRequire = undefined
+			} else {
+				$app.eagerRendering = undefined
+				$app.lazyInitRequire = []
+				code = JSON.stringify($app.lazyInitRequire)
+			}
 		}}
-		options={{
-			right: 'Lazy mode'
-		}}
-	/>
-
-	<Section label="Component ids to wait the initialization of before the initial refresh">
-		{#if $app.lazyInitRequire != undefined}
+		let:item
+	>
+		<ToggleButton value="eager" label="Eager" {item} />
+		<ToggleButton value="semi-lazy" label="Semi-Lazy" {item} />
+		<ToggleButton value="lazy" label="Lazy" {item} />
+	</ToggleButtonGroup>
+	{#if selectedRendering == 'eager'}
+		<Section label="Eager mode">
+			<span class="text-tertiary"
+				>In eager mode, all components will be fully initialized, even when they are not visible.</span
+			>
+		</Section>
+	{:else if selectedRendering == 'semi-lazy'}
+		<Section label="Semi-Lazy mode">
+			<span class="text-tertiary"
+				>In semi-lazy mode, components will be semi-initialized when hidden. That is the default
+				mode.</span
+			>
+		</Section>
+	{:else if selectedRendering == 'lazy'}
+		<Section label="Component ids to wait the initialization of before the initial refresh">
 			<JsonEditor bind:value={$app.lazyInitRequire} {code} />
 			<span class="text-tertiary text-xs">
 				{'e.g: ["a", "b"]'}, no need to put background runnables ids
 			</span>
-		{:else}
-			<span class="text-tertiary"
-				>Without lazy mode, all components' initialization will be waited on the initial refresh.</span
-			>
-		{/if}
-	</Section>
+		</Section>
+	{/if}
 </div>
diff --git a/frontend/src/lib/components/apps/types.ts b/frontend/src/lib/components/apps/types.ts
index 3317709ce0..e58618f99b 100644
--- a/frontend/src/lib/components/apps/types.ts
+++ b/frontend/src/lib/components/apps/types.ts
@@ -165,6 +165,7 @@ export type App = {
 	subgrids?: Record<string, GridItem[]>
 	theme: AppTheme | undefined
 	lazyInitRequire?: string[] | undefined
+	eagerRendering?: boolean | undefined
 	hideLegacyTopBar?: boolean | undefined
 	mobileViewOnSmallerScreens?: boolean | undefined
 	version?: number