diff --git a/.github/workflows/docker-image.yml b/.github/workflows/docker-image.yml index 0a4b6419c7..cd1bb62cf7 100644 --- a/.github/workflows/docker-image.yml +++ b/.github/workflows/docker-image.yml @@ -63,7 +63,6 @@ jobs: flavor: | latest=false tags: | - type=ref,event=pr type=semver,pattern={{version}} type=semver,pattern={{major}}.{{minor}} @@ -114,7 +113,6 @@ jobs: flavor: | latest=false tags: | - type=ref,event=pr type=semver,pattern={{version}} type=semver,pattern={{major}}.{{minor}} @@ -177,7 +175,6 @@ jobs: flavor: | latest=false tags: | - type=ref,event=pr type=semver,pattern={{version}} type=semver,pattern={{major}}.{{minor}} @@ -455,8 +452,6 @@ jobs: flavor: | latest=false tags: | - type=ref,event=branch - type=ref,event=pr type=semver,pattern={{version}} type=semver,pattern={{major}}.{{minor}} type=sha,enable=true,priority=100,prefix=,suffix=,format=short @@ -508,8 +503,6 @@ jobs: images: | ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}-ee-reports tags: | - type=ref,event=branch - type=ref,event=pr type=semver,pattern={{version}} type=semver,pattern={{major}}.{{minor}} type=sha,enable=true,priority=100,prefix=,suffix=,format=short @@ -594,7 +587,6 @@ jobs: flavor: | latest=false tags: | - type=ref,event=pr type=semver,pattern={{version}} type=semver,pattern={{major}}.{{minor}} @@ -641,7 +633,6 @@ jobs: flavor: | latest=false tags: | - type=ref,event=pr type=semver,pattern={{version}} type=semver,pattern={{major}}.{{minor}} diff --git a/frontend/src/lib/components/AppConnectInner.svelte b/frontend/src/lib/components/AppConnectInner.svelte index c444a47169..b99ad4855c 100644 --- a/frontend/src/lib/components/AppConnectInner.svelte +++ b/frontend/src/lib/components/AppConnectInner.svelte @@ -89,6 +89,10 @@ valueToken = undefined await loadConnects() manual = !connects?.includes(resourceType) + if (manual && expressOAuthSetup) { + dispatch('error', 'Express OAuth setup is not available for non OAuth resource types') + return + } if (rt) { if (!manual && expressOAuthSetup) { await getScopesAndParams() diff --git a/frontend/src/lib/components/LightweightResourcePicker.svelte b/frontend/src/lib/components/LightweightResourcePicker.svelte index b9ea69096b..c5b34f9af9 100644 --- a/frontend/src/lib/components/LightweightResourcePicker.svelte +++ b/frontend/src/lib/components/LightweightResourcePicker.svelte @@ -10,6 +10,7 @@ import { Button, Drawer, DrawerContent } from './common' import { Plus } from 'lucide-svelte' import type { AppViewerContext } from './apps/types' + import { sendUserToast } from '$lib/toast' const dispatch = createEventDispatcher() @@ -17,7 +18,11 @@ export let value: string | undefined = initialValue export let resourceType: string | undefined = undefined export let disablePortal = false + export let expressOAuthSetup = false + export let disabled = false + let open = false + let refreshCount = 0 const appViewerContext = getContext('AppViewerContext') let valueSelect = @@ -56,40 +61,64 @@ let drawer: Drawer | undefined = undefined + export function askNewResource() { + refreshCount += 1 + open = true + } + function processEvent(event: MessageEvent) { if (event.origin !== window.location.origin) { return } + if (event.data.type === 'error') { + sendUserToast(event.data.error, true) + } if (event.data.type === 'refresh') { + window.removeEventListener('message', processEvent) value = event.data.detail valueSelect = { value, label: value } drawer?.closeDrawer?.() + open = false } } - - -