From e96790c838d261e553cf71dcade726f1723ea52b Mon Sep 17 00:00:00 2001 From: Ruben Fiszel Date: Wed, 30 Aug 2023 18:27:12 +0200 Subject: [PATCH] fix: avoid perpetual spinning of recompute all component --- .../apps/components/helpers/RunnableComponent.svelte | 2 ++ .../lib/components/apps/editor/RecomputeAllComponents.svelte | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/frontend/src/lib/components/apps/components/helpers/RunnableComponent.svelte b/frontend/src/lib/components/apps/components/helpers/RunnableComponent.svelte index 86b4ed229c..d5f4520325 100644 --- a/frontend/src/lib/components/apps/components/helpers/RunnableComponent.svelte +++ b/frontend/src/lib/components/apps/components/helpers/RunnableComponent.svelte @@ -387,6 +387,7 @@ recordJob(jobId!, undefined, errors, transformerResult) updateResult(res) dispatch('handleError', errors) + donePromise?.() return } @@ -396,6 +397,7 @@ recordJob(jobId!, res, undefined, transformerResult) updateResult(transformerResult) dispatch('handleError', transformerResult.error) + donePromise?.() return } diff --git a/frontend/src/lib/components/apps/editor/RecomputeAllComponents.svelte b/frontend/src/lib/components/apps/editor/RecomputeAllComponents.svelte index d434ef2ca6..0205ef20b2 100644 --- a/frontend/src/lib/components/apps/editor/RecomputeAllComponents.svelte +++ b/frontend/src/lib/components/apps/editor/RecomputeAllComponents.svelte @@ -58,7 +58,9 @@ return } - return $runnableComponents?.[id]?.cb?.map((f) => f()) + return $runnableComponents?.[id]?.cb?.map((f) => + f().then(() => console.log('refreshed', id)) + ) }) .filter(Boolean)