feat(worker): support workers to run natively on windows (#4446)

* minimal code change to get windmill worker on windows for bun and python + rustfmt * adding support for powershell * compiling error on unix * rust linting comments * comments hugo: PSModulePath * comments ruben, refactor to simplify * adding build workflow * editing workflow * editing workflow * editing workflow * editing workflow * editing workflow * skip migration env, ee fixes * improvements powershell * testing windows runner * testing windows runner * testing windows runner * testing windows runner * testing windows runner * install postgres on runner * install postgres on runner * install postgres on runner * install postgres on runner * install postgres on runner * install postgres on runner * install postgres on runner * install postgres on runner * killing process tree in windows * sqlx_offline * install openssl for github windows runner * used pre-installed openssl * used pre-installed openssl * build ee * build ee * build ee * build ee * adding commented out steps for artifact publishing * build on tag matchinv v* pattern * ren instead of mv on Windows Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> * fix merging issue * gate imports for windows * fixing default cargo home path... * fixing default cargo home path... * comments ruben * make pwsh default modules loading more robust on unix (#4448) Co-authored-by: Ruben Fiszel <ruben@windmill.dev> --------- Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> Co-authored-by: HugoCasa <hugo@casademont.ch> Co-authored-by: Ruben Fiszel <ruben@windmill.dev>
2026-08-25 16:02:11 +00:00 · 2024-10-03 09:59:12 -04:00
parent 1d8e361612
commit f5c4727274
15 changed files with 404 additions and 56 deletions
@@ -64,6 +64,9 @@ use crate::{
    PIP_INDEX_URL, TZ_ENV,
 };

+#[cfg(windows)]
+use crate::SYSTEM_ROOT;
+
 pub async fn create_dependencies_dir(job_dir: &str) {
    DirBuilder::new()
        .recursive(true)
@@ -399,6 +402,9 @@ except BaseException as e:
    let mut reserved_variables = get_reserved_variables(job, &client.token, db).await?;
    let additional_python_paths_folders = additional_python_paths.iter().join(":");

+    #[cfg(windows)]
+    let additional_python_paths_folders = additional_python_paths_folders.replace(":", ";");
+
    if !*DISABLE_NSJAIL {
        let shared_deps = additional_python_paths
            .into_iter()
@@ -475,6 +481,10 @@ mount {{
            .args(vec!["-u", "-m", "wrapper"])
            .stdout(Stdio::piped())
            .stderr(Stdio::piped());
+
+        #[cfg(windows)]
+        python_cmd.env("SystemRoot", SYSTEM_ROOT.as_str());
+
        start_child_process(python_cmd, PYTHON_PATH.as_str()).await?
    };

@@ -1016,7 +1026,12 @@ pub async fn handle_python_reqs(
            start_child_process(nsjail_cmd, NSJAIL_PATH.as_str()).await?
        } else {
            let fssafe_req = NON_ALPHANUM_CHAR.replace_all(&req, "_").to_string();
+            #[cfg(unix)]
            let req = format!("'{}'", req);
+
+            #[cfg(windows)]
+            let req = format!("{}", req);
+
            let mut command_args = vec![
                PYTHON_PATH.as_str(),
                "-m",
@@ -1072,19 +1087,35 @@ pub async fn handle_python_reqs(

            tracing::debug!("pip install command: {:?}", command_args);

-            let mut flock_cmd = Command::new(FLOCK_PATH.as_str());
-            flock_cmd
-                .env_clear()
-                .envs(envs)
-                .args([
-                    "-x",
-                    &format!("{}/pip-{}.lock", LOCK_CACHE_DIR, fssafe_req),
-                    "--command",
-                    &command_args.join(" "),
-                ])
-                .stdout(Stdio::piped())
-                .stderr(Stdio::piped());
-            start_child_process(flock_cmd, FLOCK_PATH.as_str()).await?
+            #[cfg(unix)]
+            {
+                let mut flock_cmd = Command::new(FLOCK_PATH.as_str());
+                flock_cmd
+                    .env_clear()
+                    .envs(envs)
+                    .args([
+                        "-x",
+                        &format!("{}/pip-{}.lock", LOCK_CACHE_DIR, fssafe_req),
+                        "--command",
+                        &command_args.join(" "),
+                    ])
+                    .stdout(Stdio::piped())
+                    .stderr(Stdio::piped());
+                start_child_process(flock_cmd, FLOCK_PATH.as_str()).await?
+            }
+
+            #[cfg(windows)]
+            {
+                let mut pip_cmd = Command::new(PYTHON_PATH.as_str());
+                pip_cmd
+                    .env_clear()
+                    .envs(envs)
+                    .env("SystemRoot", SYSTEM_ROOT.as_str())
+                    .args(&command_args[1..])
+                    .stdout(Stdio::piped())
+                    .stderr(Stdio::piped());
+                start_child_process(pip_cmd, PYTHON_PATH.as_str()).await?
+            }
        };

        let child = handle_child(