From f7c314b246ad9407d67337bf62c09fe7d5e62028 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jakub=20Ko=C5=82odziejczak?=
 <31549762+mrl5@users.noreply.github.com>
Date: Sun, 30 Oct 2022 20:39:01 +0100
Subject: [PATCH] fix(deno-client): add missing approver encoding to hmac api
 request (#829)

related to 17064138c288ab7d1c3c84801f53e74770db0d9d
---
 deno-client/mod.ts | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/deno-client/mod.ts b/deno-client/mod.ts
index dc0fb9e629..db6d62a5b0 100644
--- a/deno-client/mod.ts
+++ b/deno-client/mod.ts
@@ -152,8 +152,17 @@ export interface NonceAndHmac {
  */
 export async function genNounceAndHmac(workspace: string, jobId: string, approver?: string): Promise<NonceAndHmac> {
     const nonce = Math.floor(Math.random() * 4294967295);
-    const sig = await fetch(Deno.env.get("WM_BASE_URL") +
-        `/api/w/${workspace}/jobs/job_signature/${jobId}/${nonce}?token=${Deno.env.get("WM_TOKEN")}${approver ? `&approver=${approver}` : ''}`)
+    const u = new URL(
+        `/api/w/${workspace}/jobs/job_signature/${jobId}/${nonce}`,
+        Deno.env.get("WM_BASE_URL"),
+    );
+
+    u.searchParams.append('token', Deno.env.get("WM_TOKEN"));
+    if (approver) {
+        u.searchParams.append('approver', approver);
+    }
+
+    const sig = await fetch(u.toString());
     return {
         nonce,
         signature: await sig.text()