From fb395655e6508a3c809bc5a7ade18cb40758fea2 Mon Sep 17 00:00:00 2001 From: Faton Ramadani Date: Thu, 29 Dec 2022 06:47:53 -0500 Subject: [PATCH] App bugfix (#1049) * adapt static adapter to cloudflare * fix(frontend): Various bug fix * fix typecheck * numerous fixes * fix all connects * fix all connects * more improvements * more improvements * everything work? Co-authored-by: Ruben Fiszel --- frontend/src/global.d.ts | 4 +- .../lib/components/InputTransformForm.svelte | 1 + .../src/lib/components/SchemaEditor.svelte | 3 + frontend/src/lib/components/SchemaForm.svelte | 74 +++++---- .../src/lib/components/TestJobLoader.svelte | 2 +- frontend/src/lib/components/Toggle.svelte | 25 ++- .../apps/components/buttons/AppButton.svelte | 19 ++- .../components/dataDisplay/AppBarChart.svelte | 9 +- .../components/dataDisplay/AppPieChart.svelte | 2 +- .../apps/components/form/AppForm.svelte | 8 + .../components/helpers/AlignWrapper.svelte | 4 +- .../apps/components/helpers/InputValue.svelte | 22 ++- .../helpers/NonRunnableComponent.svelte | 5 + .../helpers/RunnableComponent.svelte | 39 +++-- .../selectInputs/AppCheckbox.svelte | 4 + .../apps/components/table/AppTable.svelte | 22 ++- .../components/textInputs/AppTextInput.svelte | 11 +- .../components/apps/editor/AppEditor.svelte | 115 ++++++++----- .../apps/editor/AppEditorHeader.svelte | 7 +- .../components/apps/editor/AppPreview.svelte | 1 + .../apps/editor/ComponentEditor.svelte | 14 +- .../apps/editor/ComponentHeader.svelte | 71 ++++---- .../components/apps/editor/GridEditor.svelte | 103 +++++++----- .../apps/editor/RecomputeAllComponents.svelte | 5 +- .../apps/editor/SettingsPanel.svelte | 4 +- .../components/apps/editor/TablePanel.svelte | 1 + .../componentsPanel/ComponentList.svelte | 20 +-- .../componentsPanel/componentStaticValues.ts | 2 +- .../apps/editor/componentsPanel/data.ts | 26 ++- .../contextPanel/ComponentOutputViewer.svelte | 1 + .../editor/contextPanel/ContextPanel.svelte | 93 +++++------ .../InlineScriptEditorPanel.svelte | 81 +++++++--- .../InlineScriptsPanel.svelte | 4 +- .../InlineScriptsPanelList.svelte | 153 +++++++++--------- .../ArrayStaticInputEditor.svelte | 3 +- .../ComponentInputTypeEditor.svelte | 10 +- .../settingsPanel/ComponentPanel.svelte | 29 ++-- .../settingsPanel/InputsSpecEditor.svelte | 34 +++- .../settingsPanel/InputsSpecsEditor.svelte | 43 +++-- .../editor/settingsPanel/Recompute.svelte | 2 +- .../settingsPanel/SelectedRunnable.svelte | 27 +++- .../editor/settingsPanel/SubTypeEditor.svelte | 4 +- .../editor/settingsPanel/TableActions.svelte | 28 ++-- .../settingsPanel/common/PanelSection.svelte | 11 +- .../inputEditor/RowInputEditor.svelte | 9 ++ .../inputEditor/StaticInputEditor.svelte | 9 +- .../mainInput/InlineScriptList.svelte | 3 +- .../mainInput/RunnableSelector.svelte | 13 +- frontend/src/lib/components/apps/inputType.ts | 25 +-- frontend/src/lib/components/apps/rx.ts | 15 +- frontend/src/lib/components/apps/types.ts | 3 +- frontend/src/lib/components/apps/utils.ts | 2 +- .../components/common/button/Button.svelte | 4 +- .../flows/pickers/PickHubScript.svelte | 2 +- 54 files changed, 752 insertions(+), 479 deletions(-) create mode 100644 frontend/src/lib/components/apps/editor/settingsPanel/inputEditor/RowInputEditor.svelte diff --git a/frontend/src/global.d.ts b/frontend/src/global.d.ts index 05d64563a0..e6cd83aeb2 100644 --- a/frontend/src/global.d.ts +++ b/frontend/src/global.d.ts @@ -37,7 +37,7 @@ declare module 'svelte-grid' { export interface Props { fillSpace?: boolean - items: FilledItem[] + items: FilledItem[], rowHeight: number cols: [number, number][] gap?: [number, number] @@ -59,7 +59,7 @@ declare module 'svelte-grid' { pointerup: CustomEvent<{ id: string }> }, Slots - > {} + > { } } declare module 'svelte-grid/build/helper/index.mjs' { diff --git a/frontend/src/lib/components/InputTransformForm.svelte b/frontend/src/lib/components/InputTransformForm.svelte index d644272bb1..cc0c1c90f8 100644 --- a/frontend/src/lib/components/InputTransformForm.svelte +++ b/frontend/src/lib/components/InputTransformForm.svelte @@ -27,6 +27,7 @@ export let pickForField: string | undefined = undefined export let variableEditor: VariableEditor | undefined = undefined export let itemPicker: ItemPicker | undefined = undefined + export let noVariablePicker = false let monaco: SimpleEditor | undefined = undefined let monacoTemplate: TemplateEditor | undefined = undefined diff --git a/frontend/src/lib/components/SchemaEditor.svelte b/frontend/src/lib/components/SchemaEditor.svelte index 896ce5d10b..00781a782f 100644 --- a/frontend/src/lib/components/SchemaEditor.svelte +++ b/frontend/src/lib/components/SchemaEditor.svelte @@ -16,6 +16,9 @@ const dispatch = createEventDispatcher() export let schema: Schema = emptySchema() + if (!schema) { + schema = emptySchema() + } let schemaModal: SchemaModal let schemaString: string = '' diff --git a/frontend/src/lib/components/SchemaForm.svelte b/frontend/src/lib/components/SchemaForm.svelte index 794069eaf9..18950c3e13 100644 --- a/frontend/src/lib/components/SchemaForm.svelte +++ b/frontend/src/lib/components/SchemaForm.svelte @@ -25,6 +25,7 @@ export let shouldHideNoInputs: boolean = false export let compact = false export let password: string | undefined = undefined + export let noVariablePicker = false let clazz: string = '' export { clazz as class } @@ -48,8 +49,8 @@ $: schema?.properties && removeExtraKey() let pickForField: string | undefined - let itemPicker: ItemPicker - let variableEditor: VariableEditor + let itemPicker: ItemPicker | undefined = undefined + let variableEditor: VariableEditor | undefined = undefined
@@ -66,6 +67,7 @@ bind:extraLib {variableEditor} {itemPicker} + {noVariablePicker} bind:pickForField /> {:else if typeof args == 'object'} @@ -102,40 +104,42 @@ {/if}
- { - if (pickForField) { - if (inputTransform) { - args[pickForField].value = '$var:' + path - } else { - args[pickForField] = '$var:' + path +{#if !noVariablePicker} + { + if (pickForField) { + if (inputTransform) { + args[pickForField].value = '$var:' + path + } else { + args[pickForField] = '$var:' + path + } } - } - }} - itemName="Variable" - extraField="name" - loadItems={async () => - (await VariableService.listVariable({ workspace: $workspaceStore ?? '' })).map((x) => ({ - name: x.path, - ...x - }))} -> -
+ (await VariableService.listVariable({ workspace: $workspaceStore ?? '' })).map((x) => ({ + name: x.path, + ...x + }))} > - -
-
+ + +
- + +{/if} diff --git a/frontend/src/lib/components/TestJobLoader.svelte b/frontend/src/lib/components/TestJobLoader.svelte index fb9ad68611..cf23bbdef3 100644 --- a/frontend/src/lib/components/TestJobLoader.svelte +++ b/frontend/src/lib/components/TestJobLoader.svelte @@ -162,7 +162,7 @@ notfound = false } catch (err) { intervalId && clearIntervalAsync(intervalId!) - isLoading = false + clearCurrentJob() if (err.status === 404) { notfound = true } diff --git a/frontend/src/lib/components/Toggle.svelte b/frontend/src/lib/components/Toggle.svelte index c881f83bfc..16df3cd3e2 100644 --- a/frontend/src/lib/components/Toggle.svelte +++ b/frontend/src/lib/components/Toggle.svelte @@ -1,4 +1,5 @@ - -