From ff8e98feb8b703af597759a2454f272ddd0036c8 Mon Sep 17 00:00:00 2001
From: wendrul <53628737+wendrul@users.noreply.github.com>
Date: Wed, 4 Dec 2024 18:33:41 +0100
Subject: [PATCH] Remove unused env vars from docker compose + css fixes
 (#4841)

---
 docker-compose.yml                            |  6 ---
 .../search/GlobalSearchModal.svelte           |  4 +-
 .../SplitPanesOrColumnOnMobile.svelte         | 44 +++++++++----------
 .../(root)/(logged)/service_logs/+page.svelte |  2 +-
 4 files changed, 25 insertions(+), 31 deletions(-)

diff --git a/docker-compose.yml b/docker-compose.yml
index d45e589808..13d1c3ac98 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -129,12 +129,6 @@ services:
       - PORT=8001
       - DATABASE_URL=${DATABASE_URL}
       - MODE=indexer
-      - TANTIVY_MAX_INDEXED_JOB_LOG_SIZE__MB=1 # job logs bigger than this will be truncated before indexing
-      - TANTIVY_S3_BACKUP_PERIOD__S=3600 # how often to backup the index into object storage
-      - TANTIVY_INDEX_WRITER_MEMORY_BUDGET__MB=100 # higher budget for higher indexing throughput
-      - TANTIVY_REFRESH_INDEX_PERIOD__S=300 #how often to start indexing new jobs
-      - TANTIVY_DOC_COMMIT_MAX_BATCH_SIZE=100000 #how many documents to batch in one commit
-      - TANTIVY_SHOW_MEMORY_EVERY=10000 #log memory usage and progress every so many documents indexed
     depends_on:
       db:
         condition: service_healthy
diff --git a/frontend/src/lib/components/search/GlobalSearchModal.svelte b/frontend/src/lib/components/search/GlobalSearchModal.svelte
index 599e8853cb..fc4db3bcf0 100644
--- a/frontend/src/lib/components/search/GlobalSearchModal.svelte
+++ b/frontend/src/lib/components/search/GlobalSearchModal.svelte
@@ -33,7 +33,7 @@
 	import ContentSearchInner from '../ContentSearchInner.svelte'
 	import { goto } from '$app/navigation'
 	import QuickMenuItem from '../search/QuickMenuItem.svelte'
-	import { enterpriseLicense, superadmin, workspaceStore } from '$lib/stores'
+	import { devopsRole, enterpriseLicense, superadmin, workspaceStore } from '$lib/stores'
 	import uFuzzy from '@leeoniya/ufuzzy'
 	import BarsStaggered from '../icons/BarsStaggered.svelte'
 	import { scroll_into_view_if_needed_polyfill } from '../multiselect/utils'
@@ -610,7 +610,7 @@
 						/>
 					{:else if tab === 'logs'}
 						<div class="p-2">
-							{#if !$superadmin}
+							{#if !$devopsRole}
 								<Alert title="Service logs are only available to superadmins" type="warning">
 									Service logs are only available to superadmins
 								</Alert>
diff --git a/frontend/src/lib/components/splitPanes/SplitPanesOrColumnOnMobile.svelte b/frontend/src/lib/components/splitPanes/SplitPanesOrColumnOnMobile.svelte
index a609b74637..39191e6ade 100644
--- a/frontend/src/lib/components/splitPanes/SplitPanesOrColumnOnMobile.svelte
+++ b/frontend/src/lib/components/splitPanes/SplitPanesOrColumnOnMobile.svelte
@@ -11,27 +11,27 @@
 	let clientWidth = window.innerWidth
 </script>
 
-<main class="h-screen w-full" bind:clientWidth>
-	{#if clientWidth >= 768}
-		<SplitPanesWrapper class="hidden md:block">
-			<Splitpanes>
-				<Pane size={30} minSize={25}>
-					<slot name="left-pane" />
-				</Pane>
-				<Pane size={70} minSize={25}>
+<main class="flex-grow w-full overflow-y-auto" bind:clientWidth>
+		{#if clientWidth >= 768}
+			<SplitPanesWrapper class="hidden md:block">
+				<Splitpanes>
+					<Pane size={leftPaneSize} minSize={leftPaneMinSize}>
+						<slot name="left-pane" />
+					</Pane>
+					<Pane size={rightPaneSize} minSize={rightPaneMinSize}>
+						<slot name="right-pane" />
+					</Pane>
+				</Splitpanes>
+			</SplitPanesWrapper>
+		{:else}
+			<div class="flex flex-col">
+				{#if rightPaneIsFirstInCol}
 					<slot name="right-pane" />
-				</Pane>
-			</Splitpanes>
-		</SplitPanesWrapper>
-	{:else}
-		<div class="flex flex-col">
-			{#if rightPaneIsFirstInCol}
-				<slot name="right-pane" />
-				<slot name="left-pane" />
-			{:else}
-				<slot name="left-pane" />
-				<slot name="right-pane" />
-			{/if}
-		</div>
-	{/if}
+					<slot name="left-pane" />
+				{:else}
+					<slot name="left-pane" />
+					<slot name="right-pane" />
+				{/if}
+			</div>
+		{/if}
 </main>
diff --git a/frontend/src/routes/(root)/(logged)/service_logs/+page.svelte b/frontend/src/routes/(root)/(logged)/service_logs/+page.svelte
index d378026430..ae080cb967 100644
--- a/frontend/src/routes/(root)/(logged)/service_logs/+page.svelte
+++ b/frontend/src/routes/(root)/(logged)/service_logs/+page.svelte
@@ -11,7 +11,7 @@
 	let queryParseErrors: string[] | undefined = undefined
 </script>
 
-<div class="w-full h-screen px-2">
+<div class="flex flex-col w-full h-screen max-h-screen max-w-screen px-2">
 	<div class="px-2">
 		<div class="flex items-center space-x-2 flex-row justify-between">
 			<div class="flex flex-row flex-wrap justify-between py-2 my-4 px-4 gap-1 items-center">