5 Commits

Author	SHA1	Message	Date
Guilhem	eadeac248b	feat: sessions page with isolated AI chat + flow editor (#9034) ... * feat(sessions): chat + editor side-by-side with multi-session state Introduces the Sessions feature: a workspace where the AI chat and an editor (flow / script / app / raw-app) sit side-by-side, with each session having its own AIChatManager instance, history, and target item. Sessions are persisted across reloads and can be staged into forks for review. Key pieces: - sessions/ — SessionWrapper (the split-pane shell), SessionPicker (sidebar list), SessionForkBar, SessionWorkspaceBar, FlowEditorView / ScriptEditorView / AppEditorView / RawAppEditorView, ForkDiffDrawer, sessionRuntime (per-session AIChatManager + draft state), sessionState (in-memory + persisted index), sessionUnread, sessionScope, appDraftCodec / flowDraftCodec, forkEditUrl, /sessions route. - WorkspaceItemDrillPicker refactor — extracts WorkspaceItemRow + adds surfaceAI drafts, stale-while-revalidate. workspacePicker.ts drops explicit invalidate() in favor of always re-fetching in the background. - ForkDiffDrawer + WorkspaceItemDiffViewer — per-kind diff bodies reusable from the compare page. FlowGraphDiffViewer / FlowGraphV2 gain inlineDiff forwarding + onHeight callback for equal-height layout. - Global AI chat sessions plumbing — AIChatManager exports the class + adds disabledModes, beforeSend hook, scoped instance context. AIChat / AIChatDisplay accept session-only props (wideLayout, emptyHint, inputPreface, hideHeader, hideModeSelector, forceDisabled). Chat preserved across /flows/add → /flows/edit, /scripts/add → /scripts/edit. - Draft-first loaders — sessions open drafts when present, otherwise seed a draft from the last deployed value via globalDraftStore. RawAppEditor / AppEditor / AppEditorHeaderDeploy get newApp prop + fixes so draft-only apps can deploy. - Compare page (/forks/compare) — bigger overhaul to plug into the new drawer. - Sidebar — Sessions entry + unread badge + status dot in SidebarContent / MenuButton / SideBarNotification. - Misc fixes — chat group color palette constraint, deploy_workspace_item confirmation dropped, open_preview tool, picker drafts surfacing, fork archive/delete buttons on compare page. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(sessions): bypass UserDraft inside session panes + sessionUnread crash After merging main's UserDraft PR (#9121) into the sessions branch, two integration issues surfaced: 1. AppEditor.svelte calls `UserDraft.use<App>('app', path)` at the component level — keyed by ($workspaceStore, 'app', path). Sessions that haven't materialized a fork yet stay at the user's main workspace, so a session targeting an app at the same path as a regular /apps/edit tab shared the same LS key. The session would read the regular tab's autosave and write its fork-edits back over it. Gate UserDraft.use on `!getContext('aiChatManager')` — sessions inject the manager via setContext, so inside a session pane the handle is `undefined`, stateApp falls through to the `app` prop the session loaded, and the auto-save $effect bails. Same gate on the four UserDraft.remove call sites in AppEditorHeader and RawAppEditorHeader so save/deploy from a session pane doesn't wipe the LS draft of a non-session tab at the same path. 2. sessionUnread.svelte.ts called useLocalStorageValue at module scope. Main's PR added a deep-mutation $effect inside that helper, which now requires component-initialization context — every page crashed at import time with `Svelte error: effect_orphan`. Replaced with a plain module-level $state + manual localStorage persist; same reactivity contract for callers. 3. ScriptEditorView.svelte was passing a `replaceStateFn` prop that ScriptBuilder dropped on main. Removed. Verified end-to-end with Playwright: - /flows/edit/{path} regression: UserDraft handle still created, no console errors - /sessions loads, sessionUnread doesn't crash - Session targeting non-raw app `u/admin/userdraft_collision_test` displays the fork content (FORK_ONLY_MARKER) even with an LS poison at `userdraft/w/local/app/{path}` containing a POISONED_BY_REGULAR_TAB_AUTOSAVE marker; poison remains untouched after the session loads and renders Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(sessions): stop fork-create retry loop on first user message Removed the SessionWrapper $effect that retroactively committed the session's workspace from the in-memory chat history. When opening a session whose previous commit attempt had failed (or whose response was lost) the effect ran in a tight retry loop, flooding the user with `workspace_pkey` violations from `create_workspace_fork`. The send path already commits through `AIChatManager.beforeSend` → `commitSessionWorkspace`, which is the deterministic moment-of-action. The $effect was a redundant reactive bridge that turned every backend failure into an infinite retry. Also hardens `materializeFork`/`commitSessionWorkspace` so the most common cause of the duplicate-key error self-heals: - `materializeFork` short-circuits when `fork.id` is already in `$userWorkspaces` (the previous create actually succeeded, we just lost the response). On a `workspace_pkey` catch, refresh the workspace list and adopt the existing row instead of toasting an error. - On a real `materializeFork` failure, `commitSessionWorkspace` now drops `pending_fork` so the session falls through to the workspace-pick fallback instead of looping on the same broken intent. * feat(sessions): show EditorHeader breadcrumb in the not-found state When a session's target item has been deleted or moved, the editor pane used to render a bare "Script not found at path X" line — leaving the user with no way to navigate to a different target without backing out of the session. Each editor view now renders a `SessionItemNotFound` shell instead: a real `EditorHeader` (read-only summary, no pen popover) with a breadcrumb keyed to the missing kind+path, plus the "not found" copy below. Clicking any breadcrumb segment opens the workspace picker scoped to that level — pick a replacement and the session swaps target via the existing `onNavigate` callback. `SessionItemNotFound` maps `raw_app` to `EditorHeader`'s `kind: 'app' + raw_app: true` so the picker routes through `/apps_raw/...`; the local label still says "Raw app not found" (not "App not found") so the user knows which surface is missing. * fix(picker): stop self-feeding fetch effect that OOM'd the tab The drill picker's $effect watched `scope` and called `ensureLoaded` on every change. `ensureLoaded` reads `loaded[kind]` synchronously (to decide whether to show a spinner), so the effect ended up subscribed to the very signal it fills. Each fetch result wrote `loaded[kind] = items`; Svelte 5's $state proxy notifies on every property set even when the reference is unchanged from cache, which refired the effect, which called `ensureLoaded` again, which awaited the cached fetch, which wrote `loaded[kind]` again... runaway loop. In `/scripts/edit/...` the picker's lifecycle stabilised quickly enough to mask the loop, but in a session pane (multiple warm sessions, picker kept alive by the surrounding state) the cycle spun freely — 29.8 million iterations in <100 ms during testing, enough to OOM Firefox / kill the Chromium tab. Two changes: - Replace the scope-watching $effect with an explicit `setScope()` helper called from `drill()`, `goUp()`, and `onMount`. Fetch is now a callback reaction to user navigation, never a reactive consequence of one. No closed feedback cycle is possible. - Untrack the `loaded[kind]` read inside `ensureLoaded`. The search $effect (which loads every kind on first keystroke) is still a reactive caller; the untrack stops it from subscribing to the signal `ensureLoaded` fills, so the same loop can't form there. * feat(script-editor): wire initialTestPanelCollapsed through ScriptBuilder The `initialTestPanelCollapsed` prop was already declared on `ScriptBuilderProps` (used by the session preview to start the editor with the run/test pane closed) but never destructured in `ScriptBuilder.svelte`, so the value silently dropped on the floor and the test pane always opened. - `ScriptBuilder.svelte` — destructure the prop and forward it to `<ScriptEditor>`. - `ScriptEditor.svelte` — accept the prop and seed `rawTestPanelSize` to 0 when true, while keeping `storedTestPanelSize` at the default 30 so the user's first toggle expands the pane to a sensible width rather than 0. Regular `/scripts/edit/...` doesn't pass the prop → default `false` → panel still opens by default. * fix(sessions): resolve aiChatManager via context in AskUserQuestionDisplay Inside a session the chat uses a per-pane AIChatManager injected via context. AskUserQuestionDisplay imported the global singleton, so answers clicked in a session dispatched to the singleton's callback map and the AI loop stalled. Resolve via getContext with singleton fallback, matching ChatMode / ToolExecutionDisplay. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(raw_apps): let preview start in single-view on the preview tab Add a defaultSplitWithPreview prop (default true). When false (session preview), the editor boots in single view with the preview tab selected: gate the onMount default-file activation, the setActiveDocument auto-activation, and iframeShouldMount so the UI Builder bundler iframe still mounts when preview is the active tab. RawAppEditorView passes defaultSplitWithPreview={false}. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(copilot): add get_preview_status tool and make open_preview idempotent So the assistant can tell whether the session preview already shows the item it just edited, instead of re-opening or re-offering it. Mirrors the open_preview handler plumbing (setGetPreviewStatusHandler) and the session runtime registers it alongside open_preview. open_preview now returns 'already open' when the requested target matches the active session's current target. The system prompt steers the AI to check status before offering. Unit tests cover the no-arg schema, the session-only error, and handler dispatch. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(sessions): make script preview reactive to AI draft writes ScriptEditorView read the draft via static UserDraft.get inside an effect, which only subscribes to UserDraft's reactive cell when a live entry exists. None did for the preview path, so the chat's writes (UserDraft.save) only touched localStorage and the open preview never updated. Hold a live handle via UserDraft.useMany (reactive getter so it re-acquires when open_preview swaps the path without remounting) and read inbound through handle.draft, materializing the shared $state cell that bridges the chat's writes to the editor. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(sessions): make raw-app preview reactive to AI draft writes Mirror of the script-preview fix. RawAppEditorView read the draft via static UserDraft.get inside an effect, which only subscribes to UserDraft's reactive cell when a live entry exists. None did for the preview path, so the chat's raw-app writes (UserDraft.save / setDraftAndMeta, from write_app_file / patch_app_file / write_app_runnable) only touched localStorage and the open preview never updated. Hold a live handle via UserDraft.useMany (reactive getter so it re-acquires when open_preview swaps the path without remounting) and read inbound through handle.draft. Verified in-browser: an external UserDraft.save live-updates the bound summary in the open preview. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(sessions): make flow preview reactive to AI draft writes Mirror of the script/raw-app preview fixes, completing two-way binding for all three session editor kinds. FlowEditorView read the draft via static UserDraft.get inside an effect, which only subscribes to UserDraft's reactive cell when a live entry exists — none did, so the chat's writes (write_flow / patch_flow_json / set_flow_module_code) only touched localStorage and the open preview never updated. Hold a live handle via UserDraft.useMany (reactive getter so it re-acquires when open_preview swaps the path without remounting) and read inbound through handle.draft. Verified in-browser both directions: an external UserDraft.save live-updates the flow header summary and rebuilds the module graph; a preview edit propagates through the debounced save to both UserDraft.get and the chat's getGlobalDraft adapter. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(sessions): surface local-storage drafts in fork diff & compare page Augments the backend fork-vs-parent comparison with browser-local (UserDraft) drafts so a session's uncommitted AI/user changes are visible in the Fork Diff Viewer and the /forks/compare page. Adds forkDraftDiff.ts (augmentForkComparisonWithLocalDrafts + getForkItemValue), a 'local changes detected' / new-draft warning surface (checkbox-slot warning icon, no-op-baseline filtering, dedup), a 'Local draft <> fork' tab in DiffDrawer, and selectTooltip/nonSelectableTooltip plumbing in Row/WorkspaceDeployLayout. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * Revert "feat(sessions): surface local-storage drafts in fork diff & compare page" This reverts commit 3cfd858e36. * fix(sessions): leave for home when switching workspace from the session page An AI session is scoped to its (forked) workspace, so it makes no sense to keep showing it after the user picks a different workspace. The workspace switcher's link href now points home on the session route (the link navigation wins over onClick's preventDefault), and toggleSwitchWorkspace also redirects home there as a fallback. Session-switching uses a separate path (syncWorkspaceTo), so it's unaffected — which is why reacting at the switcher is more robust than watching workspaceStore. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(sessions): clear session highlight off the session page; default delete-fork on Two SessionPicker fixes: (1) only highlight the active session while on the /sessions route — currentSessionId lingers after navigating away, so the row stayed selected in the sidebar; gate the highlight on the route. (2) The 'Also delete forked workspace' toggle in the delete-session modal now defaults to on (the fork is tied to the session and would be orphaned otherwise); resets keep it defaulted-on for the next open. User can still untick it. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(copilot): say "local storage" instead of "draft" in write-tool status The global chat's write tools persist to the browser's localStorage (UserDraft), not a workspace draft. The tool status / result messages now say the item was saved to local storage (and discard says it was discarded from local storage) so users aren't misled into thinking a workspace draft was created. Covers the shared script/flow/trigger/resource/variable helpers and the app tools. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(sessions): sidebar collapse, new-session chat, fork delete & not-found nits - Hide the collapse chevron and make the section header non-interactive when there are no sessions; reset the persisted collapsed state while the list is empty so the first session always appears expanded. - Stop grafting a recent past chat onto a freshly created session: ensureChatIdsSeeded now skips transient sessions, so the seed only pairs untagged chats with pre-existing sessions. - After deleting a fork from a session (SessionPicker / SessionWrapper), fall back to the fork's parent workspace when the deleted fork was the active one, instead of stranding the user on a deleted workspace. - Show a 'Session not found' message (with a New session action) when the URL names a session that doesn't exist, rather than rendering a blank page. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(copilot): expose preview tools only to session chats open_preview and get_preview_status drive a session's side-panel editor, so they only make sense inside an AI session. They were always present in the global tool list and just errored when called outside a session. Now AIChatManager carries an isSessionChat flag (set by sessionRuntime.createRuntime); the GLOBAL-mode branch uses globalToolsFor({ sessionPreview }) to drop the two tools for the regular side-panel chat, and prepareGlobalSystemMessage omits their guidance unless previewTools is set. The module-level handlers + in-tool error guards stay as defense in depth. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * chore(flow-editor): move intra-editor chat preservation to its own PR The beforeNavigate / preserveChatOnDestroy guard that keeps the global FLOW chat alive across same-flow editor remounts is a standalone global-chat fix, unrelated to sessions. Split out to #9339; FlowEditor reverts to the plain session-guarded saveAndClear lifecycle here. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(raw-app): pre-boot session editor hidden so files open instantly In single-view (sessions) the UI Builder iframe was mounted inside a display:none wrapper while the Preview tab was active, so the VS Code workbench booted at 0x0, threw in its LayoutService ("Unable to figure out browser width and height"), and wedged the editor on "Loading editor" with no recovery when later revealed. Keep the iframe mounted at the editor area's real width and hide it with visibility instead of collapsing it: Monaco boots correctly while hidden, and revealing a file is an instant un-hide (no reload, no relayout, no latency). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore(flow-ai): move flow-group color-palette work to its own PR The flow-group color-palette guidance + validateFlowGroups guard + tests are an independent flow-AI improvement, not part of sessions. Split out to #9343; these three flow files revert to their main state here. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(sessions): hide the in-editor Flow AI Chat button in the session preview The flow preview pane in a session already sits next to the session's own AI chat, so FlowBuilder's in-editor "Flow AI Chat" toggle (which opens the global singleton chat) is redundant and confusing there. Pass customUi={{ topBar: { aiBuilder: false } }} from FlowEditorView, reusing the existing showFlowAiButton gate (!disableAi && customUi?.topBar?.aiBuilder != false) that flows down to FlowStickyNode — no new prop needed. Verified in-browser: the button (WandSparkles) renders in the regular /flows/edit route but is absent in the session preview for the same flow. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(sessions): mirror /scripts/add for never-saved scripts in editor preview An AI-created script with no backend version yet left savedScript undefined in the session preview, which disabled Save draft and hid Show diff. Open it as a new script (empty initialPath) like /scripts/add so Save draft is enabled and creates it on first save; seed the path as already-chosen (initialPathChosen) so the summary->path auto-slug does not rename the AI-assigned path. On first save ScriptBuilder writes savedScript back through the bind and flips into edit mode (Save draft + Show diff) without navigating away. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(sessions): refresh fork diff count after an editor draft save The fork-bar diff count reads a cached comparison refreshed only on AI-turn-end or tab refocus. A 'Save draft' in the session editor registers in the backend fork tally asynchronously (~300ms after the create returns), so the count stayed stale until one of those triggers fired. Add SessionRuntime.scheduleForkComparisonRefresh() (re-fetches at 700ms + 2200ms to clear the async tally) and wire it to onSaveDraft in ScriptEditorView and FlowEditorView. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(sessions): don't auto-open the settings drawer in script preview When the AI's open_preview tool previews a never-saved script, ScriptEditorView passes initialPath='' so ScriptBuilder behaves like /scripts/add. That empty path also triggered ScriptBuilder's auto-open of the settings drawer, which is unwanted in the session preview where the AI manages metadata. Pass neverShowMeta so the drawer stays closed on mount; the Settings button still opens it manually. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(sessions): don't host legacy drag-and-drop apps in the editor preview The session preview pane only hosts code-based items (flow, script, raw app). Drop the legacy 'app' kind from SessionTarget and the open_preview tool, and route a legacy app picked in the drill picker to the standalone /apps/edit editor instead. Removes the now-dead AppEditorView and its runtime load path. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(sessions): don't prompt to discard raw-app changes on navigation In a session the raw-app editor's content is continuously persisted to the UserDraft (localStorage), so tearing the editor down on navigation loses nothing. Skip the UnsavedConfirmationModal (and its beforeNavigate guard) when the editor is mounted inside a session pane; the standalone /apps_raw editor still shows it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(sidebar): pin Help to the bottom instead of floating The bottom of the sidebar stacked the User/Settings cluster and the Help block with a fixed ~40px gap between them, plus a bottom margin that kept Help from sitting flush — so Help appeared to float. Drop those fixed margins so the cluster and Help stay glued at the bottom with a small gap and Help is flush, and let mt-auto own the flexible space above the group. Add pt-4 so the cluster keeps a minimum gap from the Triggers section when the sidebar runs out of room and that flexible space collapses. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(sessions): surface diff/discard for AI script drafts in preview, refresh diff on deploy loadScript built the editor's scriptStore by aliasing and mutating savedScript.val, so the deployed baseline got overwritten with the draft content and the diff compared draft-vs-draft. Clone the baseline before layering the AI draft on top. On load, when the local draft diverges from the saved baseline, surface a toast ('AI saved a local draft') with Show diff (opens the diff drawer with a Discard-draft button) and Discard local draft — mirroring the regular /scripts/edit affordance the session's parallel loader omitted. Also wire onDeploy (alongside onSaveDraft) to scheduleForkComparisonRefresh so the fork diff count refreshes after a deploy, not just on an AI turn or tab refocus. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(sessions): script preview restore/deploy feedback; drop on-load draft toast - Implement real restoreDeployed/restoreDraft for the diff drawer: the shared loadScript-based handler was a no-op (loadScript early-returns on the loaded path and would re-read the local draft). Reset the live UserDraft handle to the chosen baseline (deleting the backend draft for 'restore to deployed') so the inbound effect syncs the editor. - Show a 'Deployed' toast on deploy: the default Deploy takes ScriptBuilder's no-toast branch (the editor navigates away instead); the session stays put, so surface the success toast. - Remove the on-load 'AI saved a local draft' toast: unnecessary in a session, where the user already expects their changes to be present. Diff/discard remain reachable via ScriptBuilder's Show diff + the diff drawer's restore buttons. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(sessions): gate breadcrumb picker draft-merge behind the dev flag The WorkspaceItemDrillPicker merges localStorage UserDrafts into its navigable items so in-flight session/chat drafts are reachable. That merge was ungated, so with the sessions dev flag off it also surfaced the standalone editors' autosave drafts — they appeared as navigable rows that 404 on the backend draft fetch. Gate aiDraftsForKind on isGlobalAiEnabled() so it is a no-op without the flag (no sessions exist then anyway); inside sessions the merge still works. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(editor): reload script/flow editor on client-side breadcrumb nav Picking a different item in the editor-header breadcrumb picker calls goto() for a client-side navigation. SvelteKit reuses the same +page instance across a path-param change, but the script and flow editor routes captured `draftPath` and the `UserDraft.use()` handle once at mount and never remounted ScriptBuilder/FlowBuilder. The URL and title updated while the editor kept showing the previous item's breadcrumb, summary and content; only a full reload showed the navigated-to item. Mirror the pattern the app / raw-app editors already use: - Derive the draft path from the URL and key the handle off it via `UserDraft.useMany` (a stable proxy onto the current handle), so the reload reads/writes the navigated-to item's draft instead of the previous one's — fixing the stale draft-comparison too. - Gate the builder subtree on a `renderEditor` flag flipped false when a navigation kicks off the reload and true once the data is ready, so the builder cleanly unmounts and remounts once against stable data. A synchronous `{#key}` swap instead races Monaco's async init against the torn-down container. - Flows also reset `nobackenddraft` per navigation so a fresh load reconsiders the backend draft. The unsaved-changes guard is unaffected (it runs in beforeNavigate, before the remount). The app and raw-app editors already handled this and are unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(sessions): sync preview with the deployed version on editor + chat deploy Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(sessions): reload the preview after a chat raw-app deploy The deploy-reload-preview callback added previously only fired for script and flow. Now that the merged deploy_workspace_item tool can deploy raw apps (bundle + createAppRaw/updateAppRaw), wire raw apps in too. A raw app deploys under type 'app' but the session preview addresses it as 'raw_app', so the deploy handler maps 'app' -> 'raw_app'; the runtime open-check gains the loadedRawAppPath case. syncPreviewWithDeployed already handled 'raw_app' (discard the local draft + force-reload via loadRawApp), so no runtime change was needed there. Adds a unit test asserting deploy_workspace_item(type:'app') notifies the session handler with { kind: 'raw_app', path }. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(sessions): address Claude PR review (3 P1 + 3 P2 + test) P1: - Drop the hardcoded placeholder default sessions (u/guilhempw/...). New users (empty/cleared/private-browsing localStorage) now start with no sessions and see the empty state instead of unresolvable "session not found" rows. - Scope the preview/deploy tool handlers to the *calling* session. open_preview, get_preview_status and the deploy reload handler dispatched via the global currentSessionId, so a backgrounded session's tool call mutated the UI-active session. The calling session id is now carried in the per-manager tool `helpers` (AIChatManager.sessionId, set in createRuntime) and threaded through the tool ctx to the handlers, which dispatch to it (falling back to the active id only when absent). Keeps backgrounded sessions isolated. - beforeSend now aborts the send on failure: commitSessionWorkspace throwing used to be swallowed, letting the message go out against the wrong workspace silently. Now it toasts and returns. Also guarded the unguarded listUserWorkspaces refresh in materializeFork's duplicate-key self-heal so a second network failure can't rethrow past the toast-and-return contract. P2: - disposeRuntime now clears the fork-comparison refresh timers (700ms/2200ms) via a new runtime.dispose(), so an evicted/deleted runtime can't fire a stray refreshForkComparisonNow/compareWorkspaces after teardown. - Convert Svelte 4 on:click -> Svelte 5 onclick on the Button components in SessionWrapper, SessionForkBar, ForkDiffDrawer, SessionPicker, sessions/+page. - WorkspaceItemRow's <a href> branch gains role="option" + aria-selected to match the <button> branch, for consistent listbox semantics. Tests: - core.test.ts: deploy_workspace_item(type:'app') threads the calling session id through helpers to the deploy handler ({ sessionId, kind:'raw_app', path }). - New sessionState.test.ts unit-tests deriveForkStatus + isForkSession across all branches (root/fork/unavailable/draft, ahead/behind/diverged/in_sync). svelte-check 0 errors; 57 frontend unit tests pass. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * refactor(copilot): collapse deploy preview-reload dispatch to a type→kind map Replace the if/else-if that mapped deploy type to preview kind with a single Partial<Record<WorkspaceItemType, ...>> lookup + one if. Non-previewable types map to undefined → no dispatch. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * refactor(copilot): use getAiChatManager() instead of inlining the context fallback Six chat components still inlined `getContext<AIChatManager>('aiChatManager') ?? singletonAiChatManager` even though aiChatManagerContext.ts already exports getAiChatManager() for exactly this (the resolve-scoped-instance-or-fall-back-to-singleton pattern, already used by AIChatDisplay/AIChatInput/AIChatMessage/CodeDisplay). Adopt it in DatatableCreationPolicy, ChatMode, ToolExecutionDisplay, AIChat, AskUserQuestionDisplay and flow/FlowAIChat, and drop the now-unused getContext / AIChatManager / singletonAiChatManager imports (FlowAIChat keeps getContext for its FlowEditorContext/FlowCopilotContext lookups). No behavior change — getAiChatManager() is the same resolution. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(sessions): consistent script deploy → preview sync; trim session deploy menu Two related session deploy fixes + clarifying comments. 1. Hide the extra deploy-dropdown options in the session script preview. The editor always "stays" and is already scoped to a fork, so Deploy & Stay here, Fork, Edit in workspace fork, Exit & See details and Export as YAML/JSON make no sense there — only "Show diff" is kept. ScriptBuilder gains `inSessionPane = !!getContext('aiChatManager')` (same pattern ScriptEditor uses) and gates those items. (They were correctly absent for never-deployed session scripts but leaked for deployed ones.) 2. Fire onDeploy on every successful script deploy. ScriptBuilder previously skipped onDeploy for "Deploy & Stay here" and lib scripts (it just re-pinned parent_hash + toasted), so a session preview wouldn't sync after those. Now onDeploy always fires with a `stay` flag; route consumers skip navigation when stay (behaviour identical to before — stay → toast only, primary → navigate), and the session ignores stay and always syncs. With (1) hiding Deploy & Stay, this now covers the lib-script-in-session case. 3. Comments: RawAppEditorHeader / AppEditorHeader note that the `if (!inSessionPane) UserDraft.remove` guards are intentional — the editor doesn't own the localStorage draft in a session (the runtime does, keyed by the fork); the session-side equivalent is the View's onDeploy → runtime.syncPreviewWithDeployed (discard fork draft + reload to deployed). svelte-check 0 errors; session dropdown verified to show only "Show diff" for a deployed script, route deploy menu unchanged. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(sidebar): single Menubar so bottom menus hover-switch (WIN-1993) The bottom sidebar group split Settings/Workers/Folders/Logs and Help across two separate <Menubar> components. melt-ui's hover-to-switch (open menu closes when another trigger in the same Menubar is hovered) only coordinates within a single Menubar, so hovering between the two groups left both menus open (stacked) instead of switching. Collapse them into one Menubar, wrapping each group in its own flex container to preserve spacing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(editor): gate external code sync behind opt-in syncExternalCode prop The unconditional `code` prop->Monaco sync effect added for sessions live-preview ran for every <Editor> caller (14 call sites). Most either bind:code with their own external-sync (e.g. ScriptEditor) or treat code as init-only, so a blanket setValue risked clobbering them. Gate the effect on a new opt-in `syncExternalCode` prop (default off) and enable it only at the two flow inline-rawscript editors — the case that actually needs external updates (AI chat editing a flow module's content reflecting live in the preview). Verified in-browser: AI-driven external edit to a flow step now reflects live in Monaco, and typing keeps the caret intact (round-trip guard). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(sessions): address P1 review findings (commit-abort, render-stuck, workspace sync) From the cubic/Claude PR review: 1. beforeSend now aborts the send when the workspace isn't committed. The earlier fix only caught a *thrown* error, but commitSessionWorkspace returns undefined (never throws) when a staged fork fails to materialise — so the first message + its tool calls shipped to get(workspaceStore) (the parent). beforeSend now throws on undefined so AIChatManager's catch toasts + aborts. 2. The script/flow edit reload effect set renderEditor=false then called loadScript()/loadFlow(); a rejected fetch left renderEditor stuck false, so the editor pane vanished and never remounted. Both calls now .catch → toast + renderEditor=true (token-safe), so the pane always remounts. 3. SessionWrapper.moveAndActivate now syncWorkspaceTo(target) — moving a session off an unavailable workspace was leaving the app pointed at the old one (mismatch with moveSessionToNewFork / handleConfirmedDelete). Test: sessionState.test.ts pins commitSessionWorkspace's failure contract (returns undefined + drops pending_fork when the fork fails) — the invariant the beforeSend abort relies on. svelte-check 0 errors; 58 frontend unit tests pass. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(sessions): address P2 review findings (cubic) Draft round-trip: - appDraftCodec: carry custom_path through runtimeRawAppToDraft / applyDraftToRuntimeRawApp (+ seed it in loadRawApp) so a session round-trip no longer erases a raw-app draft's custom URL. - sessionRuntime.loadScript "no draft" path: structuredClone the baseline before setting parent_hash — it could alias `result` (= savedScript.val) and corrupt the pristine deployed baseline the diff drawer reads. - FlowEditorView: include `summary` in the inbound/outbound dedup sigs so summary-only changes propagate/persist. Workspace-state on navigation: - SidebarContent (post-delete) and workspace_settings (post-archive): guard the listUserWorkspaces() refresh so a transient failure can't strand the user on the just-removed workspace, and refresh the list before switching to parent. - WorkspaceMenu: keep ?workspace=<id> in the session-page workspace href so a modifier/middle click (which bypasses onClick) lands in the right workspace. UI/keyboard: - WorkspaceItemRow: indent adds to the px-3 base (calc) instead of replacing it. - ForkDiffDrawer: ArrowLeft maps a 2-segment file path (f/foo) to its scope folder (folder:f/foo) instead of a nonexistent folder:f. - flows/edit: defer flowBuilder setup (primary schedule, draft triggers, loadFlowState) until after the builder remounts (renderEditor=true + tick), so reload-time state restoration isn't skipped on the unmounted builder. svelte-check 0 errors; 58 frontend unit tests pass. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(sessions): unit-test the P1/P2 review fixes (extract pure helpers) Extract the pure logic touched by the review fixes into small tested helpers (behaviour-preserving) and add unit tests: - appDraftCodec.test.ts — custom_path survives the runtime↔draft round-trip (A1). - forkDiffNav.ts/.test.ts — parentFolderKey (extracted from ForkDiffDrawer): ArrowLeft parent resolution incl. the 2-segment-path case (C2). - workspaceMenuHref.ts/.test.ts — extracted from WorkspaceMenu: session-route href keeps ?workspace=<id>; off-session swaps the param (B2). - flowDraftSig.ts/.test.ts — extracted from FlowEditorView (dedups 3 sig sites): the dedup signature includes summary, so summary-only changes propagate (A3). (commitSessionWorkspace failure-contract test for the beforeSend P1 landed with the P1 commit.) svelte-check 0 errors; 75 frontend unit tests pass. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(sessions): address second-round review (Pi + Codex) Three findings flagged post-push (cubic was fully addressed in the prior commits; this commit covers the new ones): - [P1] commitSessionWorkspace non-fork branch — when a session created inside a fork defaults pending_workspace_id to the family root, commit set s.workspace_id but never synced workspaceStore. First send's logAiChat + tool calls then ran against the wrong (still-fork) workspace. Fix: syncWorkspaceTo(ws) after the commit, mirroring the pending_fork branch's switchWorkspace(newId). - [P1] Warm-session live-editor slot hijack — /sessions keeps up to 3 warm-mounted sessions; UserDraft stores one live editor per (workspace, kind). Each editor view unconditionally claimed the slot, so a hidden warm session in the same workspace+kind could overwrite the visible session's claim — chat actions like discard / "the open editor" then resolved to the wrong session. Fix: thread isActiveSession from SessionWrapper into Script/Flow/RawAppEditorView and gate setLiveEditorDraft on it. - [P2] ForkDiffDrawer stale per-item raw diff cache — loadedDiffs / summaries persist for the drawer's lifetime; fetchComparison refetched on each open() but loadDiffFor short-circuited on cached keys, so an edit-then-reopen showed fresh counts but stale expanded content. Fix: clear both records at the top of fetchComparison. Tests: - sessionState.test.ts: 2 tests pinning commitSessionWorkspace's workspaceStore sync (mismatch and matching). - userDraft.test.ts: 3 tests pinning the live-editor slot collision (regression), the active-session gate, and cleanup ordering. - forkDiffCache.test.ts (new): 2 tests for the drawer cache invalidation contract via fetchComparison simulation. Verified end-to-end in browser: P2 (close+reopen drawer triggered an identical second batch of per-item get fetches), P1#1 (new-session send from a fork synced localStorage.workspace to root and posted chat to /api/w/local/...), P1#2 (raw_app slot for workspace=local correctly follows the visible session across A→B→A switches while both stay warm-mounted). svelte-check 0 errors; touched test suites green. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>	2026-06-01 10:22:50 +02:00
centdix	f234df97ec	fix: support raw app deployment history (#8657) ... * fix: support raw app deployment history Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: refresh deployment history diffs Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: preserve deployment history preview context Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: limit deployment history to diffs Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * chore: remove unused history backend hook Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>	2026-04-03 14:56:56 +00:00
Guilhem	81eb446eee	feat: flow group nodes with collapsible groups (#8075) ... * feat: add flow group nodes core infrastructure Add group data model (start_id/end_id boundary pairs), GroupEditor for CRUD operations, groupDetectionUtils for membership computation and validation, GroupedModulesProxy for reactive sync, and compound layout support. Update openflow.openapi.yaml with group schema. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: add group UI components and rendering Add GroupOverlay with bounding box and z-ordering, GroupHeader with StepCountTab and ellipsis menu, GroupNodeCard, GroupNoteArea for inline markdown notes, CollapsedGroupNode/CollapsedSubflowNode for collapsed rendering, GroupEndNode/GroupHeadNode boundary markers, and group actions in NodeContextMenu and SelectionBoundingBox. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: integrate groups into flow graph, builder, and existing components Wire group support into FlowGraphV2 (overlays, collapsed rendering, group-aware layout), graphBuilder (GroupedModule tree, container collapse/expand, group boundary nodes), BaseEdge (drop targets for group operations), ModuleNode (collapsed container rendering), and flow map components (schema item grouping). Remove SubflowBound in favor of CollapsedSubflowNode. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: remove banned $bindable(default) pattern and dead ternary Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: decouple collapse state from grouped module tree Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: pass groups prop to FlowGraphV2 and use GroupDisplayState via graphContext Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: remove group membership system, compute nesting depth from visual bounds Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: simplify GroupOverlay bounds, remove unused headerY and showNotes prop Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: populate innerNodeIds for expanded subflow overlay Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: remove expanded subflow overlay feature for separate PR Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: flatten groups in getContainerModules to prevent crash on collapsed containers Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: add drag-to-move support for group nodes Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: derive group boundaries from expanded membership to prevent splitting existing groups Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: catch group validation errors and display as flow graph alert Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * test: add unit tests for group validation in buildGroupedModules Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: reject virtual nodes (Input, Result, Trigger) from groups Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * test: add virtual node rejection tests for buildGroupedModules Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: exclude preprocessor and failure module from groups Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: disable Create group button when preprocessor is selected Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: reject selection entirely when it contains excluded nodes Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: remove unnecessary excludeIds from buildGroupedModules Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: remove debug console.log from FlowGraphV2 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: use cross-browser CSS grid trick for group summary input auto-sizing Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: hide group boundary edges and reformat GroupNoteArea Hide edges between group header and first node, and between last node and group-end, keeping them in the DOM but visually hidden. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: stop FlowGraphV2 from reading groups via groupEditorContext Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: show module previews with status, selection, and suspend popover in collapsed groups Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: extract collapsible implicit containers to separate branch Remove collapse/expand functionality for implicit containers (forloops, while loops, branches) from this branch. Backed up as collapsible-implicit-containers-backup for later rebase. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: use original reactive modules for graph node data instead of proxy snapshots Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: prevent node loss when moving into forloop inside a group Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: replace GroupedModule proxy with structure-only FlowStructureNode tree Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: use "group-" prefix for group IDs instead of "note-" Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: update group boundaries when renaming a module ID When a module at a group boundary (start_id or end_id) is renamed, the group definitions now get updated before the reactive rebuild, preventing stale references that would break the flow structure. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: update graph layout when removing a group note Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: add opaque background behind test run button to prevent see-through Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: detect and reject duplicate group IDs Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: simplify group creation validation with early marker normalization Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: use $state.raw in MiniFlowGraph to avoid xyflow performance warning Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: address code review feedback - Revert backend traverse_modules change (not part of this feature) - Use Map for node lookup in GroupOverlay (O(1) vs O(n) per group) - Extract computeNodeExtraSpace to nodeExtraSpace.ts for testability Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: address PR review feedback - Compute group depths from structure tree O(n) instead of O(n²) bounds comparison - Remove unnecessary $derived(groups) in GroupOverlay - Remove unused collapsed field from container types in OpenAPI spec - Use NODE.width constant in GroupNodeCard instead of hardcoded 275px - Add comment explaining intentional stale preservation in rebuild() Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: preserve flow groups during dependency job re-serialization Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: resolve Svelte state_referenced_locally warnings in GroupHeader and FlowGraphV2 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: show subflow groups when expanding a subflow in the graph - Store both modules and groups when expanding a subflow - Pass groups to buildStructureTree so group nodes render - Include subflow groups in overlay rendering and collapse tracking - Clone modules for prefix rewriting to avoid state_unsafe_mutation - Register expanded subflow modules in moduleMap before prefix rewriting - Disable group editing in expanded subflows and read-only views Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: restore accidentally removed code from main - Restore subflowBound selection handling in selectionUtils - Restore comments in SelectionBoundingBox - Restore deletable={false} in FirstStepInputs Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: remove redundant adjacency check from MoveManager The disableMoveIds check already prevents all invalid drop targets, making the adjacencySourceId/adjacencyTargetId fields unnecessary. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: regenerate auto-generated files after OpenAPI schema change Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: regenerate cli skills after main merge Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: include groups in view_graph localStorage state Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: centralize canCreateGroup and replace group note with group creation - Add canCreateGroup StateStore to GroupEditorContext, computed in FlowGraphV2 - Replace "Create group note" with "Create group" in FlowSelectionPanel - Remove "Add note" from selection bounding box dropdown - Remove unused NodeContextMenu component - Wire createGroup through FlowModuleSchemaMap → FlowGraphV2 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: reject groups spanning parallel branches and surface ill-formed group errors Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: regenerate auto-generated files after main merge Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: ensure modules appears before groups in YAML export Svelte 5's $state proxy registers groups as a tracked property before it's explicitly set, causing it to appear before modules in Object.keys iteration. Reorder the value object at export time for readable YAML. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: address second round of PR review feedback - Add comment explaining duplicateMultiple bypasses structure tree - Add warning log for inverted ranges in computeGroupModuleIds - Use NODE.width constant in CollapsedGroupNode instead of hardcoded 275px - Simplify redundant condition in getGroupsEmptiedBy Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: remove stored group ID, derive ephemeral key from start_id:end_id Groups no longer store an `id` field. Instead, a `groupKey(g)` helper derives an ephemeral key from `${start_id}:${end_id}` at read time. This simplifies the schema while preserving all runtime functionality. When boundaries shift (module deletion), runtime state (collapse, note heights) is remapped to the new key via GroupDisplayState.remapGroupKey. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: add note button, save/cancel hints, and rename collapsed_by_default to autocollapse Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: propagate selection from collapsed group badges to external listeners Pass eventHandlers to GroupModuleIcons so clicking a module badge calls both selectionManager.selectId (visual highlight) and eventHandlers.select (side panel propagation via onSelect). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: regenerate auto-generated files after main merge Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: hide In/Out popovers and actions during click-to-move Replace isDragging with isMoving derived that covers both drag-move and click-move states, disabling popovers, delete button, and test run button during any move operation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-03-24 16:47:33 +00:00
centdix	3d5b79c154	feat(aichat): simplify flow mode edits (#6981) ... * draft * Phase 1: Remove deprecated granular flow AI tools Simplify AI chat flow mode to use only YAML-based editing: - Remove all commented-out granular tools (add_step, remove_step, set_code, etc.) - Clean up FlowAIChatHelpers interface to only essential methods - Update system prompts to focus on YAML-only workflow - Remove unused imports and type definitions This is part of a larger refactoring to simplify the flow editing experience to a single YAML editing tool with automatic diff visualization. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * use minified json * use openflow in system prompt * handle inputs * cleaning * cleaning * diffmode in flowgraph * remove acceptrejectmodule * use new diff mode * cleaning * better props * better logic * cleaning * accept reject logic * use get set * draft manager * use diff manager * draft * Refactor flowDiffManager to be instance-based with auto-computation - Remove singleton export, making it instantiable per FlowGraphV2 - Add afterFlow state tracking for auto-diff computation - Add beforeInputSchema/afterInputSchema for schema change tracking - Add $effect for reactive auto-computation when beforeFlow/afterFlow changes - Add setAfterFlow() and setInputSchemas() methods - Simplify accept/reject methods to just mark pending=false - Add validation to throw error when accepting/rejecting without beforeFlow - Update setSnapshot to accept undefined for clearing 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Refactor FlowGraphV2 to own diffManager instance - Import and create diffManager instance per FlowGraphV2 - Remove onAcceptModule and onRejectModule props - Add validation $effect to error if both diffBeforeFlow and moduleActions provided - Add $effect to sync props (diffBeforeFlow or moduleActions) to diffManager - Add $effect to watch current flow changes and update afterFlow - Replace computedDiff with diffManager.moduleActions - Use raw modules instead of merged flow (diffManager handles merging) - Expose getDiffManager() and setBeforeFlow() methods - Pass diffManager to graph context instead of callbacks - Remove $inspect for removed props 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Update FlowModuleSchemaMap to use FlowGraphV2's diffManager - Remove import of flowDiffManager singleton - Update setBeforeFlow to call graph.setBeforeFlow() - Update setModuleActions and getModuleActions to use graph.getDiffManager() - Add getDiffManager() proxy method - Simplify handleAcceptModule and handleRejectModule to use new API - Handle editor state separately from diff operations - Remove diffBeforeFlow, moduleActions, onAcceptModule, onRejectModule props passed to FlowGraphV2 - Remove onAcceptModule and onRejectModule from Props interface and destructured props 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Update FlowAIChat to use flowModuleSchemaMap's diffManager - Remove import of flowDiffManager singleton - Update revertToSnapshot to use flowModuleSchemaMap.getDiffManager() - Add null check for diffManager before using 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Verify FlowGraphDiffViewer compatibility with refactored architecture FlowGraphDiffViewer already uses the correct prop patterns: - Before graph: moduleActions prop (display-only mode) - After graph: diffBeforeFlow prop (full diff mode with auto-computation) Each FlowGraphV2 instance creates its own diffManager, making the side-by-side view work correctly with independent diff state per graph. No code changes required. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Update graph components to use diffManager instead of callbacks - Update graphBuilder.svelte.ts to pass diffManager instead of onAcceptModule/onRejectModule - Update InputNode and ModuleN type definitions with diffManager - Update ModuleNode.svelte to pass diffManager to MapItem - Update MapItem.svelte to pass diffManager to FlowModuleSchemaItem - Update FlowModuleSchemaItem.svelte to use diffManager directly for accept/reject - Replace callback-based accept/reject with direct diffManager calls - Only show accept/reject buttons when beforeFlow exists and action is pending 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Fix removed modules not showing in diff viewer Problem: After refactoring, removed modules were no longer appearing in the diff viewer because we changed effectiveModules from using the merged flow (which includes removed modules) to using raw modules. Solution: - Add mergedFlow state to flowDiffManager to store timeline's merged flow - Add markRemovedAsShadowed parameter support for side-by-side view - Store timeline.mergedFlow in auto-computation $effect - Add getter for mergedFlow and setMarkRemovedAsShadowed method - Clear mergedFlow in clearSnapshot() - Update FlowGraphV2 to set markRemovedAsShadowed in diffManager - Update effectiveModules/FailureModule/PreprocessorModule to use mergedFlow The merged flow contains all modules including removed ones, enabling: - Unified view: Removed modules appear in red with "removed" badge - Side-by-side view: Removed modules show as shadowed in After graph 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Simplify accept/reject logic by removing actions instead of toggling pending state Previously, accepting or rejecting a module action would set pending to false but keep the action in the moduleActions map. This caused a bug where the $effect would overwrite moduleActions with fresh actions having pending: true, making accept/reject buttons reappear on previously handled modules. Now, when a user accepts or rejects a module action, we remove it entirely from the moduleActions map. This is simpler and fixes the button reappearing issue. Changes: - acceptModule: Remove action from moduleActions instead of setting pending: false - rejectModule: Remove action from moduleActions instead of setting pending: false - checkAndClearSnapshot: Check if moduleActions is empty instead of checking pending states - Fix typo: getModuleFromFrom → getModuleFromFlow 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * cleaning * fix logic * make diff drawer part of manager * accept submodules * fixes * Phase 4: Add checkAndApplyChanges() helper to flowDiffManager - Added new checkAndApplyChanges() function to apply mergedFlow to flowStore when all changes are decided - This replaces the old checkAndClearSnapshot() behavior and ensures flowStore is updated atomically - Handles both flow structure and input schema updates * Phase 2: Simplify acceptModule() - only modify mergedFlow - Remove flowStore mutations from acceptModule() - For removed modules: just delete the shadowed (__prefix) version from mergedFlow - For added/modified: no action needed (already correct in mergedFlow) - Call checkAndApplyChanges() to apply changes when all decided * Phase 3: Simplify rejectModule() - only modify mergedFlow - Remove all flowStore mutations from rejectModule() - For added modules: delete from mergedFlow - For removed modules: replace shadowed (__) module with original from beforeFlow - For modified modules: restore old version in mergedFlow - For Input schema: revert afterInputSchema - Call checkAndApplyChanges() to apply changes when all decided * Phase 5: Verify acceptAll/rejectAll work with new architecture - acceptAll() and rejectAll() already pass options correctly to acceptModule/rejectModule - They will automatically benefit from checkAndApplyChanges() - No changes needed for this phase * Phase 6: Remove FlowGraphV2 reactive effect that updates afterFlow - Removed the (lines 252-266) that continuously updated afterFlow - This effect created reactive loops when flowStore changed - afterFlow should only be set once when AI generates changes via setFlowYaml() - The initial sync effect (lines 226-250) is kept for prop-driven diff mode * Phase 7: Update FlowAIChat setFlowYaml to use diffManager - Changed setFlowYaml() to use diffManager.setAfterFlow() instead of modifying flowStore - flowStore remains unchanged during AI review phase - Changes are staged in mergedFlow for user review - Only applied to flowStore when all changes are accepted/rejected - Added error handling for missing diffManager * Fix linter warnings - Remove unused FlowTimeline type import - Fix ChangeTracker initialization with proper type parameter - Keep deleteModuleFromFlow and checkAndClearSnapshot for potential future use * Update plan document with implementation status - Mark all phases as complete - Add commit references - Update file checklist - Add implementation summary at top of document * Add comprehensive implementation summary document - Detailed overview of architecture changes - Before/after comparisons for each file - Complete testing scenarios checklist - Troubleshooting guide - Migration notes and backwards compatibility info * Show pending modules in editor panel - Pass diffManager from FlowModuleSchemaMap to FlowEditorPanel - Add effectiveModules derived value that uses mergedFlow when in diff mode - Update module iteration to use effectiveModules instead of flowStore - Allows users to view added/modified modules during AI review - Fixes issue where clicking on pending modules showed nothing * Add implementation summary for show pending modules feature * fix * shorter system prompt * Fix Input schema diff mode issues - Add Accept/Reject buttons to Input node (previously only showed Diff button) - Pass diffManager to FlowInput component - Add effectiveSchema derived value that uses afterInputSchema when in diff mode - Add effectiveDisabled to prevent editing Input when reviewing AI changes - Update FlowInputViewer to show pending schema changes - Fixes issue where Input schema changes couldn't be accepted/rejected - Fixes issue where pending Input schema wasn't visible in the panel * Disable delete and move buttons when in pending mode - Add effectiveDeletable derived value that checks diffManager.hasPendingChanges - Replace all instances of deletable with effectiveDeletable in template - Prevents delete/move operations when AI changes are being reviewed - Delete and move buttons are hidden when there are pending changes - Buttons reappear once all changes are accepted or rejected - Prevents conflicting operations during review phase * no move or delte when reviewing * use context * inline script reduction * use json * rollback to direct modif * fix merge * cleaning * fix reject removed * add set step code tool * better prompt * add back relevant tools * add back accept reject * use edit mode for pending * fix input * remove unneeded effect * cleaner + bug fix * fix failure and preprocessor * fix show diff for failure module * fix accept reject on failre module * no auto add module to context * cleaning * add back effect * cleaning * fix multiple setflowjson * track effectivemoduleactions for graph rendering * nit prompt * styling * rm md files * rm flake copy * cleaning * fix z index * fix revert * only change before after * use add remove modify tools * input + failure + preproc tools * parsing issues * nit * use raw schema for tools * resolve ref for gemini * fix schema * show test on graph * much cleaner logic * ignore empty assets * Remove debug console.log statements from production code 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Remove debug $inspect calls from FlowGraphV2 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Add error logging to setFlowJson before re-throwing 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Standardize null/undefined handling to prefer null - Use .nullable().optional() instead of .nullish() in Zod schemas - Simplify addModuleToFlow signature to use string | null - Coerce undefined to null when extracting parsed args - Simplify null checks to only check !== null 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Remove debug console.log from AI tool functions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Extract special module IDs to constants Add SPECIAL_MODULE_IDS constant with INPUT, PREPROCESSOR, and FAILURE to avoid magic strings throughout the flow AI chat code. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Add cleanup for diffDrawer reference on unmount Prevents potential memory leaks by clearing the diffDrawer reference when the FlowGraphV2 component is destroyed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Use structuredClone instead of JSON.parse(JSON.stringify()) structuredClone is more efficient and type-safe for deep cloning objects. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Cache module lookups in reconstructMergedFlow Move getAllModulesMap and getAllModuleIds calls outside the loop to avoid redundant recomputation. Track merged IDs incrementally as modules are added. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Revert "Use structuredClone instead of JSON.parse(JSON.stringify())" This reverts commit a62ba5b980. * cleaning * allow delete * better openflow for ai agents + truncate system prompt * handle ai agent tools * fix set code for tool * fix wrong cancel request called * mark tool calls as canceled * get lang instructions * use streamiing args * give db url to claude * fix revert * save and clear when leaving editor * keep whitespace in user message * uniformize colors * fix diff button * remove db from backend claude * remove move module tool * no failure and preprocessor * fix error given to llm * fix z index * fix ts errors * cleaning * fix add module logic * fix(copilot): add 'tools' to branchPath description for aiagent containers The branchPath parameter description was missing 'tools' option for aiagent containers and didn't mention branchall support. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * fix(copilot): correct AI agent tool IDs and summaries documentation Tool summaries CAN contain spaces (they're human-readable descriptions). Only tool IDs must avoid spaces. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * fix(copilot): remove reference to non-existent set_flow_json tool The set_module_code tool description referenced set_flow_json which doesn't exist as an exposed tool (it's an internal helper). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * fix(copilot): clarify inspect_inline_script is read-only The tool description incorrectly suggested it could modify code. This tool only inspects - use set_module_code to modify. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * fix(copilot): clarify afterId behavior for AI agent tools Updated wording to clarify that afterId can be used but is optional for AI agent tools since tool order doesn't affect execution. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor(copilot): remove unused id param from get_instructions_for_code_generation The id parameter was only used to check for preprocessor, which is no longer needed. Simplified the tool to only require the language param. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * docs(copilot): add result format to search_scripts tool description Helps AI understand what data format to expect from the tool. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * docs(copilot): add result format to resource_type tool description Helps AI understand what data format to expect from the tool and provides example resource type names. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * nit * Add support for adding branches to branchall/branchone via add_module Previously, add_module could only add modules inside existing branches. Now, using insideId with branchPath=null will add a NEW branch to a branchall or branchone container. API: - add_module({ insideId: "my_branchall", branchPath: null, value: { summary: "New Branch", skip_failure: false, modules: [] } }) - add_module({ insideId: "my_branchone", branchPath: null, value: { summary: "Condition", expr: "...", modules: [] } }) Changes: - Extended addModuleToFlow to handle branchPath=null case - Updated validation to allow branchPath=null when adding branches - Updated tool descriptions and system prompt documentation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * nit * add remove branch tool * check all ids for duplicates * no dup * nit * cleaning * fix dup ids * split core.ts * only mount diff drawer if useful * remove wrong logic * update exprs * fix * chore(flow): Add unit tests to flow diff manager (#7291) * setup * add basic tests for flowdiff * add complex tests * fix branch issue * more complex tests * add flow diff manager tests * add utils * better handling of moved case * more tests for move case * add buggy test case * rm * rework config * cleaning * fix config * rm * fix for reverting type change module * all good * rm * add missing testmode --------- Co-authored-by: Claude <noreply@anthropic.com>	2025-12-08 19:08:14 +01:00
centdix	04d2ef419d	feat(flow): Add graph diff visualizer (#6948) ... * graph mode * show colors * show module diff viewer button * better diff logic * small width merge graph diff * invert logic * simplify * better logic * put removed modules in initial position * nit * nit * fix conflicting ids * fix * add shadowed for after * better position logic * fix * cleaning * use splitpanes * add toggle * fix * sync move * icons * handle zoom * left header snippet * cleaning * cleaning * remove stats * big cleaning * fix * fix * fix * remove not working logic * invert logic * nit * use in deploymentui * fix typo * no custom style * handle nested * simpler logic * fix * fix	2025-11-01 15:17:56 +01:00