* feat: run a workspace handler when a secret variable expires
Secret variables gain an optional `value_expires_at`, and a workspace can point
at a script or flow to run once that date passes, so a rotation is driven by the
platform instead of tracked out of band.
The secret never leaves the database. The sweep selects the path, description and
expiry and nothing else, so the handler is given a reference to rotate rather than
a value to handle. Job results are stored in cleartext and shown in Runs, which is
what makes that a boundary rather than a preference; a test asserts the job's args
never contain the value.
Each row is claimed by writing `expiration_dispatched_for` in the same transaction
as the push, so a failed push un-claims it and a lost race claims nothing. Moving
the date re-arms the row; re-saving the same date does not. A pass takes at most
100 rows under a transaction-scoped advisory lock, and orders so that one broken
workspace cannot starve the rest.
Dispatch runs as `g/variable_expiration_handler`, exempt from the CE group limit
and from non-premium exec metering the way the error and schedule handlers already
are. A handler that keeps failing backs off and raises a critical alert instead of
retrying every pass, and the back-off ends when the handler is repointed.
The expiry travels with the variable through workspace clone, tarball export and
workspace comparison. The dispatch marker deliberately does not, so a fork re-arms
on its own copy.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* feat(frontend): expose variable value expiration in the UI
The variable drawer takes an optional expiry on a secret value, and the variables
list badges it, turning red once the date has passed. A workspace settings tab
picks the handler, its extra args, and whether variables under `u/` are skipped.
That mute flag is stored inside the handler setting, so the toggle stays disabled
until a handler is picked: saving it on its own would clear the setting it lives
in and still report success.
The expiry is carried as a tri-state through the draft deploy and copilot paths —
absent leaves the remote value alone, an explicit null clears it — so deploying a
draft cannot silently drop a date someone set elsewhere.
The settings tab names the one case where the configured identity does not apply:
a handler script carrying `on_behalf_of` runs as that user rather than as
`g/variable_expiration_handler`, which matters because the same tab asks the admin
to grant that group write access to the variables it rotates.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* feat(cli): sync variable expiry and the workspace expiration handler
`wmill sync` carries `value_expires_at` on variables in both directions, and
pushes the workspace handler alongside the error and success handlers in the
grouped settings format. Dropping the key from a variable's yaml clears the
remote expiry, so the file stays canonical rather than accumulating fields that
can only ever be added.
The handler follows the same rule, with the caveat recorded where the type is
declared: an omitted handler only reaches the clear when some other setting
differs, because the push short-circuits on a comparison that walks the local
object's keys and so never sees a missing one. That gate is shared with the two
existing handlers and is left as it is here.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* fix(frontend): open the variable expiration handler template in a new tab
The "Create a handler" button hands its script template to /scripts/add through
the URL hash, which `load` reads from `window.location`. A client-side navigation
leaves the previous page's hash in place, so the payload was dropped and the
editor opened on the default template at a `u/` path. `target="_blank"` forces a
full page load, matching the success handler's "Create from template" button.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* fix(frontend): make the variable expiry field state its own status
The expiry field rendered a DateTimeInput whose time defaults to 12:00 when it
holds no value, so a variable with no expiry looked like one already configured,
and "cleared" looked identical to "never set". Setting an expiry is optional, so
the field has to say which it is.
Rebuild it on the shape ScriptAdvancedSettings already uses for Timeout, Cache and
Concurrency limits: a toggle whose checked state is the stored value being present,
seeding a date on enable rather than revealing an empty picker, with the input
under its own label. Drop `clearable` with it, so the toggle is the single way to
mean "no expiry" instead of competing with an X.
Stop the surrounding copy promising a run that may not happen. A handler is only
dispatched if the workspace has one configured and does not skip u/ paths, so the
list tooltip now states the date alone, and the form hedges both conditions,
naming the u/ mute only on personal paths where it can apply.
Also anchor the mute toggle's tooltip: Popover's trigger is a span around a
block-level label, which stretched to the full width of its SettingCard and left
the popup floating beside the card rather than under the control.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* fix(rust-client): initialize value_expires_at in the variable models
The generated `CreateVariable` / `EditVariable` structs gain the field from
openapi.yaml, and client.rs builds both with exhaustive literals.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* fix(frontend): drop extra_args when the variable expiration handler is cleared
Clearing the handler nulls the whole setting server-side, extra_args included,
but the tab kept its loaded copy. A handler picked afterwards without reloading
was persisted with the cleared one's arguments, which the tab does not display.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* feat: back the variable expiration handler's built-in Slack and Teams destinations
Backfills the Slack bot token grant for g/variable_expiration_handler, mirroring
20231016142659 for g/error_handler: the slack_bot folder's extra_perms is written
once at Slack connect and never refreshed, and disconnecting leaves the folder
behind, so workspaces that already connected Slack cannot pick the grant up from
the creation-time list alone.
Adds run_variable_expiration_test_job so an admin can exercise the handler on
demand rather than waiting for a real expiry, which may be months away. It goes
through push_variable_expiration_handler so the test run proves what matters:
the handler resolves, and the group can read what it needs, under the same
identity and argument shape the sweep uses.
Also covers extra_args on the edit endpoint, which the settings tab now writes
for the built-ins' channel. The endpoint rebuilds the setting from the request,
so an omitted extra_args erases it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Do7wJTnL6MG6ngFpCGW4DG
* feat(frontend): offer Slack and Teams as variable expiration handlers
Gives the variable expiration tab the same no-code destinations the workspace
error handler has, so "tell #ops before this credential expires" no longer
requires writing a script.
A sibling component rather than a fourth mode of ErrorOrRecoveryHandler: that
one is shared with the workspace error handler and the three schedule handlers,
and its stripped-args list, hub path suffixes and Email tab are all
error-shaped. This reuses the pieces that are already generic
(SlackConnectionStatus, TeamsConnectionStatus, ChannelSelector, ScriptPicker,
SchemaForm) and leaves those five call sites untouched.
extra_args stops being an API/CLI-only escape hatch now that the built-ins write
their channel into it, so it joins the unsaved-changes comparison and the
discard path, normalised through the existing helper that drops the two
auto-managed keys.
The two hub ids are placeholders until the scripts are pushed to the hub.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Do7wJTnL6MG6ngFpCGW4DG
* fix(frontend): scope the handler identity notice to the chosen destination
The notice told every admin to grant g/variable_expiration_handler write access
to the variables it rotates. That is right for a custom handler and wrong for
the built-ins, which only post a message and are granted the Slack bot token by
migration. Following it for a Slack handler would hand a group write access to
the workspace's secrets for no reason.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Do7wJTnL6MG6ngFpCGW4DG
* feat(frontend): flag the Slack and Teams handlers as EE
Connecting a workspace to Slack or Teams is EE-only (oauth2_oss.rs returns
"Slack only available on enterprise"), so on CE those two tabs can never be
completed. Says so up front, the way the error/success handler tab does,
instead of leaving the user at a "not connected" badge with no working path.
Only on those two tabs: a custom script or flow handler is CE.
Drops the "Connect Slack first" alert, now that the banner and the connection
badge above it already say it twice.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Do7wJTnL6MG6ngFpCGW4DG
* chore(backend): regenerate the sqlx cache after the merge
The merged workspace_settings column list in change_workspace_id is a new
query text, so it needs a new cached entry. Drops the two pre-merge entries
it supersedes; both had been left with conflict markers by the merge, since
rename/rename markers are eight characters and escape the usual scan.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Do7wJTnL6MG6ngFpCGW4DG
* fix(cli): narrow the expiry-clear check to a variable that exists remotely
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Do7wJTnL6MG6ngFpCGW4DG
* feat(frontend): point the built-in handlers at their published hub scripts
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* chore(backend): regenerate the sqlx cache after the merge
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* fix(frontend): disable the Slack and Teams handler controls without a license
Matches the workspace error handler, which greys out its built-in destinations
and hides the test button on an unlicensed instance. The custom destination stays
editable: unlike the error handler, the variable expiration handler itself is not
an EE feature.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* feat: record which destination a variable expiration handler uses
handler_configured now counts slack, teams, custom or cleared instead of
set or cleared, so usage shows whether the built-in destinations are picked.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* fix(frontend): let the variable expiration handler template run on any worker
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* fix: guard the variable expiration test endpoint and correct its help text
* fix: reuse the error handler's slack arg and built-in path helpers
* docs: trim variable expiration sweep and backfill comments
* feat: put the variable value expiration under an advanced section
* fix: restrict the expiration test job to built-ins and keep expiry on conflict reload
* fix: link the expiry hint to the variable's workspace and document built-in test paths
* fix: give the expiration sweep its own lock id and reuse double_option
* fix: pin the variable expiration presets so the hub-paths test accepts them
* feat: let the variable expiration handler set how far ahead it runs
* fix: give the notify before expiry setting its own card
* feat: remind the variable expiration handler at a set interval
* fix: tighten the gap between the Slack channel field and its test button
* feat: refuse a value expiry on variables linked to an OAuth account
* refactor: reuse the shared handler form for variable expiration
* refactor: sweep expiring variables round-robin and check the handler exists
* chore: trim comments to the constraints they record
* fix: compare expiry dates by moment when deploying a variable draft
* refactor: rename value_expires_at to value_valid_until
* fix: neutralize variable fields in expiration handler args
* fix: reserve the variable_expiration_handler group name for admins
* fix: send first expiry notices before reminders
* test: pin that a handler failing to start leaves its rows unclaimed
* chore: say any hub handler path skips the existence check
* fix: empty a pre-existing handler group before granting it the Slack token
* docs: correct the registered feature usage counts
* fix: let a workspace whose handler failed to start sit out for an hour
* fix: send first notices before reminders across workspaces
* fix: end a failed handler's wait as soon as it is redeployed
* fix: show an expiry-only variable change in the AI fork diff
* chore: regenerate workspace tool schemas
* test: keep one variable expiration guard per behavior
* fix: use the renamed hub expiration handlers and template
* feat: carry the variable expiry in windmill-utils-internal 1.8.4
* fix: keep the variable expiry through MCP drafts
* chore: bump windmill-utils-internal to 1.8.4
* fix: keep the variable expiry through mcp deploys
* fix: disable saving a slack or teams expiry handler without ee
* fix: skip the failure mark when the expiry handler was saved mid-sweep
* fix: count expiry telemetry only where the expiry changed
* test: assert the exact variable expiry in export and cli push tests
* fix: stamp an expiry handler failure with the pass's read time
* fix: wait for a pending handler lock instead of marking it failed
* test: isolate expiry handler tests from the deployed-script cache
* fix: retry a failing expiry handler every pass instead of waiting an hour
* chore: update ee-repo-ref to b6e23d229966cf0019c0a1926a254fda658d8def
This commit updates the EE repository reference after PR #744 was merged in windmill-ee-private.
Previous ee-repo-ref: c52c06d145b13a6fb04459e85ca5818bf3c1bff4
New ee-repo-ref: b6e23d229966cf0019c0a1926a254fda658d8def
Automated by sync-ee-ref workflow.
---------
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: windmill-internal-app[bot] <windmill-internal-app[bot]@users.noreply.github.com>
Co-authored-by: hugocasa <hugo@casademont.ch>
* feat: add a workspace mcp server with the ai session toolset
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: keep workspace mcp tool calls on their own routes
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: keep a token's job tag fence on workspace mcp tool calls
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: state the workspace mcp token rule in its refusal message
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: let the workspace mcp server span workspaces chosen per token
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: let the mcp url form choose between the tools and workspace servers
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: serve the workspace mcp server as windmill mcp v2 at /api/mcp/v2
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: add read-and-run access to windmill mcp v2
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: serve the full windmill mcp experience at /api/mcp, sign-in first
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: align the mcp url form with the brand guidelines
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: serve every mcp token from /api/mcp, with one access picker
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: rename mcp access levels and keep selections to scripts and flows on /api/mcp
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: name the mcp access levels in the url caption
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* chore: name the mcp server windmill
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: lead the mcp access picker with build and run, and spell out what a selection excludes
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: show the tools each mcp access level gives
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: list the mcp tools in a collapsible section under the access row
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: offer all scripts and flows as typed mcp tools again, as wildcard scopes
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: label the mcp selection access as scripts and flows as tools
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: link mcp run, app draft and deploy results to their windmill pages
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: mirror the session tool changes from main in the mcp server
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: keep an ai agent's identity when the ai chat deploys its resource
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* refactor: call the api in-process from the mcp session tools
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: keep a draft that rebase_draft could not return whole
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: let read-and-run mcp tokens run scripts and flows that take secrets
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: ask mcp clients to open windmill links in a browser the user sees
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: send mcp clients condensed instructions and serve the full rules on demand
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* refactor: put the core rules first in the mcp instructions instead of condensing them
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: go straight to the mcp sign-in page after login, without the workspace picker
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: no workspace error toast on the mcp sign-in page while logged out
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: open raw app previews on the preview alone, from mcp links and in sessions
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: link mcp script, flow and agent drafts to their editors, and agents to their page
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: keep the session preview's saved sidebar choice, fold the build log in preview-only views
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: hold mcp tokens below full access to their level on the per-workspace urls
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: revoke tokens with the new mcp scopes when the migration is reverted
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: keep an mcp token's scopes when its editor is saved without changing access
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: mint one jwt per mcp tool call, accept the old approve body, list the new scopes
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: reset the mcp token editor's picker state for each token
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* refactor: mark only mcp selections, read levels imply no endpoint tools
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* chore: update ee-repo-ref to b3fd7d49f2ba58f5080fabc3a5686c34a0b2684c
This commit updates the EE repository reference after PR #877 was merged in windmill-ee-private.
Previous ee-repo-ref: 9e960246d51401a2b0487dcffcadd0b43cd67d39
New ee-repo-ref: b3fd7d49f2ba58f5080fabc3a5686c34a0b2684c
Automated by sync-ee-ref workflow.
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: windmill-internal-app[bot] <windmill-internal-app[bot]@users.noreply.github.com>
Co-authored-by: Ruben Fiszel <ruben@windmill.dev>
* chore: bump frontend python parser wasm packages to 1.830.0
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* chore: bump cli python parser wasm packages to 1.830.0
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat: isolate the raw-app editor preview when the app opts into sandboxing
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: gate job reads from a sandboxed editor preview like the deployed app
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: send a plain user in a sandboxed raw app's startup message
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* chore: pin ui_builder to d3fdb70
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix: evaluate field conditions and step test inputs in QuickJS
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: answer single-quoted field conditions without loading the engine
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: bound expression recursion and ignore leading blank space
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
These packages are imported by code under src/ and ship in the browser bundle, but were
listed as devDependencies, which made Dependabot label their alerts "development" scope.
No version changes; the lockfile diff only flips dev flags. Shipped code is unchanged: the
only bundle difference is the package.json text that vite's `define: { __pkg__ }` inlines
into three chunks, and the content-hash file names that follow from it.
@sveltejs/kit stays a devDependency on purpose: its client runtime ships, but its advisories
are server-side and moving it would drag vite and its plugins out of dev scope too.
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
* chore(frontend): upgrade quill to 2.0.3
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* fix(apps): load rich text editor HTML through Quill's converter so stored lists survive Quill 2
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* fix(apps): emit standard ul/ol from the rich text editor output under Quill 2
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* fix(apps): keep checklist state when normalising the rich text editor output
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
