* chore: split backend-test cargo test into build and run steps
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* chore: keep backend-test feature list out of cargo's env namespace
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* chore: bump image go, uv and apt layer past fixable CVEs
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* chore: bump go to 1.27.4 in the extra image too
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* chore: lock github actions with gh actions-lock lockfile
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* chore: let dependabot update composite action refs
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* perf: build the ee debug file in the same depot build as the image
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: sign the ee image before uploading its debug files
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* TEMP: verify debuglink crc on dispatch
* chore: drop the temporary debuglink check
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: keep a failed debug upload from blocking the ee release
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* perf: cut release CI wall time and build windmill-extra on its own release
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: wait for the ee-slim built from the release commit
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat(cli): suggest known instance URLs in workspace add
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* ci: retry bun setup in cli tests after a release download outage
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix: teach pipeline nodes to attach the lake and read real columns
* test: run the data pipelines ai evals build against a real ducklake
* test: run only fed-by-nothing pipeline nodes and record run failures
* fix: inspect pipeline columns read-only and cap the eval run's roots
* ci: point eval workers at the installed bun and serve native scripts
* feat: add a workspace mcp server with the ai session toolset
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: keep workspace mcp tool calls on their own routes
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: keep a token's job tag fence on workspace mcp tool calls
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: state the workspace mcp token rule in its refusal message
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: let the workspace mcp server span workspaces chosen per token
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: let the mcp url form choose between the tools and workspace servers
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: serve the workspace mcp server as windmill mcp v2 at /api/mcp/v2
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: add read-and-run access to windmill mcp v2
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: serve the full windmill mcp experience at /api/mcp, sign-in first
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: align the mcp url form with the brand guidelines
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: serve every mcp token from /api/mcp, with one access picker
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: rename mcp access levels and keep selections to scripts and flows on /api/mcp
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: name the mcp access levels in the url caption
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* chore: name the mcp server windmill
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: lead the mcp access picker with build and run, and spell out what a selection excludes
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: show the tools each mcp access level gives
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: list the mcp tools in a collapsible section under the access row
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: offer all scripts and flows as typed mcp tools again, as wildcard scopes
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: label the mcp selection access as scripts and flows as tools
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: link mcp run, app draft and deploy results to their windmill pages
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: mirror the session tool changes from main in the mcp server
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: keep an ai agent's identity when the ai chat deploys its resource
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* refactor: call the api in-process from the mcp session tools
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: keep a draft that rebase_draft could not return whole
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: let read-and-run mcp tokens run scripts and flows that take secrets
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: ask mcp clients to open windmill links in a browser the user sees
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: send mcp clients condensed instructions and serve the full rules on demand
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* refactor: put the core rules first in the mcp instructions instead of condensing them
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: go straight to the mcp sign-in page after login, without the workspace picker
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: no workspace error toast on the mcp sign-in page while logged out
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* refactor: run the ai session's reads and draft tools on the backend
* feat: open raw app previews on the preview alone, from mcp links and in sessions
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: link mcp script, flow and agent drafts to their editors, and agents to their page
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: keep the session preview's saved sidebar choice, fold the build log in preview-only views
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* refactor: resolve and start the ai session's runs on the backend
* fix: hold mcp tokens below full access to their level on the per-workspace urls
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: revoke tokens with the new mcp scopes when the migration is reverted
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: keep an mcp token's scopes when its editor is saved without changing access
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: mint one jwt per mcp tool call, accept the old approve body, list the new scopes
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* refactor: run delete on the backend and drop the chat's moved tool logic
* fix: reset the mcp token editor's picker state for each token
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: close the session tools' parity gaps and drop the tests of moved logic
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* refactor: mark only mcp selections, read levels imply no endpoint tools
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: run the global ai evals against a real workspace per attempt
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: allow the skill description that only the mcp instructions read
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* ci: build the scheduled ai evals' backend with the hub embeddings index
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: give migrations their own wait, bound the npm types fetch, keep draft links mcp-only
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: seed hub-synced resource types for global eval fixtures that set none
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: make the global eval workspaces match a production instance
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: settle a linked agent's unsaved draft before testing its step
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: seed non-admin eval users in the database, give standalone eval chats no session
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: let a step test run past a deleted or unreadable linked agent, as the server does
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: judge npm search matches against the best one, not a fixed score
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* chore: update ee-repo-ref to b3fd7d49f2ba58f5080fabc3a5686c34a0b2684c
This commit updates the EE repository reference after PR #877 was merged in windmill-ee-private.
Previous ee-repo-ref: 9e960246d51401a2b0487dcffcadd0b43cd67d39
New ee-repo-ref: b3fd7d49f2ba58f5080fabc3a5686c34a0b2684c
Automated by sync-ee-ref workflow.
* fix: show the draft save label when the server builds the draft, as before
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: keep a browser caller's session on the session tools' internal calls, so its runs and trigger edits are attributed to the UI as before
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* refactor: keep the chat's npm search in the browser, so its registry requests leave from the user's browser as before
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test: share the run tools' argument cases between the chat's and the server's handling, so a change on one side only fails
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: windmill-internal-app[bot] <windmill-internal-app[bot]@users.noreply.github.com>
* chore: route editor language servers through the signed gateway
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix: coalesce overlapping editor language-server reconnects
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
* chore(docker): official awscli, no git recommends, scan release images by digest with VEX
- Replace Debian's awscli (2.23.6) with the official v2.39.1 bundle, sha256-pinned per arch;
drops the python3-* libraries it pulled in (python3 itself stays, nodejs needs it).
- Install git without recommends, keeping openssh-client explicitly for SSH git remotes and
the SSH executor.
- Replace verify_ee_image_vulnerabilities with scan_release_images: CE, EE and both slim
images scanned by the digest this run built, a cosign-attested OpenVEX marking
linux-libc-dev (kernel headers) CVEs not_affected, Trivy results + VEX attached to the
release, per-image Scout SARIF, and a gate failing on fixable critical CVEs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: attest VEX per digest, upload scan results before attesting, cache trivy, keep less
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: gate releases on the VEX-filtered Trivy report
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix: bump uv to 0.13.6 so preinstalled pythons ship a patched certifi
uv 0.13.4 installs python builds whose bundled pip 26.2.1 vendors
certifi 2026.06.17, which trusts the compromised emSign ECC Root CA - G3
(GHSA-6q48-6c7w-9gw2). The builds uv 0.13.6 pins ship pip 26.2.2 with
certifi 2026.10.19. The Slim images pin exact patch versions, so those
move to 3.12.16 / 3.13.18 to get the new builds.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* align slim images' python versions with the full image
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* bump uv in backend test workflows too
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
A PR whose body contains `[skip-ai-review]` no longer triggers the
automatic Codex, Pi and Claude reviews on open/ready/synchronize, and is
left out of the weekly merged-PR summary. Explicit requests (workflow_call
from the review commands) still run.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* test: wait on the seed script's own git sync push in e2e tests
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* chore: TEMP loop git sync e2e with race diagnostics (to be dropped)
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat: prototype running duckdb jobs out of process inside nsjail
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: bound runner output, honor force install outside the jail, set oom score before exec
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: gate the duckdb runner bin behind a feature and decode pre-install errors
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: allowlist-only policy inside the duckdb jail, with its own extension cache
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: run duckdb jobs out of process under job isolation and drop the engine fork
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: runner everywhere, stock duckdb engine, no sql fence
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* chore: update ee-repo-ref to 24bdc6615b3f651141fb740e2cacf9c3c2d81252
This commit updates the EE repository reference after PR #884 was merged in windmill-ee-private.
Previous ee-repo-ref: 73452bbc280cc9ca33cf0fe325d26c2fbf3aace4
New ee-repo-ref: 24bdc6615b3f651141fb740e2cacf9c3c2d81252
Automated by sync-ee-ref workflow.
* fix: pass the windows system env and TZ to the duckdb runner
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: cap a jailed duckdb job's disk use from the worker, 6GiB by default on cloud
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: keep a disk-backed jail tmp under the duckdb disk cap
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* chore: drop the benchmark scaffolding and bump duckdb to 1.5.6
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: windmill-internal-app[bot] <windmill-internal-app[bot]@users.noreply.github.com>
* fix: keep applied migrations and db settings in data table copies
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: scope copied db settings per transaction and send timestamps as iso
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: copy migrations and settings only into a fresh import target
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* ci: install the latest pg_dump for backend integration tests
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* ci: enable pgdg so the latest pg_dump is installed
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* chore: publish the chat sdk as @windmill-labs/chat-sdk
* chore: publish the chat sdk with a dedicated npm token
* chore: publish the chat sdk with npm trusted publishing
* feat: sign OIDC tokens with an external signer and log every mint
* fix: init the signer in sqs_trigger builds and show signer reachability from results
* fix: key the OIDC key rows by source and kid
* chore: bump ee ref and list the oidc-signer subcommand only where it exists
* fix: advertise the actual signing algorithm in OIDC discovery
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: harden the external signer startup, agent workers and failed mints
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* chore: bump ee ref for the stored key listing fix
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: list the oidc signing settings page only with an external signer
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* chore: update ee-repo-ref to 1e538620a9b2f08b044997d032e71d8720ecbd5c
This commit updates the EE repository reference after PR #859 was merged in windmill-ee-private.
Previous ee-repo-ref: 84fa325737df98407c7b9f79c09d6e9378c46147
New ee-repo-ref: 1e538620a9b2f08b044997d032e71d8720ecbd5c
Automated by sync-ee-ref workflow.
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: windmill-internal-app[bot] <windmill-internal-app[bot]@users.noreply.github.com>
* chore: bump uv to 0.13.0
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: pin the python ansible is installed on in the full images
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat: stop offering deno for new scripts and ship it only on full images
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: keep deno in the integration test worker and narrow the missing-deno error
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: keep deno selectable on existing deno scripts when the saved order omits it
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* chore: drop the deno workloads from the benchmark suite
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test: run bun instead of deno in tests that are not about the deno runtime
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test: drop the deno cases from the integration suite
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test: update the app policy hash for the bun inline script
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat: run the cli ai evals on codex and deepseek
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* ci: pick cli eval models from the harness and install codex
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: stop counting wmill in a file name as a cli eval mutation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: harden the codex and deepseek cli eval runtimes
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: keep codex tool order and keep other keys from deepseek
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat: run the weekly ai evals on global and cli across sonnet, opus, gpt-6 and deepseek
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: keep claude- prefixed and capitalised aliases in the cli model filter
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* ci: move CI AI models to opus 5.5, gpt-6 and deepseek v4.1 flash
* test: point the deepseek eval alias at v4.1 flash
* ci: run the codex review on gpt-6.1-sol with codex cli 0.159.3
* feat: run ai evals weekly on current models and post results to a dashboard
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: add current flagship models, a reasoning flag and claude 5.5 defaults
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: never send a reasoning disable claude 5.5 or gpt-6-astra reject, and treat gpt-6 as a reasoning model
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: address review on gpt-6 support, chat completions tools and model metadata
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: leave tiered gpt-6 unpriced and drop the off sentinel on gpt-5 and o-series
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* docs: point the ai_evals readme at the model registry instead of copying it
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* refactor: encode the reasoning rules as per-family maps with a shared parity fixture
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: keep the chat completions tools rule open-ended past gpt-5.6 and scope the parity fixture
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat: let a workspace withdraw operator schedule and trigger writes
Operators can create, edit and delete schedules and triggers today through the
API, CLI and MCP, while the operator_settings flags beside them only hide those
pages. An admin who wants operators to see what is scheduled without letting
them change it cannot express that. Add manage_schedules and manage_triggers as
enforced settings, gated at the schedule handlers and at the generic TriggerCrud
routes so every trigger kind is covered by one check.
They name capabilities operators already hold, so they are granted unless
withdrawn, and absence has to mean "never configured" rather than a value. The
read coalesces to true; the update endpoint merges into the stored jsonb with
the two fields as Option<bool>, so an omitted key keeps what is stored.
operator_settings is git-synced as a whole object, so a settings file written
before these keys existed reaches the endpoint on every pull, and a serde or SQL
default of either polarity would turn that pull into a silent withdrawal or
restoration.
The rights are read through a per-process cache, so withdrawing one publishes a
notify_event that drops the entry on every replica.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Dsf6VC4MVLisiEoeQkgbr4
* feat: enforce operator write rights on the router and in the UI
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* fix: close the capture gap and gate the trigger editors' write actions
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* fix: gate acl writes and the native trigger drawer behind manage rights
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* fix: refuse operator writes with 403 and gate sharing at the drawer
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* perf: resolve identity in the operator write gate only for writes
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* fix: gate the suspended-jobs actions and stop the route check refusing reads
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* fix: explain the empty-state create button when operator writes are withdrawn
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* fix: audit operator settings changes and fold path writes into native rows
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* fix: open locked editors read-only and group the operator settings
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* fix: skip email and azure lookups on editor open while triggers are locked
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* docs: state each operator-rights rationale once in comments
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* fix: address CI review findings on operator write rights
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* fix: keep capture move gated and skip it in the builders while locked
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* fix: keep admin and operator exclusive when setting a workspace role
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* refactor: use the shared section component for operator settings groups
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: Ruben Fiszel <ruben@windmill.dev>
* fix(multiplayer): don't drop client messages during cold-start token verification
`wss.on('connection')` awaits `verifyToken()` before `setupWSConnection()`
attaches the 'message' listener. On a cold process that await includes the
first `/api/debug/jwks` fetch (~30ms on ECS). A y-websocket client sends sync
step 1 the instant the socket opens, and `ws` drops messages emitted with no
listener attached, so that step 1 was lost and never answered with step 2 —
the client's provider never became `synced`.
Buffer messages from the moment the connection is accepted and replay them, in
order, once `setupWSConnection()` has installed its handlers. Rejected
connections drop the buffer and close with the same 4401/4403 codes as before.
Also prefetch the public key at startup when WINDMILL_BASE_URL is set. That is
insurance, not the fix: a connection arriving before the prefetch resolves
still relies on the buffer.
Adds `npm test` in multiplayer/ (node:test, no docker or backend needed) with a
fake JWKS endpoint that answers with a delay, which holds the cold window open
and makes the race deterministic; wired into the existing test_extra CI job.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* fix(multiplayer): cap what an unauthenticated peer can buffer pre-auth
Review follow-up.
The pre-auth buffer was unbounded: `ws` sets no `maxPayload` here and the JWKS
fetch has no timeout, so a peer that never authenticates could stream frames
into memory for as long as `verifyToken` was stalled. Cap it at 32 frames /
1 MiB — a real client only has sync step 1 and its first awareness update in
flight there — and close 1009 past that, dropping what was buffered.
A socket closed during verification (by the peer, or by that cap) is no longer
handed to setupWSConnection: it would be added to `doc.conns` with a 'close'
listener that can never fire.
The startup prefetch's .catch was dead code — getPublicKey() logs its own
failures and resolves to null rather than rejecting.
Test helper: pin REQUIRE_SIGNED_MULTIPLAYER_REQUESTS and BASE_INTERNAL_URL so an
ambient value cannot turn the rejection tests into false passes; bind the JWKS
server on port 0 instead of a released probe port, and retry the spawned server
on EADDRINUSE; destroy still-delayed JWKS responses on teardown, since
server.close() waits for in-flight requests.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* test(multiplayer): gate the JWKS response instead of delaying it
Review follow-up.
The cold window was held open by a 1500 ms delay on the fake JWKS response, but
that timer started when the startup prefetch reached the fake server, not when
the client sent its first frame. A slow enough machine could load the key before
the client connected, and the race test would then pass without ever exercising
the buffer — a false pass.
The fake JWKS server now parks every response until the test calls release(), so
the server provably holds no key while the client is sending. The race test
releases only after both frames are written to the socket, and asserts the
server has not logged the key as loaded at that point; the flood test never
releases until after the cap has closed the connection.
What is left to wall-clock time is 250 ms for bytes already written to the socket
to cross loopback into an otherwise idle server, rather than a window that had to
cover process startup, connect and handshake.
Also drops the prefetch precondition from the forged-token and flood tests so
each test still maps to one behaviour. Suite runs in ~1.1s instead of ~5.3s.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* fix(multiplayer): survive a malformed frame instead of exiting the process
`setupWSConnection`'s message handler decoded whatever an authenticated peer
put on the wire with no guard: `decoding.readVarUint`,
`syncProtocol.readSyncMessage` and `awarenessProtocol.applyAwarenessUpdate` all
throw on input they cannot parse, `ws` re-emits a listener's exception on the
process, and server.mjs installs no `uncaughtException` handler. One bad frame
from one client therefore killed the whole multiplayer server, taking every
other document and every other client with it.
Catch decode/apply failures, log the document, the client address and the error
message (never the payload), and close only the offending connection with 1007
"invalid frame payload data". Frames that arrive once a connection is no longer
OPEN are ignored, so the replay of the pre-auth buffer stops at the first
refusal instead of applying the rest.
docker/entrypoint-extra.sh made that outage permanent: on a service exit it
logged a bare PID and then `wait`ed on the rest, so the container stayed up with
a dead service and the health checks in front of it — which probe the LSP — saw
nothing wrong. It now names the service that died, stops the others through the
same shutdown path SIGTERM uses, and exits non-zero so the orchestrator replaces
the container. The "no services enabled" branch still sleeps.
Tests: multiplayer/test/malformed_frame.test.mjs covers four malformed payloads
from an authenticated client and one replayed out of the pre-auth buffer,
asserting the 1007 close, a live server process, an undisturbed bystander and a
real edit still propagating. docker/test_entrypoint_extra.sh runs the real
entrypoint in a container with stub services.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* test(multiplayer): prove the replayed malformed frame really is buffered pre-auth
Assert the server has not yet logged the loaded key when the frame is written,
and give it the same in-flight margin as the cold-start tests before releasing
the JWKS response, so the frame provably goes through the replay path rather
than landing on an already-authenticated connection.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* ci(extra): run the entrypoint supervision tests in publish_extra
The multiplayer unit tests already run there; the entrypoint test needs only
docker and the checkout, so run it in the same job, before the image build.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* fix(multiplayer): handle WebSocket protocol errors and bound the shutdown
Two crash paths of the same class as the malformed-frame one, from review.
`ws` fails a frame it cannot parse at the protocol level — an unmasked frame
from a client, a reserved opcode, a bad RSV bit — inside its Receiver, before
the application 'message' handler ever sees it, and `receiverOnError` ends with
`websocket.emit('error', err)`. With no 'error' listener that is an unhandled
EventEmitter error, so it exited the process just as a malformed payload did.
(A raw socket error such as ECONNRESET does not: ws 8.21.3's `socketOnError`
swallows those.) Add the listener on the accepted socket, before authentication
so the pre-auth window is covered too, and one on the server.
Log messages now go through `describeError`, which collapses whitespace and
truncates, so nothing that reaches an error message can forge or flood a log
line.
`stop_services` ended in a bare `wait`. On the `docker stop` path dockerd
provides the deadline; the "a service died" path signals itself, so a service
that is wedged or slow to honour SIGTERM would hold the container open
indefinitely — the state that path exists to prevent. Bound it: SIGTERM, wait
SHUTDOWN_GRACE_SECS (10 by default), then SIGKILL the stragglers by name.
Tests: multiplayer/test/socket_error.test.mjs (authenticated and pre-auth
illegal frames, asserting a live process and continued service), a
SIGTERM-ignoring stub scenario in docker/test_entrypoint_extra.sh, and that
harness is now bounded throughout — `timeout -k` on foreground runs, a watchdog
around the backgrounded ones, and an optional outer timeout on `docker run`.
`--entrypoint bash` so the documented windmill-extra:test override runs the
harness instead of the image's real entrypoint. The stubs publish a readiness
marker and the dying one waits for them, removing a startup race in the harness.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* fix(multiplayer): never log peer bytes, and keep a fatal server error fatal
Two review findings on the previous commit, both mine to answer for.
`describeError` collapsed whitespace, which is not enough. An error message is
not always a fixed string: `applyAwarenessUpdate` runs `JSON.parse` on the
peer's bytes and V8 quotes ~30 bytes of the offending input back verbatim, ESC
included, so a peer could put terminal escapes and forged content into a log
line. Strip everything outside printable ASCII instead, and say so where the
comment previously claimed the messages were fixed strings.
`wss.on('error')` was worse than the crash it replaced for one case: `ws`
forwards the HTTP server's errors there, so a failed listen (EADDRINUSE) was
logged and the process then exited 0 — a clean shutdown as far as anything
upstream could tell. It now sets a non-zero exit code. Setting `process.exitCode`
rather than calling `process.exit()` keeps the log line from being truncated.
`openClient` in the test helpers now records the socket error it was already
swallowing, so a failed connection reports its cause instead of surfacing as a
bare `waitFor` timeout.
Tests: a malformed awareness frame whose state is `x\x1b[2J OWNED THE LOG` added
to the payload table, with every case now asserting exactly one refusal line and
no control characters in it (1 fail before, 0 after, 3 runs); and a server that
cannot listen must exit non-zero (1 fail before, 0 after, 3 runs). 14/14 on 5
consecutive runs.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* test(multiplayer): make the exit-status helper robust to spawn and stdio races
Review follow-ups on runMultiplayerServerUntilExit.
Wait for 'close', not 'exit': 'exit' fires when the child terminates, which can
be before its stdio pipes are drained, and the caller reads the output. On the
EADDRINUSE path the child writes one line and exits immediately after, which is
exactly the shape that loses it.
Listen for 'error' too. A child that fails to spawn emits neither 'exit' nor
'close', so the promise would never settle and the SIGKILL guard could not help.
Report whether the guard fired, rather than leaving the caller to infer it from
the exit signal: `signal` is null for every child exit on Windows, so a server
that hung after the listen error would have looked like one that exited on its
own. The test asserts on that flag instead.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* test(multiplayer): assert the refusal line itself, and name hasSyncType for what it takes
Two review nits on the test helpers.
The `doc="..."` assertion searched the whole server log, where CONNECT and
DISCONNECT also name the document, so it would have passed even if the refusal
stopped naming anything. Every assertion about the refusal is now made against
the refusal line, which the test already isolates, and it also checks the peer
is named.
`hasKind` took a sync sub-type but was named as if it took any message kind, and
the two families overlap numerically (`syncStep1 === messageSync === 0`), so a
caller passing the wrong one got a silently wrong answer. No runtime check can
tell aliased numbers apart, so the fix is the name: `hasSyncType`, with the
overlap spelled out where the constants are declared.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* test(multiplayer): make the pre-auth tests prove which path they took
The replay test could not establish that its frame went through the pre-auth
buffer: a frame delivered after setup, into the live handler, produces the same
close code and the same refusal line, so if the in-flight margin were ever
missed the test would quietly become a duplicate of the main-loop cases rather
than fail. server.mjs now logs REPLAY when, and only when, it replays a buffered
pre-auth message — worth having on its own, since that path only runs when a
client beat the JWKS fetch on a slow-starting instance — and the test asserts on
it. Removing that log line turns the test red, which is the point.
The socket-error pre-auth test gated on `jwks.requests >= 1`, which the startup
warm-up already satisfies, so it proved nothing about the offender. What makes
it the pre-auth case is that the JWKS response stays parked for the whole test;
it now asserts the server never logged CONNECT, which is exact.
`killedByTimeout` was set before the kill, so a child that exited on its own just
before the timeout — with 'close' still pending on the stdio drain, the very
window this helper waits for — would have been reported as killed. It now claims
the rescue only when there was a live process to signal.
14/14 on eight consecutive runs.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* test(multiplayer): document the frame-recording contract in openClient
ws hands every frame over as a Buffer under the default binaryType, text frames
included, so recording them as Uint8Array is lossless for both. Worth stating:
ws 7 delivered text frames as strings, where new Uint8Array(string) would have
been a silent zero-fill, and the difference is not visible at the call site.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* test(multiplayer): pin the close code for an illegal frame, and trim comments to the 4-line rule
Both socket-error tests waited for a close and never checked what it was, so an
abrupt 1006 teardown would have passed while the comment beside the payload
claimed 1002. `ws` sends 1002 for an unmasked frame in both the authenticated
and pre-auth cases, confirmed over repeated runs; that is now a named constant
asserted in each test, mirroring malformed_frame.test.mjs. Changing the expected
value turns both red.
The comments added by this branch also ran past the four lines AGENTS.md allows,
and several justified the change to a reader rather than stating the invariant.
Condensed to the invariant, at the site that would break it.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* fix(multiplayer): don't drop client messages during cold-start token verification
`wss.on('connection')` awaits `verifyToken()` before `setupWSConnection()`
attaches the 'message' listener. On a cold process that await includes the
first `/api/debug/jwks` fetch (~30ms on ECS). A y-websocket client sends sync
step 1 the instant the socket opens, and `ws` drops messages emitted with no
listener attached, so that step 1 was lost and never answered with step 2 —
the client's provider never became `synced`.
Buffer messages from the moment the connection is accepted and replay them, in
order, once `setupWSConnection()` has installed its handlers. Rejected
connections drop the buffer and close with the same 4401/4403 codes as before.
Also prefetch the public key at startup when WINDMILL_BASE_URL is set. That is
insurance, not the fix: a connection arriving before the prefetch resolves
still relies on the buffer.
Adds `npm test` in multiplayer/ (node:test, no docker or backend needed) with a
fake JWKS endpoint that answers with a delay, which holds the cold window open
and makes the race deterministic; wired into the existing test_extra CI job.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* fix(multiplayer): cap what an unauthenticated peer can buffer pre-auth
Review follow-up.
The pre-auth buffer was unbounded: `ws` sets no `maxPayload` here and the JWKS
fetch has no timeout, so a peer that never authenticates could stream frames
into memory for as long as `verifyToken` was stalled. Cap it at 32 frames /
1 MiB — a real client only has sync step 1 and its first awareness update in
flight there — and close 1009 past that, dropping what was buffered.
A socket closed during verification (by the peer, or by that cap) is no longer
handed to setupWSConnection: it would be added to `doc.conns` with a 'close'
listener that can never fire.
The startup prefetch's .catch was dead code — getPublicKey() logs its own
failures and resolves to null rather than rejecting.
Test helper: pin REQUIRE_SIGNED_MULTIPLAYER_REQUESTS and BASE_INTERNAL_URL so an
ambient value cannot turn the rejection tests into false passes; bind the JWKS
server on port 0 instead of a released probe port, and retry the spawned server
on EADDRINUSE; destroy still-delayed JWKS responses on teardown, since
server.close() waits for in-flight requests.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* test(multiplayer): gate the JWKS response instead of delaying it
Review follow-up.
The cold window was held open by a 1500 ms delay on the fake JWKS response, but
that timer started when the startup prefetch reached the fake server, not when
the client sent its first frame. A slow enough machine could load the key before
the client connected, and the race test would then pass without ever exercising
the buffer — a false pass.
The fake JWKS server now parks every response until the test calls release(), so
the server provably holds no key while the client is sending. The race test
releases only after both frames are written to the socket, and asserts the
server has not logged the key as loaded at that point; the flood test never
releases until after the cap has closed the connection.
What is left to wall-clock time is 250 ms for bytes already written to the socket
to cross loopback into an otherwise idle server, rather than a window that had to
cover process startup, connect and handshake.
Also drops the prefetch precondition from the forged-token and flood tests so
each test still maps to one behaviour. Suite runs in ~1.1s instead of ~5.3s.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* fix: trust the system CA store for SMTP TLS
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* ci: run the smtp-gated backend tests
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* chore: depend on webpki-roots 1 directly
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* chore: update ee-repo-ref to 48193da8cb30bc4ae82a50f944caef85d8a20b48
This commit updates the EE repository reference after PR #826 was merged in windmill-ee-private.
Previous ee-repo-ref: cd3447143b25d9f3301975feca4b202755f2508f
New ee-repo-ref: 48193da8cb30bc4ae82a50f944caef85d8a20b48
Automated by sync-ee-ref workflow.
---------
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: windmill-internal-app[bot] <windmill-internal-app[bot]@users.noreply.github.com>
* ci: skip the AI reviews and the Discord notice on Dependabot PRs
They already do not review them, they just fail while doing so. The Claude
action rejects a bot actor outright ("Workflow initiated by non-human actor"),
and the Codex and Pi jobs find no API key because GitHub gives Dependabot-
triggered runs a separate secret scope from Actions. Verified on #11302: zero
reviews posted, the only comment is a Cloudflare deployment notice, while
codex-review and pi-review both reported success.
So every Dependabot PR carried two permanently red checks that meant nothing,
which is the worst kind of signal — it buries a Dependabot PR that genuinely is
broken, and a green tick that means "skipped" reads exactly like one that means
"looked and approved".
Skipping states it honestly. The workflow_call branch is untouched, so a review
can still be requested on a specific bot PR when the diff deserves one, which is
worth doing for a grouped security update that swaps a cipher or drops a parser
rather than just moving a version.
The Discord notice is excluded for the same reason plus its own: nobody wants a
forum thread per lockfile bump.
Not fixed here, deliberately: making these actually review bot PRs would need
the org's review credentials copied into the Dependabot secret scope, which is a
wider grant than this is worth given the PRs in question are lockfile diffs.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* ci: gate the close-time Discord job too, and trim the comments
Both reviewers caught the same gap: merge_success_emoji runs on every `closed`
event with no exclusion, and the reusable workflow it calls exits 1 when it
cannot find a thread. Since open_thread no longer creates one for Dependabot,
the failure would have moved from open-time to merge-time rather than going
away. Gated to match.
The comments are cut from eight lines to two per file. AGENTS.md:205 asks for
constraints in <=4 lines, stated once, describing the code as it is — mine
narrated the drafting history and argued the change to a reviewer, both of which
belong in the PR description. Also drops "bot-authored", which overstated a
condition that only covers dependabot[bot].
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
* fix: build derived release images from this run's image digest, not :dev
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* fix: scope the digest comment to jobs that build from, extract or retag
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>