use serde_json::json; use sqlx::{Pool, Postgres}; use windmill_test_utils::*; fn script_url(port: u16, endpoint: &str, path: &str) -> String { format!("http://localhost:{port}/api/w/test-workspace/scripts/{endpoint}/{path}") } fn client() -> reqwest::Client { reqwest::Client::new() } fn authed(builder: reqwest::RequestBuilder) -> reqwest::RequestBuilder { builder.header("Authorization", "Bearer SECRET_TOKEN") } async fn authed_get(port: u16, endpoint: &str, path: &str) -> reqwest::Response { authed(client().get(script_url(port, endpoint, path))) .send() .await .unwrap() } fn new_script(path: &str, summary: &str, content: &str) -> serde_json::Value { json!({ "path": path, "summary": summary, "description": "", "content": content, "language": "deno", "schema": { "$schema": "https://json-schema.org/draft/2020-12/schema", "type": "object", "properties": {}, "required": [] } }) } #[sqlx::test(migrations = "../migrations", fixtures("base"))] async fn test_script_endpoints(db: Pool) -> anyhow::Result<()> { initialize_tracing().await; let server = ApiServer::start(db.clone()).await?; let port = server.addr.port(); let base = format!("http://localhost:{port}/api/w/test-workspace/scripts"); // --- create --- let resp = authed(client().post(format!("{base}/create"))) .json(&new_script( "u/test-user/test_script", "Test script", "export async function main() { return 42; }", )) .send() .await .unwrap(); assert_eq!(resp.status(), 201, "create: {}", resp.text().await?); // create second script let resp = authed(client().post(format!("{base}/create"))) .json(&new_script( "u/test-user/another_script", "Another script", "export async function main() { return 'hello'; }", )) .send() .await .unwrap(); assert_eq!(resp.status(), 201, "create another: {}", resp.text().await?); // --- exists --- let resp = authed_get(port, "exists/p", "u/test-user/test_script").await; assert_eq!(resp.status(), 200); assert_eq!(resp.json::().await?, true); let resp = authed_get(port, "exists/p", "u/test-user/nonexistent").await; assert_eq!(resp.status(), 200); assert_eq!(resp.json::().await?, false); // --- get by path --- let resp = authed_get(port, "get/p", "u/test-user/test_script").await; assert_eq!(resp.status(), 200); let body = resp.json::().await?; assert_eq!(body["path"], "u/test-user/test_script"); assert_eq!(body["summary"], "Test script"); assert_eq!(body["language"], "deno"); assert!(body["hash"].is_string(), "expected hash to be a hex string"); let hash = body["hash"].as_str().unwrap().to_string(); // get not found let resp = authed_get(port, "get/p", "u/test-user/nonexistent").await; assert_eq!(resp.status(), 404); // --- get by hash --- let resp = authed_get(port, "get/h", &hash).await; assert_eq!(resp.status(), 200); let body = resp.json::().await?; assert_eq!(body["path"], "u/test-user/test_script"); // --- raw by path (requires language extension) --- let resp = authed_get(port, "raw/p", "u/test-user/test_script.ts").await; assert_eq!(resp.status(), 200); let body = resp.text().await?; assert!( body.contains("return 42"), "expected script content, got: {body}" ); // --- raw by hash (requires .ts suffix) --- let resp = authed_get(port, "raw/h", &format!("{hash}.ts")).await; assert_eq!(resp.status(), 200); let body = resp.text().await?; assert!(body.contains("return 42")); // --- list --- let resp = authed(client().get(format!("{base}/list"))) .send() .await .unwrap(); assert_eq!(resp.status(), 200); let list = resp.json::>().await?; assert!( list.len() >= 2, "expected at least 2 scripts, got {}", list.len() ); assert!(list.iter().any(|s| s["path"] == "u/test-user/test_script")); // list with path_start filter let resp = authed(client().get(format!("{base}/list?path_start=u/test-user/another"))) .send() .await .unwrap(); assert_eq!(resp.status(), 200); let list = resp.json::>().await?; assert_eq!(list.len(), 1); assert_eq!(list[0]["path"], "u/test-user/another_script"); // --- list_search --- let resp = authed(client().get(format!("{base}/list_search"))) .send() .await .unwrap(); assert_eq!(resp.status(), 200); let list = resp.json::>().await?; assert!(!list.is_empty()); // --- list_paths --- let resp = authed(client().get(format!("{base}/list_paths"))) .send() .await .unwrap(); assert_eq!(resp.status(), 200); let paths = resp.json::>().await?; assert!(paths.contains(&"u/test-user/test_script".to_string())); // --- history --- let resp = authed_get(port, "history/p", "u/test-user/test_script").await; assert_eq!(resp.status(), 200); let history = resp.json::>().await?; assert!(!history.is_empty()); // --- get_latest_version --- let resp = authed_get(port, "get_latest_version", "u/test-user/test_script").await; assert_eq!(resp.status(), 200); // --- deployment_status --- let resp = authed_get(port, "deployment_status/h", &hash).await; assert_eq!(resp.status(), 200); // --- raw_unpinned by path --- let resp = authed_get(port, "raw_unpinned/p", "u/test-user/test_script.ts").await; assert_eq!(resp.status(), 200); let body = resp.text().await?; assert!(body.contains("return 42")); // --- list_tokens --- let resp = authed_get(port, "list_tokens", "u/test-user/test_script").await; assert_eq!(resp.status(), 200); resp.json::>().await?; // --- list_paths_from_workspace_runnable --- let resp = authed_get( port, "list_paths_from_workspace_runnable", "u/test-user/test_script", ) .await; assert_eq!(resp.status(), 200); resp.json::>().await?; // --- update script (create new version) --- let mut updated = new_script( "u/test-user/test_script", "Updated test script", "export async function main() { return 99; }", ); updated["parent_hash"] = json!(&hash); let resp = authed(client().post(format!("{base}/create"))) .json(&updated) .send() .await .unwrap(); assert_eq!(resp.status(), 201, "update: {}", resp.text().await?); // verify new version let resp = authed_get(port, "get/p", "u/test-user/test_script").await; let body = resp.json::().await?; assert_eq!(body["summary"], "Updated test script"); let new_hash = body["hash"].as_str().unwrap(); assert_ne!(new_hash, hash, "hash should change on update"); // history should have 2 entries now let resp = authed_get(port, "history/p", "u/test-user/test_script").await; let history = resp.json::>().await?; assert!( history.len() >= 2, "expected at least 2 history entries, got {}", history.len() ); // --- history_update --- let resp = authed(client().post(format!( "{base}/history_update/h/{new_hash}/p/u/test-user/test_script" ))) .json(&json!({"deployment_msg": "deployed v2"})) .send() .await .unwrap(); assert_eq!(resp.status(), 200, "history_update: {}", resp.text().await?); // --- toggle_workspace_error_handler (EE-gated, expect 400 in OSS) --- let resp = authed(client().post(script_url( port, "toggle_workspace_error_handler/p", "u/test-user/test_script", ))) .json(&json!({})) .send() .await .unwrap(); assert!( resp.status() == 200 || resp.status() == 400, "toggle_workspace_error_handler: unexpected status {}", resp.status() ); // --- get_triggers_count --- let resp = authed_get(port, "get_triggers_count", "u/test-user/test_script").await; assert_eq!(resp.status(), 200); // --- tokened_raw (global unauthed, token in URL) --- let resp = client() .get(format!( "http://localhost:{port}/api/scripts_u/tokened_raw/test-workspace/SECRET_TOKEN/u/test-user/test_script.ts" )) .send() .await .unwrap(); assert_eq!(resp.status(), 200, "tokened_raw: {}", resp.text().await?); // --- archive by path --- let resp = authed(client().post(script_url(port, "archive/p", "u/test-user/another_script"))) .send() .await .unwrap(); assert_eq!(resp.status(), 200); // archived script should still be gettable let resp = authed_get(port, "get/p", "u/test-user/another_script").await; assert_eq!(resp.status(), 200); let body = resp.json::().await?; assert_eq!(body["archived"], true); let another_hash = body["hash"].as_str().unwrap().to_string(); // --- archive by hash --- let resp = authed(client().post(script_url(port, "archive/h", &another_hash))) .send() .await .unwrap(); assert_eq!(resp.status(), 200); // --- delete by hash --- let resp = authed(client().post(script_url(port, "delete/h", &another_hash))) .send() .await .unwrap(); assert_eq!(resp.status(), 200); // --- delete_bulk --- let resp = authed(client().delete(format!("{base}/delete_bulk"))) .json(&json!({"paths": ["u/test-user/test_script"]})) .send() .await .unwrap(); assert_eq!(resp.status(), 200, "delete_bulk: {}", resp.text().await?); let resp = authed_get(port, "exists/p", "u/test-user/test_script").await; assert_eq!(resp.json::().await?, false); // --- empty_ts (global unauthed) --- let resp = client() .get(format!( "http://localhost:{port}/api/scripts_u/empty_ts/u/test-user/any_script" )) .send() .await .unwrap(); assert_eq!(resp.status(), 200); let body = resp.text().await?; assert!(body.is_empty(), "expected empty string, got: {body}"); // ===== Hub endpoints (require external network, expect 500 or 200) ===== // --- hub/top --- let resp = authed(client().get(format!("http://localhost:{port}/api/scripts/hub/top"))) .send() .await .unwrap(); assert!( resp.status() == 200 || resp.status() == 500, "hub/top: unexpected status {}", resp.status() ); // --- hub/get (raw script by path, needs hub/ prefix in path) --- let resp = authed(client().get(format!( "http://localhost:{port}/api/scripts/hub/get/hub/1/hello" ))) .send() .await .unwrap(); assert!( resp.status() == 200 || resp.status() == 500, "hub/get: unexpected status {}", resp.status() ); // --- hub/get_full (full script by path, needs hub/ prefix in path) --- let resp = authed(client().get(format!( "http://localhost:{port}/api/scripts/hub/get_full/hub/1/hello" ))) .send() .await .unwrap(); assert!( resp.status() == 200 || resp.status() == 500, "hub/get_full: unexpected status {}", resp.status() ); // --- integrations hub/list --- let resp = authed(client().get(format!("http://localhost:{port}/api/integrations/hub/list"))) .send() .await .unwrap(); assert!( resp.status() == 200 || resp.status() == 500, "integrations hub/list: unexpected status {}", resp.status() ); Ok(()) } #[sqlx::test(migrations = "../migrations", fixtures("base"))] async fn test_auto_parent_resolves_parent_hash(db: Pool) -> anyhow::Result<()> { initialize_tracing().await; let server = ApiServer::start(db.clone()).await?; let port = server.addr.port(); let base = format!("http://localhost:{port}/api/w/test-workspace/scripts"); // Create v1 let resp = authed(client().post(format!("{base}/create"))) .json(&new_script( "u/test-user/auto_parent_test", "v1", "export async function main() { return 1; }", )) .send() .await .unwrap(); assert_eq!(resp.status(), 201, "create v1: {}", resp.text().await?); // Get the hash of v1 let resp = authed_get(port, "get/p", "u/test-user/auto_parent_test").await; let body = resp.json::().await?; let v1_hash = body["hash"].as_str().unwrap().to_string(); // Create v2 using auto_parent (no parent_hash provided) let mut v2 = new_script( "u/test-user/auto_parent_test", "v2", "export async function main() { return 2; }", ); v2["auto_parent"] = json!(true); let resp = authed(client().post(format!("{base}/create"))) .json(&v2) .send() .await .unwrap(); assert_eq!( resp.status(), 201, "create v2 with auto_parent: {}", resp.text().await? ); // Get v2 and verify its parent_hash points to v1 let resp = authed_get(port, "get/p", "u/test-user/auto_parent_test").await; let body = resp.json::().await?; assert_eq!(body["summary"], "v2"); let v2_hash = body["hash"].as_str().unwrap().to_string(); assert_ne!(v2_hash, v1_hash); // v2's parent_hashes should contain v1 let parent_hashes = body["parent_hashes"].as_array().unwrap(); assert!( parent_hashes .iter() .any(|h| h.as_str() == Some(v1_hash.as_str())), "v2 parent_hashes should contain v1 hash {v1_hash}, got: {parent_hashes:?}" ); // Create v3 with auto_parent to confirm it chains correctly let mut v3 = new_script( "u/test-user/auto_parent_test", "v3", "export async function main() { return 3; }", ); v3["auto_parent"] = json!(true); let resp = authed(client().post(format!("{base}/create"))) .json(&v3) .send() .await .unwrap(); assert_eq!( resp.status(), 201, "create v3 with auto_parent: {}", resp.text().await? ); let resp = authed_get(port, "get/p", "u/test-user/auto_parent_test").await; let body = resp.json::().await?; assert_eq!(body["summary"], "v3"); // v3's parent_hashes should contain v2 (and transitively v1) let parent_hashes = body["parent_hashes"].as_array().unwrap(); assert!( parent_hashes .iter() .any(|h| h.as_str() == Some(v2_hash.as_str())), "v3 parent_hashes should contain v2 hash {v2_hash}, got: {parent_hashes:?}" ); Ok(()) } /// Regression test for GHSA-2ppx-66jv-wpw5: a path-scoped token must only see /// the scripts within its scope when listing, even though the route-level scope /// check only validates `domain:action`. Before the fix, `list_search` (and /// `list`) returned `path` + full `content` for every script the underlying /// user could see, leaking out-of-scope script source to narrowly-scoped tokens. #[sqlx::test(migrations = "../migrations", fixtures("base"))] async fn test_list_search_scope_filtering(db: Pool) -> anyhow::Result<()> { initialize_tracing().await; let server = ApiServer::start(db.clone()).await?; let port = server.addr.port(); let base = format!("http://localhost:{port}/api/w/test-workspace/scripts"); // Create two folders and one script in each, as the (super-admin) test user. for folder in ["allowed", "private"] { let resp = authed(client().post(format!( "http://localhost:{port}/api/w/test-workspace/folders/create" ))) .json(&json!({ "name": folder })) .send() .await .unwrap(); assert_eq!(resp.status(), 200, "create folder: {}", resp.text().await?); } for (path, content) in [ ( "f/allowed/foo", "export async function main() { return 'allowed'; }", ), ( "f/private/bar", "export async function main() { return 'secret'; }", ), ] { let resp = authed(client().post(format!("{base}/create"))) .json(&new_script(path, "summary", content)) .send() .await .unwrap(); assert_eq!(resp.status(), 201, "create {path}: {}", resp.text().await?); } // Helper: GET /list_search with an arbitrary bearer token, returning the set // of script paths visible to that token. async fn list_search_paths(port: u16, token: &str) -> Vec { let resp = client() .get(format!( "http://localhost:{port}/api/w/test-workspace/scripts/list_search" )) .header("Authorization", format!("Bearer {token}")) .send() .await .unwrap(); assert_eq!(resp.status(), 200); resp.json::>() .await .unwrap() .into_iter() .map(|s| s["path"].as_str().unwrap().to_string()) .collect() } // Insert three tokens for the same super-admin user, differing only by scope. sqlx::query( "INSERT INTO token (token_hash, token_prefix, token, email, label, super_admin, scopes) VALUES (encode(sha256('SCOPED_TOKEN'::bytea), 'hex'), 'SCOPED_TOK', 'SCOPED_TOKEN', 'test@windmill.dev', 'scoped', true, ARRAY['scripts:read:f/allowed/*']), (encode(sha256('BROAD_TOKEN'::bytea), 'hex'), 'BROAD_TOK', 'BROAD_TOKEN', 'test@windmill.dev', 'broad', true, ARRAY['scripts:read']), (encode(sha256('TAG_TOKEN'::bytea), 'hex'), 'TAG_TOK', 'TAG_TOKEN', 'test@windmill.dev', 'tag-only', true, ARRAY['if_jobs:filter_tags:default'])", ) .execute(&db) .await?; // Path-scoped token: only sees scripts within `f/allowed/*`. let scoped = list_search_paths(port, "SCOPED_TOKEN").await; assert!( scoped.contains(&"f/allowed/foo".to_string()), "scoped token should see f/allowed/foo, got: {scoped:?}" ); assert!( !scoped.contains(&"f/private/bar".to_string()), "scoped token must NOT see f/private/bar, got: {scoped:?}" ); // Broad `scripts:read` token: still sees every RLS-visible script. let broad = list_search_paths(port, "BROAD_TOKEN").await; assert!(broad.contains(&"f/allowed/foo".to_string())); assert!( broad.contains(&"f/private/bar".to_string()), "broad scripts:read token should see all scripts, got: {broad:?}" ); // Tag-filter-only token is not scope-restricted: unchanged, sees all. let tag_only = list_search_paths(port, "TAG_TOKEN").await; assert!(tag_only.contains(&"f/allowed/foo".to_string())); assert!(tag_only.contains(&"f/private/bar".to_string())); // Unscoped token (no scopes column set): unchanged, sees all. let unscoped = list_search_paths(port, "SECRET_TOKEN").await; assert!(unscoped.contains(&"f/allowed/foo".to_string())); assert!(unscoped.contains(&"f/private/bar".to_string())); Ok(()) }