* feat(otel): propagate inbound W3C traceparent to job spans Capture the inbound traceparent header at the run endpoints (WebhookArgs::to_args_from_format) into a reserved _wm_traceparent arg key (gated on OTEL_TRACING_ENABLED), riding the args jsonb like _ENTRYPOINT_OVERRIDE. At pickup, create_span_with_name attaches a span link from the job's worker span to the originating distributed trace, so a job triggered by an instrumented service is connected to the caller's trace while keeping its UUID-derived trace id (trace-by-job-id unaffected). The link/parse logic lives in the EE otel modules; this OSS side only captures the header and calls the (no-op outside EE) hook. Companion EE PR required. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore: bump ee-repo-ref to inbound-trace-propagation EE branch Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(agents): don't attribute work to specific customers in repo content Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(otel): relocate job + script spans into the inbound trace Builds on the captured _wm_traceparent: the worker job span is re-parented on the inbound caller context, the script subprocess's TRACEPARENT env is the inbound context (so its spans join the caller's trace), and the context is propagated to flow steps so the whole flow relocates. Carried to the worker via a new LogContext.inbound_traceparent field. Non-inbound jobs are unchanged. Adds a relocation integration test. Companion EE PR required. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore: bump ee-repo-ref to inbound-trace-propagation relocate commit Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(otel): harden inbound traceparent capture Address review feedback: - strip any caller-supplied _wm_traceparent from args/extra before stashing the header-captured value, so the reserved key is Windmill-controlled only - valid_w3c_traceparent: reject version ff and require lowercase hex, so we don't forward an inbound header that downstream OTel parsers would reject - clarify that the capture helper does not validate the W3C format (done at use) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore: update ee-repo-ref to 2c7964460327fab5e3a27c0f74b8d6f26ab7f79a This commit updates the EE repository reference after PR #604 was merged in windmill-ee-private. Previous ee-repo-ref: 8fc04fb105dc49769205f7174d551a0d134d1bec New ee-repo-ref: 2c7964460327fab5e3a27c0f74b8d6f26ab7f79a Automated by sync-ee-ref workflow. --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: windmill-internal-app[bot] <windmill-internal-app[bot]@users.noreply.github.com>
7.1 KiB
Windmill
Open-source platform for internal tools, workflows, API integrations, background jobs, and UIs. Rust backend + Svelte 5 frontend.
Workflow
- Understand: Before coding, explore the codebase (see Code Navigation below). Use
outlineto understand file structure,bodyto read specific symbols,def/callers/calleesto trace code,Grepto find usages. Readdocs/for domain context. - Plan: For non-trivial changes, use plan mode. For large features, break into reviewable stages
- Execute: Follow coding patterns from skills (
rust-backend,svelte-frontend) - Validate: After every change, run the appropriate checks per
docs/validation.md
Documentation
- Validation:
docs/validation.md— what checks to run based on what you changed - Enterprise:
docs/enterprise.md— EE file conventions and PR workflow - Backend patterns: use the
rust-backendskill when writing Rust code - Frontend patterns: use the
svelte-frontendskill when writing Svelte code. Do NOT edit svelte files unless you have read that skill. - Code review: review the current PR or branch against the shared review policy in
REVIEW.md(severity triage, public-surface checklist, AGENTS.md compliance, test-coverage assessment). The skill at.agents/skills/local-review/SKILL.mdorchestrates it. All three CLIs auto-discover the same SKILL — Claude reads.claude/skills/(symlinked to the canonical.agents/skills/file), Codex and Pi read.agents/skills/directly. Invoke with/local-reviewin Claude Code,$local-review(or/skillsselector) in Codex, orpi --skill local-review//skill:local-reviewin Pi. - Domain guides:
.claude/skills/native-trigger/andfrontend/tutorial-system-guide.mdc - Brand/UI guidelines:
frontend/brand-guidelines.md - CLI commands: when adding/modifying/removing a command, subcommand, option, or description in
cli/src/commands/, runpython system_prompts/generate.pyto refreshsystem_prompts/auto-generated/andcli/src/guidance/skills.gen.ts. The CLI docs the agents use to operatewmillare derived from the source — stale generated files give agents the wrong flags.
Dev Environment
- Backend:
cargo runfrombackend/(API at http://localhost:8000) - Frontend:
REMOTE=http://localhost:8000 npm run devfromfrontend/(port 3000+) - DB:
psql postgres://postgres:changeme@localhost:5432/windmill - Login:
admin@windmill.dev/changeme - Instance settings: navigate to
/#superadmin-settings - Migrations: use
cargo sqlx migrate add -r <name>frombackend/to create new migrations (never generate timestamps manually)
Verifying Frontend Changes
After modifying frontend code, drive the running dev server with the Playwright MCP to verify the change in a real browser — don't claim a UI change works without exercising it.
Two MCP servers are registered in .mcp.json:
playwright— headless Chromium, default for devboxes (no display required)playwright-headed— windowed Chromium, when a display is available
One-time setup: run npx playwright install chromium to download the browser binary (Playwright won't fetch it automatically on first use).
Typical flow:
- Ensure backend (
cargo run) and frontend (REMOTE=http://localhost:8000 npm run dev) are running mcp__playwright__browser_navigateto the relevant page (login atadmin@windmill.dev/changeme)mcp__playwright__browser_snapshotto inspect the accessibility tree (preferred over screenshots for reading the DOM)mcp__playwright__browser_click/browser_fill_form/browser_typeto interactmcp__playwright__browser_take_screenshotfor visual confirmationmcp__playwright__browser_console_messages/browser_network_requeststo surface errors
If you cannot exercise a UI change (no dev server, etc.), say so explicitly rather than claiming success.
Banned Patterns
$bindable(default_value) on optional props
Using $bindable(default_value) on props that can be undefined is banned. This pattern causes subtle bugs because the default value masks the undefined state.
Bad:
let { my_prop = $bindable(default_value) }: { my_prop?: string } = $props()
Correct alternatives:
-
Use
$derivedwith nullish coalescing — handle the potentialundefinedat the usage site:let { my_prop = $bindable() }: { my_prop?: string } = $props() let effective_value = $derived(my_prop ?? default_value) -
Create a
useMyPropState()helper — encapsulate the undefined-handling logic in a reusable function and call it higher in the component tree, so the child component always receives a defined value.
Code Navigation
wm-ts-nav is an AST-aware code navigator. Use wm-ts-nav for structural queries — it skips comments/strings and understands symbol boundaries.
MUST use outline before Read on unfamiliar files — a 500-line file costs ~500 lines of context, while outline costs ~20. Then MUST use body "X" instead of reading a full file to see one function/struct. Use Read with offset/limit only when you need surrounding context that body doesn't capture.
refs "X" --callerinstead of reading files to find which function contains each referencecallers "X"/callees "X"for call-graph questions
EE files (*_ee.rs, *_ee.ts, *_ee.svelte) are indexed — you can outline, def, body, refs etc. on them just like regular files.
NAV="sh wm-ts-nav/nav"
# Use --root backend for Rust, --root frontend/src for TS/Svelte
$NAV --root backend outline backend/path/to/file.rs # file structure
$NAV --root backend def "ServiceName" # find definition
$NAV --root backend body "decrypt_oauth_data" # extract source code
$NAV --root backend search "%" --parent ServiceName # methods on a type
$NAV --root backend search "Trigger" --kind struct # find by kind
$NAV --root backend refs "X" --file handler.rs --caller # scoped refs with caller
$NAV --root backend callers "X" # who calls X?
$NAV --root backend callees "X" # what does X call?
Limitations — syntax-level analysis, no type inference. Use Grep instead when completeness matters (finding all usages, exhaustiveness checks):
refs/callers/calleescan't follow re-exports, glob imports, or different import paths to the same symbol- Trait impls, macro-generated symbols (
sqlx::FromRow), and namespace member access (ns.X) are invisible calleesshows all identifiers in a function body, not just actual calls
Core Principles
- MUST
outlinebeforeReadon unfamiliar files — thenbodyorReadwith offset/limit for specifics - Search for existing code to reuse before writing new code
- Follow established patterns in the codebase
- Keep changes focused — don't refactor beyond what's asked
- Never attribute work to a specific customer, account, or "requested by a customer" in repo-tracked content (PR descriptions, commit messages, code comments, docs). Describe changes by their technical motivation instead.