mirror of https://github.com/windmill-labs/windmill.git synced 2026-08-19 00:02:03 +00:00

Files

T

History

Ruben Fiszel f2a18beca4 fix(security): remove git from Deno sandbox allow-run (GHSA-gj6h-vw66-mr8f)

The `// sandbox` annotation restricts Deno to `--allow-run=git,/usr/bin/chromium`.
git can be coerced into spawning `/bin/sh` via hook configs such as
`git -c core.fsmonitor=<cmd> status`, and that subprocess is spawned by git —
not Deno — so it is invisible to Deno's permission model. This let any user
with script-execution permission run arbitrary OS commands as root inside the
worker, fully defeating the sandbox.

The advisory's alternative (injecting `-c core.fsmonitor=false -c
core.hooksPath=/dev/null`) does not apply here: the user's own script invokes
git directly via `Deno.Command`, so Windmill cannot inject hardening flags into
that call. Removing git from the allowlist is the only complete fix. git was
originally allowed for git-sync-adjacent use, which no longer needs it.

Verified with the advisory PoC: git invocation now returns
`Requires run access to "git"` and the sandbox escape is closed. chromium
(puppeteer) support is preserved.

Fixes WIN-2151

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2026-07-10 12:48:02 +00:00

nsjail

fix(python): split PIP_TRUSTED_HOST by whitespace to support multiple hosts (#9675 )

2026-06-19 12:59:08 +00:00

src

fix(security): remove git from Deno sandbox allow-run (GHSA-gj6h-vw66-mr8f)

2026-07-10 12:48:02 +00:00

build.rs

refactor: isolate deno_core into windmill-runtime-nativets subcrate (#7848 )

2026-02-08 09:16:37 +00:00

Cargo.toml

perf: eliminate dual-connection DB pool contention across worker, queue, and api (#9798 )