mirror of https://github.com/windmill-labs/windmill.git synced 2026-08-19 16:02:14 +00:00

Files

T

Ruben Fiszel 6647c2be84 ci: cross-agent local-review skill (Claude + Pi share one file, Codex via wrapper) (#9037 )

* ci: make local-review a single-source-of-truth cross-agent skill

The repo already had parallel skills directories (.agents/skills/ and
.claude/skills/) drifting between agents. Consolidate local-review
onto one canonical file in .agents/ and symlink the .claude/ entry to
it so Claude Code and Pi share the exact same SKILL.md (Anthropic's
Skills format is supported by both, only the discovery directory
differs).

The canonical SKILL.md now points reviewers at
.github/review-prompt-shared.md as the policy source — same shared
prompt the GitHub auto-review workflows already use — so local
reviews and CI reviews stay in lockstep.

Codex CLI doesn't support repo-level slash commands (its prompts live
in ~/.codex/prompts/). For Codex parity, ship scripts/local-review.sh
which pipes the SKILL + shared policy into 'codex exec' (or 'pi -p'
as a uniform entry point). Update AGENTS.md to document the three
invocation paths.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* ci: make all skills cross-agent — single source in .agents/, symlink .claude/

Turn every skill into a single canonical file under .agents/skills/ and
a symlink under .claude/skills/. Editing any one SKILL.md now updates
all three CLIs (Claude Code reads .claude/, Codex and Pi auto-discover
.agents/).

Per-skill resolution:
- local-review: already symlinked (prior PR #9037)
- rust-backend, svelte-frontend: identical content → symlink, no edit
- refine: only differed in user_invocable frontmatter → add to canonical
- native-trigger: .claude/ had a newer Step 17 (sidebar visibility)
  missing from .agents/ → use Claude content as canonical
- commit: .claude/ embedded a Claude-specific Co-Authored-By trailer
  the harness already injects automatically → drop from canonical, use
  agent-neutral .agents/ version
- pr: generalize "Run /local-review" to "Invoke the local-review skill
  (/local-review in Claude Code, $local-review in Codex, pi --skill
  local-review in Pi)" and drop the Claude-specific "Generated with
  Claude Code" attribution from the PR body template — the harness
  that invoked the skill can add its own trailer if desired
- adding-a-trigger: was only in .claude/ → move to .agents/ canonical
- update-sqlx: was only in .agents/ → add .claude/ symlink

Also drop scripts/local-review.sh — wrapper is redundant now that all
three CLIs natively discover the skill from their respective
directories. Update AGENTS.md accordingly.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-05-04 17:41:54 +00:00

1.7 KiB

Raw Permalink Blame History

name, user_invocable, description

name	user_invocable	description
commit	true	Create a git commit with conventional commit format. MUST use anytime you want to commit changes.

Git Commit Skill

Create a focused, single-line commit following conventional commit conventions.

Instructions

Analyze changes: Run git status and git diff to understand what was modified
Stage only modified files: Add files individually by name. NEVER use git add -A or git add .
Write commit message: Follow the conventional commit format as a single line

Conventional Commit Format

<type>: <description>

Types

feat: New feature or capability
fix: Bug fix
refactor: Code change that neither fixes a bug nor adds a feature
docs: Documentation only changes
style: Formatting, missing semicolons, etc (no code change)
test: Adding or correcting tests
chore: Maintenance tasks, dependency updates, etc
perf: Performance improvement

Rules

Message MUST be a single line (no multi-line messages)
Description should be lowercase, imperative mood ("add" not "added")
No period at the end
Keep under 72 characters total

Examples

feat: add token usage tracking for AI providers
fix: resolve null pointer in job executor
refactor: extract common validation logic
docs: update API endpoint documentation
chore: upgrade sqlx to 0.7

Execution Steps

Run git status to see all changes
Run git diff to understand the changes in detail
Run git log --oneline -5 to see recent commit style
Stage ONLY the modified/relevant files: git add <file1> <file2> ...
Create the commit with conventional format:
```
git commit -m "<type>: <description>"
```
Run git status to verify the commit succeeded

1.7 KiB Raw Permalink Blame History