mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-09-05 08:02:18 +00:00
Ruben FiszelandClaude Opus 4.8
cafb473494
* fix(python): split PIP_TRUSTED_HOST by whitespace for multiple hosts When PIP_TRUSTED_HOST contains multiple space-separated hostnames, the whole string was passed as a single --trusted-host argument (--trusted-host "host1 host2") rather than one flag per host. This matches pip's documented PIP_TRUSTED_HOST convention by emitting a separate --trusted-host for each host, mirroring the existing pip_extra_index_url handling. Fixes WIN-2077 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(python): use shell word-splitting for nsjail trusted-host args Address review feedback: the previous tr/sed pipeline only split on single spaces, diverging from the Rust split_whitespace() paths. Repeated or leading/trailing spaces produced empty --trusted-host flags and tab-separated hosts were not split. Use an unquoted for-loop over $TRUSTED_HOST so the shell's own IFS word-splitting handles arbitrary whitespace and skips empty fields, matching the non-nsjail paths. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
40 lines
824 B
Bash
Executable File
40 lines
824 B
Bash
Executable File
#/bin/sh
|
|
|
|
INDEX_URL_ARG=$([ -z "$INDEX_URL" ] && echo ""|| echo "--index-url $INDEX_URL" )
|
|
EXTRA_INDEX_URL_ARG=$([ -z "$EXTRA_INDEX_URL" ] && echo ""|| echo "--extra-index-url $EXTRA_INDEX_URL" )
|
|
TRUSTED_HOST_ARG=""
|
|
for h in $TRUSTED_HOST; do TRUSTED_HOST_ARG="$TRUSTED_HOST_ARG --trusted-host $h"; done
|
|
|
|
if [ ! -z "$INDEX_URL" ]
|
|
then
|
|
echo "\$INDEX_URL is set to $INDEX_URL"
|
|
fi
|
|
|
|
if [ ! -z "$EXTRA_INDEX_URL" ]
|
|
then
|
|
echo "\$EXTRA_INDEX_URL is set to $EXTRA_INDEX_URL"
|
|
fi
|
|
|
|
if [ ! -z "$TRUSTED_HOST" ]
|
|
then
|
|
echo "\$TRUSTED_HOST is set to $TRUSTED_HOST"
|
|
fi
|
|
|
|
CMD="/usr/local/bin/uv pip install
|
|
\"$REQ\"
|
|
--target \"$TARGET\"
|
|
--no-cache
|
|
--no-config
|
|
--no-color
|
|
--no-deps
|
|
--link-mode=copy
|
|
$PY_PATH
|
|
$INDEX_URL_ARG $EXTRA_INDEX_URL_ARG $TRUSTED_HOST_ARG
|
|
--system
|
|
--reinstall
|
|
--compile-bytecode
|
|
"
|
|
|
|
echo $CMD
|
|
eval $CMD
|