mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-08-21 16:02:28 +00:00
0317d5891c
* feat: add powershell common parameters support (-Verbose, -Debug, -ErrorAction, -WhatIf) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: add powershell common params to script editor test panel Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: detect CmdletBinding from code instead of schema in script editor Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: ignore commented-out CmdletBinding in powershell detection Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: use preference variables for -Verbose/-Debug instead of CLI args Verbose/Debug output goes to PowerShell stream 4/5 which isn't captured by the 2>&1 redirect. Setting $VerbosePreference/$DebugPreference in the wrapper scope propagates to child scripts and output flows through the host to stderr, which Windmill captures as logs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: use *>&1 to capture all powershell streams including verbose/debug The previous 2>&1 only captured error stream. Verbose (stream 4) and debug (stream 5) output was silently lost. Using *>&1 redirects all streams to success stream so they flow through Tee-Object into logs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: use targeted stream redirects (4>&1 5>&1 2>&1) instead of *>&1 *>&1 breaks $PSCmdlet.ShouldProcess() by redirecting internal streams. Only redirect verbose (4), debug (5), and error (2) to success stream. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: revert to 2>&1 redirect — stream 4/5 redirects break powershell Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: use 4>&1 5>&1 for verbose/debug capture, remove WhatIf support Stream 4/5 redirects capture verbose/debug in the pipeline. WhatIf is removed because $PSCmdlet.ShouldProcess() doesn't work when scripts are invoked through Windmill's wrapper. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: redirect verbose/debug to files to keep result pipeline clean Verbose (4) and debug (5) streams are redirected to separate log files during script execution, then output via Write-Host after the script completes. This keeps them out of the Tee-Object pipeline (used for result extraction) while still showing them in the job logs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: output verbose/debug to stderr via Console.Error for log capture Write-Host goes to stdout which gets mixed with result output and truncated by OSS log threshold. Using [Console]::Error.WriteLine() writes to stderr which Windmill captures separately as logs, with VERBOSE:/DEBUG: prefixes for clarity. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: redirect script output to file only, send verbose/debug to stdout The OSS log storage has a 9KB threshold. Previously, Tee-Object sent the full JSON result to both stdout (logs) and the pipe file, eating the log budget. Now script output goes only to the pipe file (> $pipe), and only verbose/debug messages go to stdout for the log viewer. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: preserve original Tee-Object behavior, append verbose/debug after Keep the original wrapper behavior (Tee-Object to stdout + pipe file). Only add 4>verbose.log 5>debug.log to capture those streams, and output them at the end of logs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: inject preference vars into main.ps1 instead of CLI args Passing -Verbose/-Debug as CLI args causes PowerShell module loading to emit verbose noise. Instead, inject $VerbosePreference/$DebugPreference inside main.ps1's try block so they only affect user code. Stream 4/5 are still redirected to files in the wrapper for log output. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: restore common param toggles from previous job args on Run Again Extract _wm_ps_* keys from loaded args and initialize the toggle states in PowerShellCommonParams. Also strip them from main args so they don't appear as unknown schema form inputs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: show active common param badges when section is collapsed Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: inject ErrorAction as preference variable instead of CLI arg -ErrorAction as a CLI arg only affects the caller, not the script's internal error handling. Setting $ErrorActionPreference inside main.ps1 correctly overrides the default 'Stop' behavior for the user's code. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: ensure full backward compatibility with existing powershell scripts - Only filter common param names when [CmdletBinding()] is present (without it, $Verbose etc. are regular user-defined parameters) - Only add 4>verbose.log 5>debug.log and log output lines when common params are actually enabled — original wrapper is unchanged otherwise Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: lighter styling for common params section Replaced heavy Section component with a subtle inline chevron toggle labeled "Common parameters". Smaller text, secondary color, indented options. Badges still show when collapsed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: rename section to CmdletBinding parameters Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: add ..Default::default() to windmill-parser-r (new parser from main) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: missing comma in graphql parser test + merge main Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: add missing commas before ..Default::default() in parser tests Merge from main brought test constructors with formatting issues from the original automated script (missing comma between last field and ..Default::default()). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: restore comment markers in nu parser test that script broke Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address PR review — ignore commented CmdletBinding, clear stale params 1. Parser: strip comment lines before detecting [CmdletBinding()] to avoid false positives from commented-out attributes 2. RunForm: always assign psCommonParams (not just when non-empty) so stale settings from a previous run don't leak into later runs Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
90 lines
2.5 KiB
Svelte
90 lines
2.5 KiB
Svelte
<script lang="ts">
|
|
import { Badge } from './common'
|
|
import Toggle from './Toggle.svelte'
|
|
import Select from '$lib/components/select/Select.svelte'
|
|
import { untrack } from 'svelte'
|
|
import { ChevronRight } from 'lucide-svelte'
|
|
|
|
interface Props {
|
|
args?: Record<string, any>
|
|
}
|
|
|
|
let { args = $bindable({}) }: Props = $props()
|
|
|
|
let verbose = $state(false)
|
|
let debug = $state(false)
|
|
let errorAction = $state(undefined as string | undefined)
|
|
let collapsed = $state(true)
|
|
let initialized = false
|
|
|
|
const errorActionItems = [
|
|
{ label: 'Stop', value: 'Stop' },
|
|
{ label: 'Continue', value: 'Continue' },
|
|
{ label: 'SilentlyContinue', value: 'SilentlyContinue' }
|
|
]
|
|
|
|
let activeBadges = $derived.by(() => {
|
|
const badges: string[] = []
|
|
if (verbose) badges.push('Verbose')
|
|
if (debug) badges.push('Debug')
|
|
if (errorAction) badges.push(`ErrorAction: ${errorAction}`)
|
|
return badges
|
|
})
|
|
|
|
// Initialize toggles from pre-populated args (e.g. "Run again")
|
|
$effect(() => {
|
|
if (!initialized && args && Object.keys(args).length > 0) {
|
|
initialized = true
|
|
untrack(() => {
|
|
verbose = args['_wm_ps_verbose'] === true
|
|
debug = args['_wm_ps_debug'] === true
|
|
errorAction = args['_wm_ps_error_action'] ?? undefined
|
|
})
|
|
}
|
|
})
|
|
|
|
// Sync toggles → args
|
|
$effect(() => {
|
|
const newArgs: Record<string, any> = {}
|
|
if (verbose) newArgs['_wm_ps_verbose'] = true
|
|
if (debug) newArgs['_wm_ps_debug'] = true
|
|
if (errorAction) newArgs['_wm_ps_error_action'] = errorAction
|
|
args = newArgs
|
|
})
|
|
</script>
|
|
|
|
<div class="flex flex-col">
|
|
<button
|
|
class="flex items-center gap-1 text-xs text-secondary hover:text-primary transition-colors"
|
|
onclick={() => (collapsed = !collapsed)}
|
|
>
|
|
<ChevronRight size={12} class="transition duration-200 {collapsed ? '' : 'rotate-90'}" />
|
|
CmdletBinding parameters
|
|
{#if collapsed && activeBadges.length > 0}
|
|
<div class="flex gap-1 ml-1">
|
|
{#each activeBadges as label}
|
|
<Badge color="blue">{label}</Badge>
|
|
{/each}
|
|
</div>
|
|
{/if}
|
|
</button>
|
|
{#if !collapsed}
|
|
<div class="flex flex-col gap-2 mt-2 ml-4">
|
|
<Toggle options={{ right: 'Verbose' }} bind:checked={verbose} size="xs" />
|
|
<Toggle options={{ right: 'Debug' }} bind:checked={debug} size="xs" />
|
|
<div class="flex items-center gap-2">
|
|
<span class="text-xs text-secondary">ErrorAction</span>
|
|
<div class="w-40">
|
|
<Select
|
|
items={errorActionItems}
|
|
bind:value={errorAction}
|
|
placeholder="Default"
|
|
clearable
|
|
size="sm"
|
|
/>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
{/if}
|
|
</div>
|