mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-09-10 16:05:58 +00:00
* feat: responsive modal step panel for the flow editor in sessions On narrow layouts the flow editor's step-details pane opens as a modal (double-click a graph node) instead of a split pane, with a dock/float toggle. Scoped to sessions via allowModalPanel; the full-page editor is unchanged. - FlowEditor: modal/docked modes gated by mount width + allowModalPanel, small header (step-id Badge + subtle dock/close), standing double-click hint, and a per-step hint in the name tooltip - selectionManager: onSelectIntent hook so flow-level panels (settings, input, triggers…) open the modal on single click - PropPickerWrapper: collapse the prop picker until connect and animate it in via AnimatedPane (runs-page pattern), no blue connect ring in modal mode - StepInputGen: drop the TAB/Wand autocompletion button + spinner (feature still works via focus + Tab) - InputTransformForm: decouple the Help dropdown from the AI suggestion - FlowModuleHeader: move 'Save to workspace' into an ellipsis dropdown Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix: loop editor rendering and nested splitpanes splitters in the sessions modal - Loop iterator/parallelism: keep the picker split pane (forceExpanded) so the editor fills its box and the picker shows; the collapse-until-connect mode stays for the step inputs - Remove the intrusive AI TAB/Wand autocompletion button from IteratorGen (generation still runs headless via focus + Tab) - Size the iterator connect plug and restyle the loop header/labels/toggles - Scope the global `.splitter-hidden` splitter-hiding rule to direct children so it no longer leaks into nested Splitpanes under the sessions preview Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat: redesign flow step advanced settings as a single toggle-first column Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat: taller step test pane by default and restyle advanced section titles Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat: show flow run-settings params disabled when a setting is toggled off Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat: single-column for-loop panel reusing the run-settings accordion Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat: single-column while-loop panel reusing the run-settings accordion Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat: single-column branch panels reusing the run-settings accordion Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix: auto-open modal panel when creating an AI agent tool Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat: redesign branch panels with card layout and shared predicate editor Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor: remove per-setting status badges from flow map nodes Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore: sync package-lock after windmill-utils-internal bump Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * style: polish prop-picker plug button and branch panel layouts * fix: persist skip-if-stopped toggles in early stop settings * fix: open the step panel modal on demand and cap its width * fix: restore graph step setting badges, strip panel header chips instead * feat: docked panel header with detach action and open-details step menu * feat: width-based panel mode on every surface with inline detach action * refactor: single source for flow step settings and their defaults * docs: pin flow editor vocabulary in CONTEXT.md * fix: open the trigger panel on double click or a specific trigger * fix: keep module pickers inside their pane and dismissable * fix: drop the misleading chevron on the MCP tool entry * fix: resolve flow approvals against the job's workspace, not the nav one * refactor: derive the approval workspace from the job, not from callers * fix: restore S3 snippets and gate params while their setting is off * fix: restore branch mock controls and address review findings * chore: drop stray debug log from the flow map item * feat: pinned output section for loop and branch panels * fix: open the panel for deliberate navigation from the flow header * perf: mount branch predicate editors on demand * fix: skip predicate picker previews the previous step's result * fix: flow-level graph nodes open their panel on a single click * fix: open the step panel for AI chat selections, not for undo * chore: drop dead console.log and duplicated modalPanel doc * fix: re-sync expression editors and scope error-handler settings * fix: match the failure module exactly and ignore unselectable nodes * fix: keep concurrency editable, honour module cache_ttl, tighten panel ids * fix: open panel from indirect selections, use presence for value-driven toggles * fix: don't open settings on error-handler delete, flush editors on unmount * fix: guard editor destroy flush, keep retry kind reachable * refactor: name the run settings panel after the domain vocabulary * fix: only write editor flushes to the step they belong to * fix: bind step panels by id so a delete can't retarget editor writes * fix: don't let the trigger picker's escape close the drawer beneath it * docs: condense two comments to the constraint they record * fix: arbitrate escape through the overlay stack instead of deferring to it * fix: key nested step blocks by identity so anchored bindings can't go stale * fix: untrack the overlay-stack push and drop the frozen branch binding * chore: state the escape rationale once, key branch lists, format * fix: let the topmost overlay own escape instead of the graph * fix: keep the dynamic-input help box out of static template fields * fix: restore the graph connect on the for-loop iterator * fix: end connect mode with the modal and keep it to docked panels * fix: never enter graph connect mode from the modal panel * fix: reveal inserted steps, restore editor pane size, unleak the drawer stack * fix: keep the enable-AI popover reachable in session panes * feat: add the connect policy and its single armed slot * refactor: one picker for every expression input * refactor: route every connect through one armed slot * fix: give every connect button the same footprint * fix: keep the connect ring from showing through the button * fix: keep flow card actions right-aligned beside the detach button * fix: give the connect ring an opaque ground to mask against * feat: dock the panel back without reopening it * feat: dock the panel from the graph control bar * style: round the graph control bar and size its glyphs * style: customize the graph controls through their supported api * style: build the graph control bar from lucide icons * fix: use the graph's tooltip component in the zoom controls * style: pad the graph controls and enlarge their glyphs * style: pad the graph controls and put dock at the bar's end * refactor: give settings rows the same popover picker as other expressions * fix: pass the wrapper's pickable properties to nested inputs * refactor: stack step settings and render every expression through the step input form * feat: split loop panels into tabs and rework the approval form * feat: anchor drawers to their host pane and give them a size floor * fix: mark the loop iterator expression as required * refactor: badge ee-only toggles instead of a warning line * fix: flag an empty loop iterator expression as an error * refactor: pick the early-stop flow status from one toggle group * fix: keep parallel loops uncapped unless a limit is opted into * fix: scope the overlay stack to its host and disarm connect on dismissal * fix: anchor the trigger picker to its host pane * feat: move diff into the menu when the top bar is narrow * fix: gate the result logs toggle to the graph popover * feat: raise the modal-panel breakpoint to 1280 * fix: anchor flow editor popovers and fullscreen to their host pane * fix: anchor overlays to their host pane and mute them when hidden * fix: portal hosted modals and menus into the pane they anchor to * fix: keep non-listening dialogs off the overlay stack * fix: drop the topmost gate from confirmation dialogs * fix: silence overlays in a collapsed preview panel * feat: rework the branch panels with tabs, reordering and add/delete * refactor: fold the detached-panel chrome into the card header * fix: give every flow panel a titled card header * fix: stop the step panel oscillating on an auto-height editor * feat: consolidate script panel actions and restore branch predicate AI * fix: restore the logs toggle on the flow result popover * fix: collapse the idle property picker in modal step panels * fix: stop the docked pane scrolling alongside its panel * fix: space the last settings row off the panel bottom * revert: always show the property picker pane in step panels * chore: keep the inline script AI button identical to main * fix: ask for AI input suggestions on click, not on hover * fix: keep graph connects armed and remount the parallelism input * style: reveal the predicate AI button on row hover * style: give branch cards a handle and delete column * refactor: arbitrate flow overlay escape through Disposable * fix: give the popover picker its results and re-narrow the EE badge * docs: correct loopSubset and guard the modal width measurement * fix: insert picked properties at the cursor in expression inputs * fix: give the expanded-subflow panel the shared header chrome * style: rename the suspend setting to Suspend until approval/resume * feat: open a step's modal when clicking the step already selected * feat: add an auto/attached/detached toggle for the step panel * refactor: pick the step panel's placement from one named menu * refactor: keep the panel-mode module's exports to what is consumed * feat: show each configured setting's value on its badge * fix: carry the suspend rename into the step settings registry * docs: name both gestures in the step explore hint * test: pin where the step panel goes for a given width and preference --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
284 lines
9.5 KiB
Svelte
284 lines
9.5 KiB
Svelte
<script lang="ts">
|
|
import { createBubbler } from 'svelte/legacy'
|
|
import Section from '$lib/components/Section.svelte'
|
|
import Label from '$lib/components/Label.svelte'
|
|
import Toggle from '$lib/components/Toggle.svelte'
|
|
import Tooltip from '$lib/components/Tooltip.svelte'
|
|
import Alert from '$lib/components/common/alert/Alert.svelte'
|
|
import { SecondsInput } from '$lib/components/common'
|
|
import WorkerTagPicker from '$lib/components/WorkerTagPicker.svelte'
|
|
import DebounceLimit from '$lib/components/flows/DebounceLimit.svelte'
|
|
import { enterpriseLicense } from '$lib/stores'
|
|
import { isCloudHosted } from '$lib/cloud'
|
|
import type { Schema } from '$lib/common'
|
|
import type { ScriptAdvancedSettingsFields } from './scriptSettings'
|
|
|
|
const bubble = createBubbler()
|
|
|
|
interface Props {
|
|
script: ScriptAdvancedSettingsFields
|
|
// Workspace to read worker tags from (defaults to $workspaceStore inside the picker).
|
|
workspaceId?: string | undefined
|
|
}
|
|
|
|
let { script = $bindable(), workspaceId = undefined }: Props = $props()
|
|
</script>
|
|
|
|
<div class="flex flex-col gap-8">
|
|
<Section label="Worker group tag (queue)">
|
|
{#snippet header()}
|
|
<Tooltip documentationLink="https://www.windmill.dev/docs/core_concepts/worker_groups">
|
|
The script will be executed on a worker configured to listen to this worker group tag
|
|
(queue). For instance, you could setup an "highmem", or "gpu" tag.
|
|
</Tooltip>
|
|
{/snippet}
|
|
<WorkerTagPicker bind:tag={script.tag} {workspaceId} />
|
|
</Section>
|
|
|
|
<Section label="Concurrency limits" eeOnly>
|
|
{#snippet header()}
|
|
<Tooltip documentationLink="https://www.windmill.dev/docs/core_concepts/concurrency_limits">
|
|
Allowed concurrency within a given timeframe
|
|
</Tooltip>
|
|
{/snippet}
|
|
<Toggle
|
|
size="sm"
|
|
checked={Boolean(script.concurrent_limit)}
|
|
on:change={() => {
|
|
if (script.concurrent_limit && script.concurrent_limit != undefined) {
|
|
script.concurrent_limit = undefined
|
|
script.concurrency_time_window_s = undefined
|
|
script.concurrency_key = undefined
|
|
} else {
|
|
script.concurrent_limit = 1
|
|
}
|
|
}}
|
|
options={{ right: 'Concurrency limits' }}
|
|
/>
|
|
{#if Boolean(script.concurrent_limit)}
|
|
<div class="flex flex-col gap-4 mt-2">
|
|
<Label label="Max number of executions within the time window">
|
|
<div class="flex flex-row gap-2 max-w-sm whitespace-nowrap">
|
|
<input
|
|
disabled={!$enterpriseLicense}
|
|
bind:value={script.concurrent_limit}
|
|
type="number"
|
|
/>
|
|
</div>
|
|
</Label>
|
|
<Label label="Time window in seconds">
|
|
<SecondsInput
|
|
disabled={!$enterpriseLicense}
|
|
bind:seconds={script.concurrency_time_window_s}
|
|
/>
|
|
</Label>
|
|
<Label label="Custom concurrency key (optional)">
|
|
{#snippet header()}
|
|
<Tooltip
|
|
documentationLink="https://www.windmill.dev/docs/core_concepts/concurrency_limits#custom-concurrency-key"
|
|
>
|
|
Concurrency keys are global, you can have them be workspace specific using the
|
|
variable `$workspace`. You can also use an argument's value using `$args[name_of_arg]`</Tooltip
|
|
>
|
|
{/snippet}
|
|
<input
|
|
disabled={!$enterpriseLicense}
|
|
type="text"
|
|
bind:value={script.concurrency_key}
|
|
placeholder={`$workspace/script/${script.path ?? ''}-$args[foo]`}
|
|
/>
|
|
</Label>
|
|
</div>
|
|
{/if}
|
|
</Section>
|
|
|
|
<Section label="Cache">
|
|
{#snippet header()}
|
|
<Tooltip documentationLink="https://www.windmill.dev/docs/core_concepts/caching">
|
|
Cache the results for each possible inputs
|
|
</Tooltip>
|
|
{/snippet}
|
|
<div class="flex gap-2 shrink flex-col">
|
|
<Toggle
|
|
size="sm"
|
|
bind:checked={() => !!script.cache_ttl, (v) => (script.cache_ttl = v ? 300 : undefined)}
|
|
options={{ right: 'Cache the results for each possible inputs' }}
|
|
/>
|
|
{#if script.cache_ttl}
|
|
<div class="text-2xs text-secondary">How long to keep the cache valid</div>
|
|
<SecondsInput bind:seconds={script.cache_ttl} />
|
|
<Toggle
|
|
size="2xs"
|
|
bind:checked={
|
|
() => script.cache_ignore_s3_path, (v) => (script.cache_ignore_s3_path = v || undefined)
|
|
}
|
|
options={{
|
|
right: 'Ignore S3 Object paths for caching purposes',
|
|
rightTooltip:
|
|
'If two S3 objects passed as input have the same content, they will hit the same cache entry, regardless of their path.'
|
|
}}
|
|
/>
|
|
{/if}
|
|
</div>
|
|
</Section>
|
|
|
|
<Section label="Timeout">
|
|
{#snippet header()}
|
|
<Tooltip documentationLink="https://www.windmill.dev/docs/script_editor/settings#timeout">
|
|
Add a custom timeout for this script
|
|
</Tooltip>
|
|
{/snippet}
|
|
<div class="flex gap-2 shrink flex-col">
|
|
<Toggle
|
|
size="sm"
|
|
checked={Boolean(script.timeout)}
|
|
on:change={() => {
|
|
if (script.timeout && script.timeout != undefined) {
|
|
script.timeout = undefined
|
|
} else {
|
|
script.timeout = 300
|
|
}
|
|
}}
|
|
options={{ right: 'Add a custom timeout for this script' }}
|
|
/>
|
|
{#if Boolean(script.timeout)}
|
|
<span class="text-xs font-semibold text-emphasis leading-none mt-2">Timeout duration</span>
|
|
<SecondsInput bind:seconds={script.timeout} />
|
|
{/if}
|
|
</div>
|
|
</Section>
|
|
|
|
<Section label="Debouncing">
|
|
{#snippet header()}
|
|
<Tooltip documentationLink="https://www.windmill.dev/docs/core_concepts/job_debouncing">
|
|
Debounce Jobs
|
|
</Tooltip>
|
|
{/snippet}
|
|
<DebounceLimit
|
|
size="sm"
|
|
bind:debounce_delay_s={script.debounce_delay_s}
|
|
bind:debounce_key={script.debounce_key}
|
|
bind:debounce_args_to_accumulate={script.debounce_args_to_accumulate}
|
|
bind:max_total_debouncing_time={script.max_total_debouncing_time}
|
|
bind:max_total_debounces_amount={script.max_total_debounces_amount}
|
|
schema={script.schema as Schema}
|
|
placeholder={`$workspace/script/${script.path ?? ''}-$args[foo]`}
|
|
/>
|
|
</Section>
|
|
|
|
<Section label="Perpetual script">
|
|
{#snippet header()}
|
|
<Tooltip documentationLink="https://www.windmill.dev/docs/script_editor/perpetual_scripts">
|
|
Restart the script upon ending unless cancelled
|
|
</Tooltip>
|
|
{/snippet}
|
|
<Toggle
|
|
size="sm"
|
|
checked={Boolean(script.restart_unless_cancelled)}
|
|
on:change={() => {
|
|
script.restart_unless_cancelled = script.restart_unless_cancelled ? undefined : true
|
|
}}
|
|
options={{ right: 'Restart upon ending unless cancelled' }}
|
|
/>
|
|
</Section>
|
|
|
|
<Section label="Dedicated workers" eeOnly>
|
|
{#snippet header()}
|
|
<Tooltip documentationLink="https://www.windmill.dev/docs/core_concepts/dedicated_workers">
|
|
In this mode, the script is meant to be run on dedicated workers that run the script at
|
|
native speed. Can reach >1500rps per dedicated worker. Only available on enterprise
|
|
edition and for Python3, Deno, Bun and Bunnative.
|
|
</Tooltip>
|
|
{/snippet}
|
|
<Toggle
|
|
disabled={!$enterpriseLicense ||
|
|
isCloudHosted() ||
|
|
(script.language != 'bun' &&
|
|
script.language != 'bunnative' &&
|
|
script.language != 'python3' &&
|
|
script.language != 'deno')}
|
|
size="sm"
|
|
checked={Boolean(script.dedicated_worker)}
|
|
on:change={() => {
|
|
script.dedicated_worker = script.dedicated_worker ? undefined : true
|
|
}}
|
|
options={{ right: 'Script is run on dedicated workers' }}
|
|
/>
|
|
{#if script.dedicated_worker}
|
|
<div class="py-2">
|
|
<Alert type="info" title="Require dedicated workers">
|
|
A worker group needs to be configured to listen to this script. Select it in the dedicated
|
|
workers section of the worker group configuration.
|
|
</Alert>
|
|
</div>
|
|
{/if}
|
|
</Section>
|
|
|
|
<Section label="Delete after completion" eeOnly>
|
|
{#snippet header()}
|
|
<Tooltip
|
|
documentationLink="https://www.windmill.dev/docs/script_editor/settings#delete-after-use"
|
|
>
|
|
The logs, arguments and results of the job will be completely deleted from Windmill after
|
|
the specified delay once it is complete. Set to 0 for immediate deletion. The deletion is
|
|
irreversible. This settings ONLY applies when the script is used within a flow or triggered
|
|
synchronously.
|
|
</Tooltip>
|
|
{/snippet}
|
|
<div class="flex gap-2 shrink flex-col">
|
|
<Toggle
|
|
disabled={!$enterpriseLicense}
|
|
size="sm"
|
|
checked={script.delete_after_secs != null}
|
|
on:change={() => {
|
|
script.delete_after_secs = script.delete_after_secs != null ? undefined : 0
|
|
}}
|
|
options={{ right: 'Delete logs, arguments and results after completion' }}
|
|
/>
|
|
{#if script.delete_after_secs != null}
|
|
<SecondsInput bind:seconds={script.delete_after_secs} disabled={!$enterpriseLicense} />
|
|
{/if}
|
|
</div>
|
|
</Section>
|
|
|
|
{#if !isCloudHosted()}
|
|
<Section label="High priority script" eeOnly>
|
|
{#snippet header()}
|
|
<Tooltip
|
|
documentationLink="https://www.windmill.dev/docs/core_concepts/jobs#high-priority-jobs"
|
|
>
|
|
Jobs from script labeled as high priority take precedence over the other jobs when in the
|
|
jobs queue.
|
|
{#if !$enterpriseLicense}This is a feature only available on enterprise edition.{/if}
|
|
</Tooltip>
|
|
{/snippet}
|
|
<Toggle
|
|
disabled={!$enterpriseLicense || isCloudHosted()}
|
|
size="sm"
|
|
checked={script.priority !== undefined && script.priority > 0}
|
|
on:change={() => {
|
|
script.priority = script.priority ? undefined : 100
|
|
}}
|
|
options={{ right: 'Label as high priority' }}
|
|
>
|
|
{#snippet right()}
|
|
<input
|
|
type="number"
|
|
class="!w-16 ml-4"
|
|
disabled={script.priority === undefined}
|
|
bind:value={script.priority}
|
|
onfocus={bubble('focus')}
|
|
onchange={() => {
|
|
if (script.priority && script.priority > 100) {
|
|
script.priority = 100
|
|
} else if (script.priority && script.priority < 0) {
|
|
script.priority = 0
|
|
}
|
|
}}
|
|
/>
|
|
{/snippet}
|
|
</Toggle>
|
|
</Section>
|
|
{/if}
|
|
</div>
|