mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-09-21 16:02:36 +00:00
Ruben Fiszelandwindmill-internal-app[bot]
e3e638f7f5
* fix: skip instance group members that are not email addresses * fix: keep provisioned members whose address only proper_email accepts * fix: judge instance group members by a mirror of the usr email constraint * fix: fold ascii only in the proper_email mirror, like the constraint * fix: let the database judge which instance group members usr will store * fix: cut a derived username to the column width so a long local part can be provisioned * chore: move the ee pin to the scim member doc fix * chore: update ee-repo-ref to 0780955effb657807d14f0eb503cba1d49cee007 This commit updates the EE repository reference after PR #801 was merged in windmill-ee-private. Previous ee-repo-ref: ee6452d489563204a98df883703f78d5e74cdd69 New ee-repo-ref: 0780955effb657807d14f0eb503cba1d49cee007 Automated by sync-ee-ref workflow. --------- Co-authored-by: windmill-internal-app[bot] <windmill-internal-app[bot]@users.noreply.github.com>
60 lines
2.1 KiB
Rust
60 lines
2.1 KiB
Rust
//! `usr_accepts_email` predicts whether `usr` will store an address by evaluating
|
|
//! `PROPER_EMAIL_PATTERN` in the database. It only stays right while that text matches the
|
|
//! `proper_email` constraint and the width matches the column: each sample below must be
|
|
//! stored by `usr` exactly when the check accepts it, and everything `VALID_EMAIL` accepts
|
|
//! within the width must be stored too.
|
|
|
|
use sqlx::{Pool, Postgres};
|
|
use windmill_common::users::{usr_accepts_email, EMAIL_COLUMN_MAX_LEN, VALID_EMAIL};
|
|
|
|
#[sqlx::test(migrations = "../migrations")]
|
|
async fn usr_accepts_email_agrees_with_the_constraint(db: Pool<Postgres>) -> anyhow::Result<()> {
|
|
let domain = "@example.com";
|
|
let widest = format!(
|
|
"{}{domain}",
|
|
"a".repeat(EMAIL_COLUMN_MAX_LEN - domain.len())
|
|
);
|
|
let too_wide = format!("a{widest}");
|
|
for email in [
|
|
"alice@example.com",
|
|
"Alice@Example.COM",
|
|
"alice.bob+tag@sub.example.co.uk",
|
|
"\"quoted\"@example.com",
|
|
"\"quoted local\"@example.com",
|
|
"alice@[192.168.0.1]",
|
|
widest.as_str(),
|
|
too_wide.as_str(),
|
|
"ef40ea04-1a9e-4a84-9e65-cb1baa81dfed",
|
|
// Unicode case folding would map the long s and the Kelvin sign into `[a-z]`.
|
|
"u\u{17f}er@example.com",
|
|
"alice@example\u{212a}.com",
|
|
"alice",
|
|
"alice@example",
|
|
"alice@@example.com",
|
|
"alice @example.com",
|
|
"alice@example.com\nbob@example.com",
|
|
"",
|
|
] {
|
|
let mut tx = db.begin().await?;
|
|
let stored = sqlx::query(
|
|
"INSERT INTO usr (workspace_id, username, email, is_admin, operator)
|
|
VALUES ('admins', 'probe', $1, false, false)",
|
|
)
|
|
.bind(email)
|
|
.execute(&mut *tx)
|
|
.await
|
|
.is_ok();
|
|
tx.rollback().await?;
|
|
|
|
assert_eq!(
|
|
stored,
|
|
usr_accepts_email(&db, email).await?,
|
|
"{email:?}: `usr` and usr_accepts_email disagree"
|
|
);
|
|
if VALID_EMAIL.is_match(email) && email.len() <= EMAIL_COLUMN_MAX_LEN {
|
|
assert!(stored, "{email:?}: VALID_EMAIL accepts what `usr` rejects");
|
|
}
|
|
}
|
|
Ok(())
|
|
}
|