mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-08-22 08:02:19 +00:00
bc119011ae
* refactor: extract windmill-api-scripts and windmill-api-users subcrates Split the monolithic windmill-api crate by extracting scripts.rs, flows.rs, users.rs, and users_oss.rs into dedicated subcrates. This reduces incremental rebuild times when editing these modules. Changes: - Create windmill-api-scripts crate (scripts.rs + flows.rs, ~4.3K lines) - Create windmill-api-users crate (users.rs + users_oss.rs, ~2.4K lines) - Move clear_schedule to windmill-queue (shared by scripts, flows, workspaces) - Move username utilities (VALID_USERNAME, INVALID_USERNAME_CHARS, generate_instance_wide_unique_username) to windmill-common/src/usernames.rs - Move COOKIE_DOMAIN, IS_SECURE, WithStarredInfoQuery, BulkDeleteRequest, WebhookShared to windmill-common for cross-crate access - Original files in windmill-api become thin stubs with pub use re-exports - EE-dependent route handlers remain in windmill-api (create_user, rename_user, set_password, reset_password, etc.) - Feature forwarding for enterprise, private, parquet, no_auth Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * refactor: extract windmill-api-workspaces subcrate (Step 3) Move workspaces.rs, workspaces_extra.rs, workspaces_oss.rs, and workspaces_ee.rs into a new windmill-api-workspaces crate (~7K lines). Routes that depend on windmill-api internals (AI copilot, teams, tarball export, critical alerts, stripe) remain in the windmill-api stub. The subcrate handles all other workspace management routes. Also moved send_email_if_possible to windmill-common/email_oss.rs to make it available across subcrates without circular deps. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * all * refactor: extract windmill-api-groups subcrate (groups.rs + folders.rs) Extract groups.rs (1,093 lines) and folders.rs (833 lines) into a new windmill-api-groups subcrate. Both modules had clean dependencies on already-extracted crates (windmill-api-auth, windmill-common, windmill-api-workspaces). Also removes unused re-exports of get_instance_username_or_create_pending and INVALID_USERNAME_CHARS from windmill-api/src/utils.rs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * refactor: add granular_acls.rs and folder_history.rs to windmill-api-groups Extract granular_acls.rs (395 lines) and folder_history.rs (68 lines) into the windmill-api-groups subcrate. Both modules only depend on already-extracted crates and belong to the same access-control domain as groups and folders. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: remove unused imports and dead code from subcrate extraction - Remove unused BASE_URL import from lib.rs - Remove workspaces_extra.rs and workspaces_oss.rs re-export stubs (no consumers in windmill-api) - Remove dead send_email_if_possible OSS stub (callers moved to windmill-api-users) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * all * chore: bust CI cargo cache for subcrate split Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: re-export BASE_URL for EE files that use crate::BASE_URL Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: forward no_auth feature to windmill-api-users, remove dead code - Add "windmill-api-users/no_auth" to windmill-api's no_auth feature so the login bypass in users.rs:1600 activates correctly - Remove dead send_email_if_possible from windmill-api-users/users_oss.rs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: re-enable cargo cache for backend tests Cache was disabled to bust stale entries from before subcrate split. Now that a clean build has run, re-enable for faster CI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: install mold+clang in CI workflows The .cargo/config.toml uses mold linker for x86_64-linux. Build scripts require linking even during cargo check. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: increase cargo test timeout to 30 min Exit code 143 (SIGTERM) means the 20-min timeout was hit during compilation without cache. Bump to 30 min as safety net. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: limit cargo build jobs to 4 to prevent OOM in CI Exit code 143 (SIGTERM) after 8 min = OOM kill during compilation. 8 parallel LLVM codegen jobs exhaust memory on ubicloud-standard-8. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
306 lines
9.5 KiB
Rust
306 lines
9.5 KiB
Rust
/*
|
|
* Author: Ruben Fiszel
|
|
* Copyright: Windmill Labs, Inc 2022
|
|
* This file and its contents are licensed under the AGPLv3 License.
|
|
* Please see the included NOTICE for copyright information and
|
|
* LICENSE-AGPL for a copy of the license.
|
|
*/
|
|
|
|
use axum::{body::Body, response::Response};
|
|
use serde::{Deserialize, Deserializer};
|
|
#[cfg(feature = "enterprise")]
|
|
use windmill_common::worker::CLOUD_HOSTED;
|
|
use windmill_common::{
|
|
error::{self},
|
|
DB,
|
|
};
|
|
|
|
pub use windmill_api_auth::{check_scopes, require_devops_role, require_super_admin};
|
|
|
|
#[cfg(feature = "enterprise")]
|
|
use windmill_common::error::JsonResult;
|
|
|
|
#[cfg(feature = "enterprise")]
|
|
use axum::Json;
|
|
|
|
pub use windmill_common::usernames::generate_instance_wide_unique_username;
|
|
pub use windmill_common::utils::WithStarredInfoQuery;
|
|
|
|
pub async fn generate_instance_username_for_all_users(db: &DB) -> error::Result<()> {
|
|
let mut tx = db.begin().await?;
|
|
// get users that have a no instance username and either 1 or 0 workspace usernames
|
|
let users = sqlx::query!(r#"SELECT p.email as "email!", u.username as "username?" FROM password p LEFT JOIN usr u ON p.email = u.email WHERE p.username IS NULL AND (SELECT COUNT(DISTINCT username) FROM usr WHERE email = p.email) <= 1"#)
|
|
.fetch_all(&mut *tx)
|
|
.await?;
|
|
|
|
for user in users {
|
|
let username = if let Some(username) = user.username {
|
|
// if has workspace username, check that username is unique
|
|
let username_conflict = sqlx::query_scalar!(
|
|
"SELECT EXISTS(SELECT 1 FROM usr WHERE username = $1 and email != $2 UNION SELECT 1 FROM password WHERE username = $1 UNION SELECT 1 FROM pending_user WHERE username = $1)",
|
|
&username,
|
|
&user.email
|
|
).fetch_one(&mut *tx).await?.unwrap_or(false);
|
|
|
|
if !username_conflict {
|
|
username
|
|
} else {
|
|
generate_instance_wide_unique_username(&mut tx, &user.email).await?
|
|
}
|
|
} else {
|
|
generate_instance_wide_unique_username(&mut tx, &user.email).await?
|
|
};
|
|
|
|
sqlx::query!(
|
|
"UPDATE password SET username = $1 WHERE email = $2",
|
|
&username,
|
|
&user.email
|
|
)
|
|
.execute(&mut *tx)
|
|
.await?;
|
|
}
|
|
|
|
tx.commit().await?;
|
|
Ok(())
|
|
}
|
|
|
|
pub fn content_plain(body: Body) -> Response {
|
|
use axum::http::header;
|
|
Response::builder()
|
|
.header(header::CONTENT_TYPE, "text/plain")
|
|
.body(body)
|
|
.unwrap()
|
|
}
|
|
|
|
#[allow(unused)]
|
|
pub fn non_empty_str<'de, D>(deserializer: D) -> Result<Option<String>, D::Error>
|
|
where
|
|
D: Deserializer<'de>,
|
|
{
|
|
let o: Option<String> = Option::deserialize(deserializer)?;
|
|
Ok(o.filter(|s| !s.trim().is_empty()))
|
|
}
|
|
|
|
#[cfg(feature = "enterprise")]
|
|
#[derive(serde::Serialize)]
|
|
pub struct CriticalAlert {
|
|
id: i32,
|
|
alert_type: String,
|
|
message: String,
|
|
created_at: chrono::DateTime<chrono::Utc>,
|
|
acknowledged: Option<bool>,
|
|
workspace_id: Option<String>,
|
|
}
|
|
|
|
#[cfg(feature = "enterprise")]
|
|
#[derive(Deserialize, Debug)]
|
|
pub struct AlertQueryParams {
|
|
pub page: Option<i32>,
|
|
pub page_size: Option<i32>,
|
|
pub acknowledged: Option<bool>,
|
|
}
|
|
|
|
#[cfg(feature = "enterprise")]
|
|
pub async fn get_critical_alerts(
|
|
db: DB,
|
|
params: AlertQueryParams,
|
|
workspace_id: Option<String>,
|
|
) -> JsonResult<serde_json::Value> {
|
|
// Returning total rows and total pages
|
|
let page = params.page.unwrap_or(1).max(1);
|
|
let page_size = params.page_size.unwrap_or(10).min(100) as i64;
|
|
let offset = ((page - 1) * page_size as i32) as i64;
|
|
|
|
// Count total rows
|
|
let total_rows = if let Some(workspace_id) = &workspace_id {
|
|
if params.acknowledged.is_none() {
|
|
sqlx::query_scalar!(
|
|
"SELECT COUNT(*)
|
|
FROM alerts
|
|
WHERE workspace_id = $1",
|
|
workspace_id
|
|
)
|
|
.fetch_one(&db)
|
|
.await?
|
|
} else {
|
|
sqlx::query_scalar!(
|
|
"SELECT COUNT(*)
|
|
FROM alerts
|
|
WHERE workspace_id = $1 AND COALESCE(acknowledged_workspace, false) = $2",
|
|
workspace_id,
|
|
params.acknowledged
|
|
)
|
|
.fetch_one(&db)
|
|
.await?
|
|
}
|
|
} else {
|
|
if params.acknowledged.is_none() {
|
|
sqlx::query_scalar!(
|
|
"SELECT COUNT(*)
|
|
FROM alerts"
|
|
)
|
|
.fetch_one(&db)
|
|
.await?
|
|
} else {
|
|
sqlx::query_scalar!(
|
|
"SELECT COUNT(*)
|
|
FROM alerts
|
|
WHERE COALESCE(acknowledged, false) = $1",
|
|
params.acknowledged
|
|
)
|
|
.fetch_one(&db)
|
|
.await?
|
|
}
|
|
};
|
|
|
|
// Fetch paginated rows
|
|
let alerts = if let Some(workspace_id) = workspace_id {
|
|
// `workspace_id` is provided => workspace admin
|
|
if params.acknowledged.is_none() {
|
|
// Case: return all rows where `workspace_id` matches
|
|
sqlx::query_as!(
|
|
CriticalAlert,
|
|
"SELECT id, alert_type, message, created_at, COALESCE(acknowledged_workspace, false) AS acknowledged, workspace_id
|
|
FROM alerts
|
|
WHERE workspace_id = $1
|
|
ORDER BY created_at DESC
|
|
LIMIT $2 OFFSET $3",
|
|
workspace_id,
|
|
page_size,
|
|
offset
|
|
)
|
|
.fetch_all(&db)
|
|
.await?
|
|
} else {
|
|
// Case: return rows where `acknowledged_workspace` matches `params.acknowledged`
|
|
sqlx::query_as!(
|
|
CriticalAlert,
|
|
"SELECT id, alert_type, message, created_at, COALESCE(acknowledged_workspace, false) AS acknowledged, workspace_id
|
|
FROM alerts
|
|
WHERE workspace_id = $1 AND COALESCE(acknowledged_workspace, false) = $2
|
|
ORDER BY created_at DESC
|
|
LIMIT $3 OFFSET $4",
|
|
workspace_id,
|
|
params.acknowledged,
|
|
page_size,
|
|
offset
|
|
)
|
|
.fetch_all(&db)
|
|
.await?
|
|
}
|
|
} else {
|
|
// `workspace_id` is not provided => superadmin
|
|
if params.acknowledged.is_none() {
|
|
// Case: Return all rows unfiltered with global acknowledged as acknowledged
|
|
sqlx::query_as!(
|
|
CriticalAlert,
|
|
"SELECT id, alert_type, message, created_at, COALESCE(acknowledged, false) AS acknowledged, workspace_id
|
|
FROM alerts
|
|
ORDER BY created_at DESC
|
|
LIMIT $1 OFFSET $2",
|
|
page_size,
|
|
offset
|
|
)
|
|
.fetch_all(&db)
|
|
.await?
|
|
} else {
|
|
// Case: Return rows where global acknowledged matches params.acknowledged
|
|
sqlx::query_as!(
|
|
CriticalAlert,
|
|
"SELECT id, alert_type, message, created_at, COALESCE(acknowledged, false) AS acknowledged, workspace_id
|
|
FROM alerts
|
|
WHERE COALESCE(acknowledged, false) = $1
|
|
ORDER BY created_at DESC
|
|
LIMIT $2 OFFSET $3",
|
|
params.acknowledged,
|
|
page_size,
|
|
offset
|
|
)
|
|
.fetch_all(&db)
|
|
.await?
|
|
}
|
|
};
|
|
|
|
let total_rows = total_rows.unwrap_or(0);
|
|
let total_pages = ((total_rows as f64) / (page_size as f64)).ceil() as i64;
|
|
|
|
Ok(Json(serde_json::json!({
|
|
"alerts": alerts,
|
|
"total_rows": total_rows,
|
|
"total_pages": total_pages
|
|
})))
|
|
}
|
|
|
|
#[cfg(feature = "enterprise")]
|
|
pub async fn acknowledge_critical_alert(
|
|
db: DB,
|
|
workspace_id: Option<String>,
|
|
id: i32,
|
|
) -> error::Result<String> {
|
|
sqlx::query!(
|
|
"UPDATE alerts
|
|
SET
|
|
acknowledged = true,
|
|
acknowledged_workspace = CASE
|
|
WHEN $3 THEN
|
|
CASE
|
|
WHEN $2::text IS NOT NULL AND workspace_id = $2 THEN true
|
|
ELSE acknowledged_workspace
|
|
END
|
|
ELSE true
|
|
END
|
|
WHERE id = $1",
|
|
id,
|
|
workspace_id,
|
|
*CLOUD_HOSTED
|
|
)
|
|
.execute(&db)
|
|
.await?;
|
|
|
|
tracing::info!(
|
|
"Acknowledged critical alert with id: {}{}",
|
|
id,
|
|
workspace_id.map_or_else(|| "".to_string(), |w| format!(" for workspace_id: {}", w))
|
|
);
|
|
Ok("Critical alert acknowledged".to_string())
|
|
}
|
|
|
|
#[cfg(feature = "enterprise")]
|
|
pub async fn acknowledge_all_critical_alerts(
|
|
db: DB,
|
|
workspace_id: Option<String>,
|
|
) -> error::Result<String> {
|
|
sqlx::query!(
|
|
"UPDATE alerts
|
|
SET
|
|
acknowledged = true,
|
|
acknowledged_workspace = CASE
|
|
WHEN $2 THEN
|
|
CASE
|
|
WHEN $1::text IS NOT NULL THEN true
|
|
ELSE acknowledged_workspace
|
|
END
|
|
ELSE true
|
|
END
|
|
WHERE ($1::text IS NOT NULL AND workspace_id = $1)
|
|
OR ($1::text IS NULL)",
|
|
workspace_id,
|
|
*CLOUD_HOSTED
|
|
)
|
|
.execute(&db)
|
|
.await?;
|
|
|
|
tracing::info!(
|
|
"Acknowledged all unacknowledged critical alerts{}",
|
|
workspace_id.map_or_else(|| "".to_string(), |w| format!(" for workspace_id: {}", w))
|
|
);
|
|
Ok("All unacknowledged critical alerts acknowledged".to_string())
|
|
}
|
|
|
|
#[cfg(feature = "http_trigger")]
|
|
pub use windmill_common::utils::ExpiringCacheEntry;
|
|
|
|
lazy_static::lazy_static! {
|
|
static ref DUCKLAKE_INSTANCE_PG_PASSWORD: std::sync::RwLock<Option<String>> = std::sync::RwLock::new(None);
|
|
}
|