mirror of https://github.com/windmill-labs/windmill.git synced 2026-08-20 16:02:19 +00:00

Files

T

Guilhem c7ec33cc9f feat: rework the resource type list in the add-resource drawer (#10757 )

* feat: rework the add-resource drawer list

The resource type picker in the "Add a resource" drawer showed 273 types as
bordered chips in three columns, labelled by their raw type name with the
description hidden in search text only.

Rows now carry the product name, the type name, and its description, and the
list is searchable and keyboard-drivable.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix: address local review nits on the resource list

- keep DOM focus on the highlighted row when arrow keys move it from a
  focused row, so Enter never activates a different row than the lit one
- ignore the `mouseenter` the browser fires when rows scroll under a
  stationary pointer, which dragged the highlight back mid-navigation
- namespace the OAuth rows' aiId: a provider is listed in both sections,
  and triggerableByAI keys a single map by id
- seed the custom-type set from the names call, so the section survives
  the full resource-type list 403ing on a public app domain
- drop resourceTypeLabel, whose last caller now uses the display name
- read a leading acronym as letters when picking a/an ("an S3 resource")
- test resourceTypeDisplayName directly

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* feat: scroll the resource list on its own, and report search results

- the drawer no longer scrolls: step 1 is a full-height column with the
  search field and the sync button fixed, and only the rows scrolling.
  This drops the sticky search bar and the scroll-margin the rows needed
  to clear it
- searching shows a per-section count, hides the sections it empties,
  and states plainly when nothing matched at all
- section spacing moved onto the column's gap, so a section a search
  empties takes its spacing with it instead of leaving a hole

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix: address review-round nits on the resource list

- one definition of "a search is active": a whitespace-only query kept
  the browse ordering but still ranked, dropped the database grouping
  and highlighted row 0
- "a NATS resource": the acronym rule reads initials as letters, which
  is wrong for an all-caps name said as a word
- give the lightweight picker's wrapper a height, so the step-1 list
  fills it the way it fills the drawer

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix: drop the article from the add-resource title

Whether a label takes "a" or "an" follows how it is said, and the
spelling does not carry that: "an S3" but "a NATS", "an MCP" but "a
REST", "a URL" but "an hour". Three review rounds each found another
name the rule got wrong, so the title now names the type without an
article.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

2026-08-19 16:42:12 +02:00