mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-09-10 00:05:27 +00:00
* feat: responsive modal step panel for the flow editor in sessions On narrow layouts the flow editor's step-details pane opens as a modal (double-click a graph node) instead of a split pane, with a dock/float toggle. Scoped to sessions via allowModalPanel; the full-page editor is unchanged. - FlowEditor: modal/docked modes gated by mount width + allowModalPanel, small header (step-id Badge + subtle dock/close), standing double-click hint, and a per-step hint in the name tooltip - selectionManager: onSelectIntent hook so flow-level panels (settings, input, triggers…) open the modal on single click - PropPickerWrapper: collapse the prop picker until connect and animate it in via AnimatedPane (runs-page pattern), no blue connect ring in modal mode - StepInputGen: drop the TAB/Wand autocompletion button + spinner (feature still works via focus + Tab) - InputTransformForm: decouple the Help dropdown from the AI suggestion - FlowModuleHeader: move 'Save to workspace' into an ellipsis dropdown Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix: loop editor rendering and nested splitpanes splitters in the sessions modal - Loop iterator/parallelism: keep the picker split pane (forceExpanded) so the editor fills its box and the picker shows; the collapse-until-connect mode stays for the step inputs - Remove the intrusive AI TAB/Wand autocompletion button from IteratorGen (generation still runs headless via focus + Tab) - Size the iterator connect plug and restyle the loop header/labels/toggles - Scope the global `.splitter-hidden` splitter-hiding rule to direct children so it no longer leaks into nested Splitpanes under the sessions preview Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat: redesign flow step advanced settings as a single toggle-first column Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat: taller step test pane by default and restyle advanced section titles Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat: show flow run-settings params disabled when a setting is toggled off Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat: single-column for-loop panel reusing the run-settings accordion Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat: single-column while-loop panel reusing the run-settings accordion Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat: single-column branch panels reusing the run-settings accordion Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix: auto-open modal panel when creating an AI agent tool Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat: redesign branch panels with card layout and shared predicate editor Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor: remove per-setting status badges from flow map nodes Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore: sync package-lock after windmill-utils-internal bump Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * style: polish prop-picker plug button and branch panel layouts * fix: persist skip-if-stopped toggles in early stop settings * fix: open the step panel modal on demand and cap its width * fix: restore graph step setting badges, strip panel header chips instead * feat: docked panel header with detach action and open-details step menu * feat: width-based panel mode on every surface with inline detach action * refactor: single source for flow step settings and their defaults * docs: pin flow editor vocabulary in CONTEXT.md * fix: open the trigger panel on double click or a specific trigger * fix: keep module pickers inside their pane and dismissable * fix: drop the misleading chevron on the MCP tool entry * fix: resolve flow approvals against the job's workspace, not the nav one * refactor: derive the approval workspace from the job, not from callers * fix: restore S3 snippets and gate params while their setting is off * fix: restore branch mock controls and address review findings * chore: drop stray debug log from the flow map item * feat: pinned output section for loop and branch panels * fix: open the panel for deliberate navigation from the flow header * perf: mount branch predicate editors on demand * fix: skip predicate picker previews the previous step's result * fix: flow-level graph nodes open their panel on a single click * fix: open the step panel for AI chat selections, not for undo * chore: drop dead console.log and duplicated modalPanel doc * fix: re-sync expression editors and scope error-handler settings * fix: match the failure module exactly and ignore unselectable nodes * fix: keep concurrency editable, honour module cache_ttl, tighten panel ids * fix: open panel from indirect selections, use presence for value-driven toggles * fix: don't open settings on error-handler delete, flush editors on unmount * fix: guard editor destroy flush, keep retry kind reachable * refactor: name the run settings panel after the domain vocabulary * fix: only write editor flushes to the step they belong to * fix: bind step panels by id so a delete can't retarget editor writes * fix: don't let the trigger picker's escape close the drawer beneath it * docs: condense two comments to the constraint they record * fix: arbitrate escape through the overlay stack instead of deferring to it * fix: key nested step blocks by identity so anchored bindings can't go stale * fix: untrack the overlay-stack push and drop the frozen branch binding * chore: state the escape rationale once, key branch lists, format * fix: let the topmost overlay own escape instead of the graph * fix: keep the dynamic-input help box out of static template fields * fix: restore the graph connect on the for-loop iterator * fix: end connect mode with the modal and keep it to docked panels * fix: never enter graph connect mode from the modal panel * fix: reveal inserted steps, restore editor pane size, unleak the drawer stack * fix: keep the enable-AI popover reachable in session panes * feat: add the connect policy and its single armed slot * refactor: one picker for every expression input * refactor: route every connect through one armed slot * fix: give every connect button the same footprint * fix: keep the connect ring from showing through the button * fix: keep flow card actions right-aligned beside the detach button * fix: give the connect ring an opaque ground to mask against * feat: dock the panel back without reopening it * feat: dock the panel from the graph control bar * style: round the graph control bar and size its glyphs * style: customize the graph controls through their supported api * style: build the graph control bar from lucide icons * fix: use the graph's tooltip component in the zoom controls * style: pad the graph controls and enlarge their glyphs * style: pad the graph controls and put dock at the bar's end * refactor: give settings rows the same popover picker as other expressions * fix: pass the wrapper's pickable properties to nested inputs * refactor: stack step settings and render every expression through the step input form * feat: split loop panels into tabs and rework the approval form * feat: anchor drawers to their host pane and give them a size floor * fix: mark the loop iterator expression as required * refactor: badge ee-only toggles instead of a warning line * fix: flag an empty loop iterator expression as an error * refactor: pick the early-stop flow status from one toggle group * fix: keep parallel loops uncapped unless a limit is opted into * fix: scope the overlay stack to its host and disarm connect on dismissal * fix: anchor the trigger picker to its host pane * feat: move diff into the menu when the top bar is narrow * fix: gate the result logs toggle to the graph popover * feat: raise the modal-panel breakpoint to 1280 * fix: anchor flow editor popovers and fullscreen to their host pane * fix: anchor overlays to their host pane and mute them when hidden * fix: portal hosted modals and menus into the pane they anchor to * fix: keep non-listening dialogs off the overlay stack * fix: drop the topmost gate from confirmation dialogs * fix: silence overlays in a collapsed preview panel * feat: rework the branch panels with tabs, reordering and add/delete * refactor: fold the detached-panel chrome into the card header * fix: give every flow panel a titled card header * fix: stop the step panel oscillating on an auto-height editor * feat: consolidate script panel actions and restore branch predicate AI * fix: restore the logs toggle on the flow result popover * fix: collapse the idle property picker in modal step panels * fix: stop the docked pane scrolling alongside its panel * fix: space the last settings row off the panel bottom * revert: always show the property picker pane in step panels * chore: keep the inline script AI button identical to main * fix: ask for AI input suggestions on click, not on hover * fix: keep graph connects armed and remount the parallelism input * style: reveal the predicate AI button on row hover * style: give branch cards a handle and delete column * refactor: arbitrate flow overlay escape through Disposable * fix: give the popover picker its results and re-narrow the EE badge * docs: correct loopSubset and guard the modal width measurement * fix: insert picked properties at the cursor in expression inputs * fix: give the expanded-subflow panel the shared header chrome * style: rename the suspend setting to Suspend until approval/resume * feat: open a step's modal when clicking the step already selected * feat: add an auto/attached/detached toggle for the step panel * refactor: pick the step panel's placement from one named menu * refactor: keep the panel-mode module's exports to what is consumed * feat: show each configured setting's value on its badge * fix: carry the suspend rename into the step settings registry * docs: name both gestures in the step explore hint * test: pin where the step panel goes for a given width and preference --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
168 lines
4.9 KiB
Svelte
168 lines
4.9 KiB
Svelte
<script lang="ts">
|
|
import { mergeSchema } from '$lib/common'
|
|
import { type Job, JobService } from '$lib/gen'
|
|
import { sendUserToast } from '$lib/toast'
|
|
import { ExternalLink, X } from 'lucide-svelte'
|
|
import DisplayResult from './DisplayResult.svelte'
|
|
import Tooltip from './Tooltip.svelte'
|
|
import { Button } from './common'
|
|
import SchemaForm from './SchemaForm.svelte'
|
|
import { twMerge } from 'tailwind-merge'
|
|
import { untrack } from 'svelte'
|
|
import { isReplaying } from './recording/offlineReplay.svelte'
|
|
|
|
interface Props {
|
|
isOwner: boolean
|
|
/** The workspace the job ran in — pass `job.workspace_id`, never the navigation
|
|
* workspace, which differs whenever the editor is embedded. */
|
|
workspaceId: string | undefined
|
|
job: Job
|
|
light?: boolean
|
|
/** Fired after a successful resume/reject, before the next poll observes it —
|
|
* lets a host (e.g. the AI chat jobs tray) close its modal optimistically. */
|
|
onAction?: (approved: boolean) => void
|
|
}
|
|
|
|
let { isOwner: _isOwner, workspaceId, job, light = false, onAction }: Props = $props()
|
|
|
|
let default_payload: object = $state({})
|
|
let description: any = $state(undefined)
|
|
let hide_cancel = $state(false)
|
|
let approvalPageUrl: string | undefined = $state(undefined)
|
|
|
|
let defaultValues = $state({})
|
|
|
|
let schema = $state({})
|
|
let lastJobId: string | undefined = undefined
|
|
async function getDefaultArgs() {
|
|
let jobId = job?.flow_status?.modules?.[approvalStep]?.job
|
|
|
|
if (jobId === lastJobId) {
|
|
return
|
|
}
|
|
if (!jobId || !workspaceId) {
|
|
return {}
|
|
}
|
|
lastJobId = jobId
|
|
let job_result = (await JobService.getCompletedJobResult({
|
|
workspace: workspaceId,
|
|
id: jobId
|
|
})) as any
|
|
const args = job_result?.default_args ?? {}
|
|
description = job_result?.description
|
|
defaultValues = JSON.parse(JSON.stringify(args))
|
|
default_payload = args
|
|
|
|
approvalPageUrl = job_result?.['approvalPage']
|
|
actionTaken = false
|
|
hide_cancel = job?.raw_flow?.modules?.[approvalStep]?.suspend?.hide_cancel ?? false
|
|
schema = mergeSchema(
|
|
job?.raw_flow?.modules?.[approvalStep]?.suspend?.resume_form?.schema ?? {},
|
|
job_result?.enums ?? {}
|
|
)
|
|
}
|
|
|
|
let loading = $state(false)
|
|
let actionTaken = $state(false)
|
|
async function continu(approve: boolean) {
|
|
if (!workspaceId) {
|
|
sendUserToast('Cannot resume: the job has no workspace', true)
|
|
return
|
|
}
|
|
loading = true
|
|
try {
|
|
await JobService.resumeSuspended({
|
|
workspace: workspaceId,
|
|
jobId: job?.id ?? '',
|
|
requestBody: {
|
|
payload: approve ? (default_payload as any) : undefined,
|
|
approved: approve
|
|
}
|
|
})
|
|
actionTaken = true
|
|
onAction?.(approve)
|
|
} catch (e: any) {
|
|
sendUserToast(e?.body ?? e?.message ?? 'Failed', true)
|
|
} finally {
|
|
loading = false
|
|
}
|
|
}
|
|
let approvalStep = $derived((job?.flow_status?.step ?? 1) - 1)
|
|
// Everything this panel shows (description, resume form enums, approval page) is
|
|
// fetched from the suspended job — a recording carries none of it — and Resume /
|
|
// Cancel act on a job that only exists in the recording. So a replay states the
|
|
// recorded fact and offers nothing to click.
|
|
let replaying = $derived(isReplaying())
|
|
$effect(() => {
|
|
if (!replaying) {
|
|
job && untrack(() => getDefaultArgs())
|
|
}
|
|
})
|
|
</script>
|
|
|
|
{#if replaying}
|
|
<div class="w-full text-xs text-secondary">This step was waiting for approval.</div>
|
|
{:else}
|
|
<div class="w-full h-full text-xs text-primary">
|
|
{#if description != undefined}
|
|
<DisplayResult {workspaceId} noControls result={description} language={job?.language} />
|
|
<div class="mt-2"></div>
|
|
{/if}
|
|
<div>
|
|
<div class={twMerge('flex gap-2 items-center', light ? 'flex-col' : 'flex-row ')}>
|
|
{#if !hide_cancel}
|
|
<div>
|
|
<Button
|
|
title="Cancel the step"
|
|
iconOnly
|
|
startIcon={{ icon: X }}
|
|
variant="default"
|
|
disabled={loading || actionTaken}
|
|
destructive
|
|
unifiedSize="md"
|
|
on:click={() => continu(false)}
|
|
/>
|
|
</div>
|
|
{/if}
|
|
<div>
|
|
<Button
|
|
variant="accent"
|
|
onClick={() => continu(true)}
|
|
disabled={loading || actionTaken}
|
|
unifiedSize="md"
|
|
>
|
|
Resume
|
|
<Tooltip class="text-white">Resume or approve this suspended step</Tooltip>
|
|
</Button>
|
|
</div>
|
|
|
|
{#if approvalPageUrl}
|
|
<a
|
|
href={approvalPageUrl}
|
|
target="_blank"
|
|
rel="noreferrer"
|
|
class="text-accent flex items-center gap-1 whitespace-nowrap"
|
|
>
|
|
Approval page <ExternalLink size={12} />
|
|
</a>
|
|
{/if}
|
|
|
|
{#if job?.raw_flow?.modules?.[approvalStep]?.suspend?.resume_form?.schema}
|
|
<div
|
|
class={twMerge(
|
|
'w-full border rounded-lg p-2',
|
|
light ? 'min-w-96 max-h-svh overflow-y-auto' : ''
|
|
)}
|
|
>
|
|
<SchemaForm onlyMaskPassword bind:args={default_payload} {defaultValues} {schema} />
|
|
</div>
|
|
<Tooltip>
|
|
The payload is optional, it is passed to the following step through the `resume`
|
|
variable
|
|
</Tooltip>
|
|
{/if}
|
|
</div>
|
|
</div>
|
|
</div>
|
|
{/if}
|