mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-10-14 00:02:55 +00:00
Diego ImbertandClaude Opus 5
67c1faed53
The resource save read its snapshot back out of the live form after the request returned, so the "did anything change meanwhile" test compared the edit against itself and always said no — the mid-request edit became the deployed baseline instead. Its payloads, its submitted path and the schedule's config are now all pinned before the first await, which also makes the schedule's test see edits to `args`, `retry` and `labels` rather than only its scalar fields. The three copies of the settling rule become `settleDraftAfterWrite`. A save that moved the item resets the cell rather than keeping a diverged one: the edit cannot follow — a freshly acquired cell reads only its own default — and the alternative is a draft stranded under a path the item no longer occupies. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KcyBRxE8j3ujCYkum9KrC4
79 lines
2.3 KiB
TypeScript
79 lines
2.3 KiB
TypeScript
import { describe, it, expect, beforeEach, vi } from 'vitest'
|
|
|
|
const discard = vi.fn()
|
|
vi.mock('./gen', () => ({ DraftService: { updateDraft: vi.fn() } }))
|
|
vi.mock('./gen/core/OpenAPI', () => ({ OpenAPI: { BASE: '' } }))
|
|
vi.mock('./localDraftHints.svelte', () => ({ setLocalDraftHint: vi.fn() }))
|
|
|
|
import { settleDraftAfterWrite, UserDraft } from './userDraft.svelte'
|
|
|
|
beforeEach(() => {
|
|
discard.mockClear()
|
|
vi.spyOn(UserDraft, 'discard').mockImplementation(discard as any)
|
|
})
|
|
|
|
const OPTS = { workspace: 'ws' }
|
|
const sent = { path: 'u/me/a', value: 'sent' }
|
|
|
|
/**
|
|
* The forms stay editable while their save is in flight, so the cell can hold a
|
|
* newer edit by the time the write returns. Resetting it unconditionally — what
|
|
* every editor did — swallows that edit with no trace.
|
|
*/
|
|
describe('settleDraftAfterWrite', () => {
|
|
it('resets the cell when it still holds what was written', () => {
|
|
settleDraftAfterWrite('variable', sent, { ...sent }, 'u/me/a', 'u/me/a', OPTS)
|
|
expect(discard).toHaveBeenCalledWith('variable', 'u/me/a', sent, OPTS)
|
|
})
|
|
|
|
it('keeps an edit made while the write was in flight', () => {
|
|
settleDraftAfterWrite(
|
|
'variable',
|
|
sent,
|
|
{ path: 'u/me/a', value: 'typed' },
|
|
'u/me/a',
|
|
'u/me/a',
|
|
OPTS
|
|
)
|
|
expect(discard).not.toHaveBeenCalled()
|
|
})
|
|
|
|
// A renamed save is the exception: a freshly acquired cell reads only its own
|
|
// default, so the edit cannot follow the item and the alternative to resetting
|
|
// is an orphan draft under a path the item no longer occupies.
|
|
it('resets even a diverged cell when the write moved the item', () => {
|
|
settleDraftAfterWrite(
|
|
'variable',
|
|
sent,
|
|
{ path: 'u/me/a', value: 'typed' },
|
|
'u/me/a',
|
|
'u/me/b',
|
|
OPTS
|
|
)
|
|
expect(discard).toHaveBeenCalledWith('variable', 'u/me/a', sent, OPTS)
|
|
})
|
|
|
|
it('compares through the draft normalization, so a nested edit is not missed', () => {
|
|
const written = { path: 'u/me/a', args: { host: 'h' } }
|
|
settleDraftAfterWrite(
|
|
'resource',
|
|
written,
|
|
{ path: 'u/me/a', args: { host: 'h' } },
|
|
'u/me/a',
|
|
'u/me/a',
|
|
OPTS
|
|
)
|
|
expect(discard).toHaveBeenCalledTimes(1)
|
|
discard.mockClear()
|
|
settleDraftAfterWrite(
|
|
'resource',
|
|
written,
|
|
{ path: 'u/me/a', args: { host: 'edited' } },
|
|
'u/me/a',
|
|
'u/me/a',
|
|
OPTS
|
|
)
|
|
expect(discard).not.toHaveBeenCalled()
|
|
})
|
|
})
|