mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-09-05 16:03:47 +00:00
Address review findings: - [P1] Claim and accumulated-args persist are now in one transaction. Before, a crash between stamping batch rows consumed_by=self and the `UPDATE v2_job SET args` could let a zombie re-pull see its own prior claim and keep only its own args (dropping the siblings it had claimed). Wrapping claim + accumulate + persist in a tx makes them commit together or roll back together (re-pull then re-claims cleanly). - [P1] GC of consumed batch rows now also requires the job to no longer be in v2_job_queue. A consumed sibling can stay queued well past any time grace under a concurrency limit / backlog; reclaiming its marker by age alone let its eventual pull treat it as never-batched and re-run its item (a duplicate). Keeping the row until the job leaves the queue preserves the "already consumed" signal. Test extended with a still-queued consumed row that must survive GC. - [P2] Drop "Customer" attribution from a test doc comment (AGENTS.md). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>