mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-08-18 16:02:10 +00:00
a22d179903
* feat(cli): add GitHub Actions CI and raw app sync tests - Add CLI tests GitHub Action that runs on Linux and Windows - Add build check job that runs on CLI and openapi.yaml changes - Uses Rust cargo backend instead of Docker for better CI compatibility - Add cargo_backend.ts and test_backend.ts for test infrastructure - Fix Windows path separator bug in raw_apps.ts (use "/" for relative paths) - Fix PostgreSQL URL parsing in cargo_backend.ts - Update tests to use gitBranches format instead of deprecated overrides - Add raw_app_sync.test.ts for raw app sync workflow testing (ignored for now - needs EE) - Skip tests that require EE features (git sync settings, raw apps) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(cli): Fix Windows path compatibility issues in tests - Use fromFileUrl() in cargo_backend.ts for proper Windows path handling - Normalize path separators to forward slashes in resource_folders.ts - Fix readDirRecursive to return normalized paths in test helper - Use forward slashes consistently in buildMetadataPath and detection functions Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(cli): Use SEP in test assertions instead of modifying logic - Revert resource_folders.ts to use SEP as intended - Update test assertions to use SEP for platform-specific paths - Keep readDirRecursive normalization for consistent test comparisons Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(cli): Use SEP for all path separators in test assertions Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(cli): Use resolve() for proper cross-platform path handling in cargo_backend String concatenation with path separators creates malformed paths on Windows. Use path.resolve() instead for proper cross-platform path resolution. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(backend): Add cfg attributes for Windows compatibility - Add #[cfg(unix)] to anyhow::anyhow import (only used in unix cfg block) - Add #[cfg(not(windows))] to parse_file function (uses cat, only for cgroups) - Remove unused std::io import, use std::io::Result directly Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: Windows compilation + convert integration tests to withTestBackend - Fix unused import SYSTEM_ROOT in csharp_executor.rs on Windows by requiring both windows and csharp feature - Fix unused variable id in handle_child.rs on Windows by adding #[allow(unused_variables)] since id is only used in cfg(unix) code - Convert all RUN_INTEGRATION_TESTS dependent tests in sync_pull_push.test.ts to use withTestBackend pattern for automatic backend setup Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat: configurable test features with CI_MINIMAL_FEATURES env var - Default: full features (zip, private, enterprise) for local development - CI mode: minimal features (zip only) when CI_MINIMAL_FEATURES=true - Add shouldSkipOnCI() helper for tests requiring EE features - Update EE-dependent tests to use shouldSkipOnCI() - Add test instructions to cli/README.md Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: enable raw app tests (not EE-dependent) Raw apps work with minimal features. 2 tests pass, 2 have test logic bugs to investigate separately: - "delete file and push" - file deletion not syncing correctly - "dry-run push shows expected changes" - JSON output parsing issue Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: gate cgroups module to Linux only cgroups are Linux-specific, the module was causing dead_code warnings on Windows compilation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(ci): add CI_MINIMAL_FEATURES env var to CLI tests workflow Set CI_MINIMAL_FEATURES=true in both Linux and Windows test jobs so the backend compiles with minimal features (zip only) and EE-dependent tests self-skip via shouldSkipOnCI(). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(cli): raw app tests and backend startup timing - Add 5s delay after backend ready for migrations to complete - Fix dry-run JSON output parsing (handle pretty-printed JSON) - Temporarily ignore "delete file" test (needs isSuperset fix) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(cli): raw app file deletion sync - Add deepEqual check for files in raw_apps.ts isSuperset comparison - Handle raw_app file deletions in sync.ts by re-pushing the entire app - Fix test to remove CSS import before deleting the file When deleting a file from a raw app, the sync now properly updates the backend with the new file list (excluding the deleted file). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(cli): Windows path separators in tests Normalize paths for cross-platform comparison by converting backslashes to forward slashes before path assertions. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(cli): normalize featurePaths in multi_instance_workspace test Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test(cli): add mixed case paths sync tests for Windows compatibility Add comprehensive tests for sync pull/push with capitalized folder paths to catch Windows case-insensitivity issues: - Scripts in f/MyFolder/MyScript - Flows in f/MyFlows/DataProcessor - Apps in f/MyApps/Dashboard - Variables in f/MyVars/ApiKey - Deeply nested paths with mixed case - Multiple resources in same capitalized folder - CamelCase folder names with numbers Each test verifies the full pull -> modify -> push -> verify cycle. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test(cli): add idempotency check to mixed case paths tests After each push, pull again with --dry-run --json-output and verify that no changes are detected. This ensures the sync is stable and catches issues where pull/push cycles cause spurious diffs. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
198 lines
7.6 KiB
TypeScript
198 lines
7.6 KiB
TypeScript
/**
|
|
* Test to verify that wmill init handles workspaces with no git-sync settings correctly
|
|
* This creates a unit test that directly tests the logic without needing a backend
|
|
*/
|
|
|
|
import { assertEquals, assertStringIncludes, assert } from "https://deno.land/std@0.224.0/assert/mod.ts";
|
|
import { DEFAULT_SYNC_OPTIONS } from "../src/core/conf.ts";
|
|
import { withTestBackend } from "./test_backend.ts";
|
|
import { shouldSkipOnCI } from "./cargo_backend.ts";
|
|
import { addWorkspace } from "../workspace.ts";
|
|
|
|
// Mock the workspace object
|
|
const mockWorkspace = {
|
|
remote: 'https://app.windmill.dev/',
|
|
workspaceId: 'test-workspace',
|
|
name: 'test-workspace'
|
|
};
|
|
|
|
// Simulate the createWorkspaceProfile function logic for the "no repositories" case
|
|
function createWorkspaceProfileNoRepos(workspace: any): any {
|
|
const workspaceProfile: any = {
|
|
baseUrl: workspace.remote,
|
|
workspaceId: workspace.workspaceId,
|
|
};
|
|
|
|
// Simulate the case where listRepositories returns empty array
|
|
const repositories: any[] = [];
|
|
|
|
if (repositories.length === 0) {
|
|
console.log(`No git repositories found in workspace '${workspace.workspaceId}'`);
|
|
// This is the fix: include default sync settings when no repositories exist
|
|
Object.assign(workspaceProfile, DEFAULT_SYNC_OPTIONS);
|
|
return workspaceProfile;
|
|
}
|
|
|
|
return workspaceProfile;
|
|
}
|
|
|
|
Deno.test("Init: createWorkspaceProfile includes defaults when no repositories exist", () => {
|
|
console.log('🧪 Testing init logic for workspace with no git-sync repositories...');
|
|
|
|
const workspaceProfile = createWorkspaceProfileNoRepos(mockWorkspace);
|
|
|
|
console.log('Generated workspace profile:', JSON.stringify(workspaceProfile, null, 2));
|
|
|
|
// Verify basic workspace info
|
|
assertEquals(workspaceProfile.baseUrl, 'https://app.windmill.dev/');
|
|
assertEquals(workspaceProfile.workspaceId, 'test-workspace');
|
|
|
|
// Verify default sync settings are included
|
|
assert(Array.isArray(workspaceProfile.includes), 'Should have includes array');
|
|
assertEquals(workspaceProfile.includes.length, 1, 'Should have one include pattern');
|
|
assertEquals(workspaceProfile.includes[0], 'f/**', 'Should include f/** pattern');
|
|
|
|
assert(Array.isArray(workspaceProfile.excludes), 'Should have excludes array');
|
|
assertEquals(workspaceProfile.excludes.length, 0, 'Should have empty excludes array');
|
|
|
|
assertEquals(workspaceProfile.defaultTs, 'bun', 'Should have bun as default TypeScript runtime');
|
|
|
|
console.log('✅ Workspace profile correctly includes default sync settings when no repositories exist');
|
|
});
|
|
|
|
Deno.test("Init: verify DEFAULT_SYNC_OPTIONS has expected values", () => {
|
|
console.log('🔍 Verifying DEFAULT_SYNC_OPTIONS contains expected values...');
|
|
|
|
console.log('DEFAULT_SYNC_OPTIONS:', JSON.stringify(DEFAULT_SYNC_OPTIONS, null, 2));
|
|
|
|
// Verify the default options include the expected f/** pattern
|
|
assert(Array.isArray(DEFAULT_SYNC_OPTIONS.includes), 'DEFAULT_SYNC_OPTIONS should have includes array');
|
|
assertEquals(DEFAULT_SYNC_OPTIONS.includes.length, 1, 'Should have one include pattern');
|
|
assertEquals(DEFAULT_SYNC_OPTIONS.includes[0], 'f/**', 'Should default to f/** pattern');
|
|
|
|
assert(Array.isArray(DEFAULT_SYNC_OPTIONS.excludes), 'DEFAULT_SYNC_OPTIONS should have excludes array');
|
|
assertEquals(DEFAULT_SYNC_OPTIONS.excludes.length, 0, 'Should have empty excludes array by default');
|
|
|
|
assertEquals(DEFAULT_SYNC_OPTIONS.defaultTs, 'bun', 'Should default to bun runtime');
|
|
|
|
console.log('✅ DEFAULT_SYNC_OPTIONS has expected values');
|
|
});
|
|
|
|
Deno.test({
|
|
name: "Init: --use-backend flag applies git-sync settings",
|
|
ignore: shouldSkipOnCI(), // Requires EE features
|
|
sanitizeResources: false,
|
|
sanitizeOps: false,
|
|
fn: async () => {
|
|
await withTestBackend(async (backend, tempDir) => {
|
|
// Set up workspace
|
|
const testWorkspace = {
|
|
remote: backend.baseUrl,
|
|
workspaceId: backend.workspace,
|
|
name: backend.workspace,
|
|
token: backend.token
|
|
};
|
|
await addWorkspace(testWorkspace, { force: true, configDir: backend.testConfigDir });
|
|
|
|
// First create the git repository resource that the git-sync will reference
|
|
await backend.createAdditionalGitRepo("u/test/init_repo", "Test init repository");
|
|
|
|
// Configure backend with git-sync settings
|
|
await backend.updateGitSyncConfig({
|
|
git_sync_settings: {
|
|
repositories: [{
|
|
git_repo_resource_path: "u/test/init_repo",
|
|
script_path: "f/**",
|
|
group_by_folder: false,
|
|
use_individual_branch: false,
|
|
settings: {
|
|
include_path: ["f/backend/**"],
|
|
include_type: ["script", "flow"],
|
|
exclude_path: ["*.test.ts"],
|
|
extra_include_path: ["g/**"]
|
|
}
|
|
}]
|
|
}
|
|
});
|
|
|
|
// Run init with --use-backend flag
|
|
const result = await backend.runCLICommand([
|
|
'init',
|
|
'--use-backend',
|
|
'--repository', 'u/test/init_repo'
|
|
], tempDir);
|
|
|
|
assertEquals(result.code, 0, `Init with --use-backend should succeed: ${result.stderr}`);
|
|
|
|
// Verify wmill.yaml was created with backend settings
|
|
const wmillYaml = await Deno.readTextFile(`${tempDir}/wmill.yaml`);
|
|
|
|
// Should have backend-applied settings written to top-level (not overrides)
|
|
assertStringIncludes(wmillYaml, "f/backend/**", "Should include backend's include_path");
|
|
assertStringIncludes(wmillYaml, "*.test.ts", "Should include backend's exclude_path");
|
|
assertStringIncludes(wmillYaml, "g/**", "Should include backend's extra_include_path");
|
|
|
|
// Should have empty overrides section for consistency
|
|
assertStringIncludes(wmillYaml, "gitBranches: {}");
|
|
});
|
|
}
|
|
});
|
|
|
|
Deno.test({
|
|
name: "Init: --use-default bypasses backend settings check",
|
|
ignore: shouldSkipOnCI(), // Requires EE features
|
|
sanitizeResources: false,
|
|
sanitizeOps: false,
|
|
fn: async () => {
|
|
await withTestBackend(async (backend, tempDir) => {
|
|
// Set up workspace
|
|
const testWorkspace = {
|
|
remote: backend.baseUrl,
|
|
workspaceId: backend.workspace,
|
|
name: backend.workspace,
|
|
token: backend.token
|
|
};
|
|
await addWorkspace(testWorkspace, { force: true, configDir: backend.testConfigDir });
|
|
|
|
// Create git repository resource
|
|
await backend.createAdditionalGitRepo("u/test/ignored_repo", "Test ignored repository");
|
|
|
|
// Configure backend with git-sync settings
|
|
await backend.updateGitSyncConfig({
|
|
git_sync_settings: {
|
|
repositories: [{
|
|
git_repo_resource_path: "u/test/ignored_repo",
|
|
script_path: "f/**",
|
|
group_by_folder: false,
|
|
use_individual_branch: false,
|
|
settings: {
|
|
include_path: ["f/should-be-ignored/**"],
|
|
include_type: ["script"],
|
|
exclude_path: [],
|
|
extra_include_path: []
|
|
}
|
|
}]
|
|
}
|
|
});
|
|
|
|
// Run init with --use-default (should ignore backend)
|
|
const result = await backend.runCLICommand([
|
|
'init',
|
|
'--use-default'
|
|
], tempDir);
|
|
|
|
assertEquals(result.code, 0, `Init with --use-default should succeed: ${result.stderr}`);
|
|
|
|
// Verify wmill.yaml was created with default settings only
|
|
const wmillYaml = await Deno.readTextFile(`${tempDir}/wmill.yaml`);
|
|
|
|
// Should have default settings, not backend settings
|
|
assertStringIncludes(wmillYaml, "includes:\n - f/**", "Should use default includes");
|
|
assertStringIncludes(wmillYaml, "defaultTs: bun", "Should use default TypeScript runtime");
|
|
|
|
// Should NOT have backend-specific settings
|
|
assertEquals(wmillYaml.includes("f/should-be-ignored/**"), false, "Should not include backend settings");
|
|
assertStringIncludes(wmillYaml, "gitBranches: {}", "Should have empty overrides section for consistency");
|
|
});
|
|
}
|
|
}); |