mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-09-09 08:03:50 +00:00
* fix: add SSRF protection to SAML and MCP OAuth endpoints - Add shared SSRF URL validation utility (windmill-common/ssrf.rs) that blocks private/loopback/link-local IPs and validates DNS resolution - Move test_metadata to authed service requiring superadmin access - Strip response body from SAML metadata parsing errors - Add SSRF blocklist to MCP OAuth discover, start, and client registration endpoints Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: update ee-repo-ref.txt for SSRF fix Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: update ee-repo-ref.txt Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: update ee-repo-ref to 563877bf1c8b4184f638bab51be89b1c0aec6dad This commit updates the EE repository reference after PR #471 was merged in windmill-ee-private. Previous ee-repo-ref: a600fe1807ea267f87a57360f4b48bf917776723 New ee-repo-ref: 563877bf1c8b4184f638bab51be89b1c0aec6dad Automated by sync-ee-ref workflow. --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: windmill-internal-app[bot] <windmill-internal-app[bot]@users.noreply.github.com>
152 lines
5.3 KiB
Rust
152 lines
5.3 KiB
Rust
use std::net::{IpAddr, Ipv4Addr, Ipv6Addr};
|
|
|
|
use crate::error::Error;
|
|
|
|
/// Validates that a URL is safe to fetch server-side (not targeting private/internal networks).
|
|
///
|
|
/// Checks:
|
|
/// 1. Scheme must be http or https
|
|
/// 2. Host must be present and not a private/loopback/link-local IP
|
|
/// 3. DNS resolution is checked to prevent DNS rebinding to internal IPs
|
|
pub async fn validate_url_for_ssrf(url: &str) -> Result<(), Error> {
|
|
let parsed =
|
|
url::Url::parse(url).map_err(|e| Error::BadRequest(format!("Invalid URL: {e}")))?;
|
|
|
|
// 1. Scheme check
|
|
match parsed.scheme() {
|
|
"http" | "https" => {}
|
|
scheme => {
|
|
return Err(Error::BadRequest(format!(
|
|
"URL scheme '{scheme}' is not allowed, only http and https are permitted"
|
|
)));
|
|
}
|
|
}
|
|
|
|
// 2. Host check
|
|
let host = parsed
|
|
.host_str()
|
|
.ok_or_else(|| Error::BadRequest("URL must have a host".to_string()))?;
|
|
|
|
// 3. If the host is an IP literal, check it directly
|
|
if let Ok(ip) = host.parse::<IpAddr>() {
|
|
if is_private_ip(&ip) {
|
|
return Err(Error::BadRequest(
|
|
"URL targets a private/internal IP address".to_string(),
|
|
));
|
|
}
|
|
return Ok(());
|
|
}
|
|
|
|
// 4. DNS resolution check — resolve the hostname and verify all IPs are public
|
|
let port = parsed.port().unwrap_or(match parsed.scheme() {
|
|
"https" => 443,
|
|
_ => 80,
|
|
});
|
|
let resolve_target = format!("{host}:{port}");
|
|
let addrs: Vec<std::net::SocketAddr> = tokio::net::lookup_host(&resolve_target)
|
|
.await
|
|
.map_err(|e| Error::BadRequest(format!("Failed to resolve host '{host}': {e}")))?
|
|
.collect();
|
|
|
|
if addrs.is_empty() {
|
|
return Err(Error::BadRequest(format!(
|
|
"Host '{host}' did not resolve to any addresses"
|
|
)));
|
|
}
|
|
|
|
for addr in &addrs {
|
|
if is_private_ip(&addr.ip()) {
|
|
return Err(Error::BadRequest(
|
|
"URL resolves to a private/internal IP address".to_string(),
|
|
));
|
|
}
|
|
}
|
|
|
|
Ok(())
|
|
}
|
|
|
|
fn is_private_ip(ip: &IpAddr) -> bool {
|
|
match ip {
|
|
IpAddr::V4(ipv4) => is_private_ipv4(ipv4),
|
|
IpAddr::V6(ipv6) => is_private_ipv6(ipv6),
|
|
}
|
|
}
|
|
|
|
fn is_private_ipv4(ip: &Ipv4Addr) -> bool {
|
|
ip.is_loopback() // 127.0.0.0/8
|
|
|| ip.is_private() // 10.0.0.0/8, 172.16.0.0/12, 192.168.0.0/16
|
|
|| ip.is_link_local() // 169.254.0.0/16 (AWS IMDS lives here)
|
|
|| ip.is_broadcast() // 255.255.255.255
|
|
|| ip.is_unspecified() // 0.0.0.0
|
|
|| ip.is_documentation() // 192.0.2.0/24, 198.51.100.0/24, 203.0.113.0/24
|
|
// CGNAT / shared address space
|
|
|| (ip.octets()[0] == 100 && (ip.octets()[1] & 0xC0) == 64) // 100.64.0.0/10
|
|
}
|
|
|
|
fn is_private_ipv6(ip: &Ipv6Addr) -> bool {
|
|
ip.is_loopback() // ::1
|
|
|| ip.is_unspecified() // ::
|
|
// Unique local addresses (fc00::/7)
|
|
|| (ip.segments()[0] & 0xfe00) == 0xfc00
|
|
// Link-local (fe80::/10)
|
|
|| (ip.segments()[0] & 0xffc0) == 0xfe80
|
|
// IPv4-mapped addresses — check the embedded IPv4
|
|
|| match ip.to_ipv4_mapped() {
|
|
Some(ipv4) => is_private_ipv4(&ipv4),
|
|
None => false,
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn test_private_ipv4() {
|
|
assert!(is_private_ipv4(&"127.0.0.1".parse().unwrap()));
|
|
assert!(is_private_ipv4(&"10.0.0.1".parse().unwrap()));
|
|
assert!(is_private_ipv4(&"172.16.0.1".parse().unwrap()));
|
|
assert!(is_private_ipv4(&"192.168.1.1".parse().unwrap()));
|
|
assert!(is_private_ipv4(&"169.254.169.254".parse().unwrap()));
|
|
assert!(is_private_ipv4(&"0.0.0.0".parse().unwrap()));
|
|
assert!(is_private_ipv4(&"100.64.0.1".parse().unwrap()));
|
|
assert!(!is_private_ipv4(&"8.8.8.8".parse().unwrap()));
|
|
assert!(!is_private_ipv4(&"1.1.1.1".parse().unwrap()));
|
|
}
|
|
|
|
#[test]
|
|
fn test_private_ipv6() {
|
|
assert!(is_private_ipv6(&"::1".parse().unwrap()));
|
|
assert!(is_private_ipv6(&"::".parse().unwrap()));
|
|
assert!(is_private_ipv6(&"fc00::1".parse().unwrap()));
|
|
assert!(is_private_ipv6(&"fd00::1".parse().unwrap()));
|
|
assert!(is_private_ipv6(&"fe80::1".parse().unwrap()));
|
|
// IPv4-mapped loopback
|
|
assert!(is_private_ipv6(&"::ffff:127.0.0.1".parse().unwrap()));
|
|
assert!(!is_private_ipv6(&"2001:4860:4860::8888".parse().unwrap()));
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn test_validate_url_blocks_private() {
|
|
assert!(validate_url_for_ssrf("http://127.0.0.1/foo").await.is_err());
|
|
assert!(validate_url_for_ssrf("http://10.0.0.1/foo").await.is_err());
|
|
assert!(
|
|
validate_url_for_ssrf("http://169.254.169.254/latest/meta-data")
|
|
.await
|
|
.is_err()
|
|
);
|
|
assert!(validate_url_for_ssrf("http://[::1]/foo").await.is_err());
|
|
assert!(validate_url_for_ssrf("ftp://example.com/foo")
|
|
.await
|
|
.is_err());
|
|
assert!(validate_url_for_ssrf("file:///etc/passwd").await.is_err());
|
|
assert!(validate_url_for_ssrf("not-a-url").await.is_err());
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn test_validate_url_allows_public() {
|
|
// This resolves to a public IP
|
|
assert!(validate_url_for_ssrf("https://google.com").await.is_ok());
|
|
}
|
|
}
|