mirror of https://github.com/windmill-labs/windmill.git synced 2026-08-26 08:01:38 +00:00

Files

T

Ruben Fiszel 5cde2d5b67 fix(sessions): sync AI-session preview with workspace edits + stop phantom autosave (WIN-2160) (#10061 )

* fix(sessions): sync AI-session editor preview with workspace edits + stop phantom autosave (WIN-2160)

Two related draft-sync fixes surfaced by the new AI sessions preview.

1. Session preview went stale after a workspace edit. A session's editor
runtime cell (content store + loadedPath) outlives the sessions page: it
survives toggling to workspace mode and MRU tab eviction. The shared
per-user draft can change while the editor is unmounted — most visibly by
editing the same item in the classic workspace editor, or from another
device — but on the next mount the load early-returns on the still-set
loadedPath and the preview keeps showing the pre-toggle content. Fix:
invalidate the cell's loadedPath when SessionEditorTarget unmounts, so the
next mount re-fetches the draft as a clean first load. This also sidesteps
a Monaco model-reuse race (a force-reload that remounts the editor while
the old one is still disposing renders a stale model) and prevents the
outbound draft-sync from posting the stale store back (ready() stays false
until the reload lands). Applies to all three editor kinds (script, flow,
raw app) since they share SessionEditorTarget.

2. Opening a deployed script in the full-page editor autosaved a phantom
draft with no user change. The deployed baseline carries a server-derived
assets: [] that the editor's draft value never reproduces, so
draftValuesEqual never matched baseline, discardIf returned false, and the
settle-time write posted a no-op draft. Fix: ignore assets in the
draft-vs-baseline comparison (it's derived from content, so it can't mask a
real change).

Fixes WIN-2160

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* chore(sessions): condense teardown-invalidation comment to repo comment-length rule

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2026-07-12 10:19:08 +02:00