mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-09-22 00:02:38 +00:00
* feat(frontend): group the AI agent step form and edit saved agents in a modal Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * feat: edit a saved AI agent through its own resource draft Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * refactor: drop the agent fork-for-edit session now that edits live in a draft Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * feat: edit ai_agent resources from the resources page with the agent editor Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix: send a standalone agent's brain from the module when testing a step Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix: keep the agent draft faithful to the resource it deploys to Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * chore: add the sqlx cache entry for the eval subject rename Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * refactor: share the module insert between the graph and the agent editor Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * feat(frontend): open evals inside the agent editor, actions in its header Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * feat(frontend): add tools from the agent editor and lighten its test pane Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(frontend): open an ai_agent deep link in the agent editor Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(frontend): drop the failed result badge on a step that never ran Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * feat(frontend): head the agent editor's levels with a back control Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * feat(frontend): drop connect and fill inputs from the agent editor Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * feat(frontend): lighten the agent editor's run panel Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(frontend): stop a nested agent tool's config reading as AI-filled Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * feat(frontend): offer only AI or static on an agent tool's inputs Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * feat(frontend): give a saved agent's tool editor a static-only surface Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * feat(frontend): open an agent tool in a drawer beside the agent Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * feat(frontend): hide unset agent config in the run form Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * refactor(frontend): share the input forms' pickers and s3 lookup Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * chore(frontend): drop a dead agent-editor export and fix two stale comments Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(frontend): reach an ai_agent's resource-level settings and copilot Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(frontend): open an ai_agent's resource view as JSON, not the generic form Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(frontend): address review findings on the agent editor's draft and streaming Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(frontend): close the agent editor on a version restore, as the resource editor does Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(frontend): stop the provider picker auto-writing a kind, and clear review nits Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * refactor(frontend): drop the fork-for-edit leftovers from the agent card Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(frontend): mount the agent editor in the dev flow editor and guard the deep-link race Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(frontend): deploy the agent config that was submitted, and refuse one no run could use Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * refactor(frontend): build the agent editor's rows from the design-system button Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(frontend): keep a draft-only agent's draft, and let a blank MCP summary deploy Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(frontend): guard read-only agents, incomplete MCP tools and duplicate editor mounts Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix: read-only agent editor, linked-card refresh, atomic eval rename * fix: eval rename needs the privileged pool, per-workspace write access * fix(frontend): drop the agent editor target when its mount goes away * refactor: drop the agent rename work from this PR, unban the bindable defaults * fix(frontend): refuse a renaming deploy and drop the copilot from static-only fields * fix(frontend): mirror the worker's streaming rule and scope agent writes to their target * fix(frontend): read runtime streaming as off and reset the drawer's json view * fix(frontend): read an unsettled output_type as non-streaming too * fix(frontend): let the showing modal claim an agent opened from inside it * fix(frontend): keep in-flight edits, tool replacements and every linked step in sync * fix(frontend): keep attachments in the run form and bind the agent ref to its tools * fix(frontend): preview the agent as authored and re-evaluate step args on run * fix(frontend): scope agent-editor ownership to the flow's workspace * fix(frontend): drop the tool drill-in where there is no graph to select on * fix(frontend): require a provider kind and keep one resource editor open at a time * fix(frontend): keep legacy nulls, static-only text literal, and the handover anchor * test(worker): pin the agent streaming default * fix(frontend): let an AI-fillable input be switched to static * fix(frontend): report agent editor background failures instead of floating them * fix(frontend): keep the version pane's path alive while the editor closes * fix(frontend): clear the anchor-keep flag at the start of each drawer session * fix(frontend): preview the agent without its synthetic path, refresh the baseline on external writes * refactor(frontend): drop the unverifiable baseline refresh, state the synthetic-path rule * fix(frontend): keep the synthetic path out of agent tool test runs too * refactor(frontend): host the agent editor under the agent's own path * fix(frontend): mark an agent editor's host explicitly instead of inferring it from the path * fix(frontend): discard linked-agent responses from before a deploy * fix(frontend): keep a flow mount from claiming an agent editor's nested target * feat(frontend): keep an agent used as a tool inside the agent being edited * fix(frontend): reserve the agent editor's root module id * docs(frontend): record why the agent editor previews under the agent's path * fix(frontend): refuse to open or deploy a resource that is not an agent * docs(frontend): put the scope-migration comment on the function it describes * fix(frontend): refuse an agent path whose resource type is not proven * fix(frontend): recheck the resource type before deploying, and keep expressions off static-only inputs * fix(frontend): lazy-load the agent editor and slide its levels like the evals pane * refactor: drop unreachable non-list tools check from agent deploy Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(frontend): clear text-only agent fields on image output, reserve the root id Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(frontend): keep the agent editor usable for a non-list tools value Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(frontend): stop the parked eval run list from taking arrow keys Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(frontend): report a non-list tools value on deploy instead of throwing Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(frontend): keep temperature editable for image output Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(frontend): skip non-object tool entries when rendering an agent Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(frontend): guard tool entry reads instead of copying the tool array Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(frontend): key tool rows by position so duplicate ids render Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
367 lines
10 KiB
Svelte
367 lines
10 KiB
Svelte
<script lang="ts">
|
|
import { ResourceService, WorkspaceService } from '$lib/gen'
|
|
import { workspaceStore } from '$lib/stores'
|
|
import { onMount, untrack } from 'svelte'
|
|
import AppConnect from './AppConnectDrawer.svelte'
|
|
import ResourceEditorDrawer from './ResourceEditorDrawer.svelte'
|
|
|
|
import { Button } from './common'
|
|
import { Loader2, Pen, Plus, RotateCw } from 'lucide-svelte'
|
|
import { sendUserToast } from '$lib/toast'
|
|
import Select from './select/Select.svelte'
|
|
import ExploreAssetButton, { assetCanBeExplored } from './ExploreAssetButton.svelte'
|
|
import DropdownV2 from './DropdownV2.svelte'
|
|
import { appIconComponent } from './icons'
|
|
|
|
interface Props {
|
|
initialValue?: string | undefined
|
|
value?: string | undefined
|
|
valueType?: string | undefined
|
|
resourceType?: string | undefined
|
|
disabled?: boolean
|
|
disablePortal?: boolean
|
|
showSchemaExplorer?: boolean
|
|
selectFirst?: boolean
|
|
expressOAuthSetup?: boolean
|
|
defaultValues?: Record<string, any> | undefined
|
|
placeholder?: string | undefined
|
|
selectInputClass?: string
|
|
class?: string
|
|
error?: boolean
|
|
onClear?: () => void
|
|
excludedValues?: string[]
|
|
datatableAsPgResource?: boolean
|
|
workspace?: string | undefined
|
|
disableChatOffset?: boolean
|
|
/** Fires when this picker sets a resource, with the type it carries, and with `undefined` on
|
|
* clear. Unlike an effect on `valueType` it never fires for the value the picker was opened
|
|
* on, but `selectFirst` choosing the only candidate during a load does count as setting one. */
|
|
onValueChange?: (path: string | undefined, type: string | undefined) => void
|
|
}
|
|
|
|
let {
|
|
initialValue = $bindable(undefined),
|
|
value = $bindable(undefined),
|
|
valueType = $bindable(undefined),
|
|
resourceType = undefined,
|
|
disabled = false,
|
|
disablePortal = false,
|
|
showSchemaExplorer = false,
|
|
selectFirst = false,
|
|
expressOAuthSetup = false,
|
|
defaultValues = undefined,
|
|
placeholder = undefined,
|
|
selectInputClass = '',
|
|
class: className = '',
|
|
error = false,
|
|
onClear = undefined,
|
|
excludedValues = undefined,
|
|
datatableAsPgResource = false,
|
|
workspace = undefined,
|
|
disableChatOffset = false,
|
|
onValueChange = undefined
|
|
}: Props = $props()
|
|
|
|
let effectiveWorkspace = $derived(workspace ?? $workspaceStore!)
|
|
|
|
if (initialValue && value == undefined) {
|
|
value = initialValue
|
|
}
|
|
|
|
onMount(() => {
|
|
setTimeout(() => {
|
|
if (Object.keys(defaultValues ?? {}).length > 0 && resourceType) {
|
|
resourceEditor?.initNew?.(resourceType, defaultValues)
|
|
}
|
|
}, 500)
|
|
})
|
|
|
|
// let valueSelect = $state(
|
|
// initialValue || value
|
|
// ? {
|
|
// value: value ?? initialValue,
|
|
// label: value ?? initialValue,
|
|
// type: valueType
|
|
// }
|
|
// : undefined
|
|
// )
|
|
|
|
$effect(() => {
|
|
if (value === undefined) {
|
|
if (initialValue) {
|
|
if (initialValue != value) {
|
|
value = initialValue
|
|
}
|
|
} else {
|
|
}
|
|
} else {
|
|
}
|
|
})
|
|
|
|
let collection = $state(value ? [{ value, label: value, type: valueType }] : [])
|
|
|
|
export async function askNewResource() {
|
|
appConnect?.open?.(resourceType)
|
|
}
|
|
|
|
export async function refreshResources() {
|
|
await loadResources(resourceType)
|
|
}
|
|
|
|
let loading = $state(true)
|
|
async function loadResources(resourceType: string | undefined) {
|
|
loading = true
|
|
try {
|
|
const resourceTypesToQuery =
|
|
resourceType === 'snowflake' ? ['snowflake', 'snowflake_oauth'] : [resourceType]
|
|
|
|
const resources = await Promise.all(
|
|
resourceTypesToQuery.map((rt) =>
|
|
ResourceService.listResource({
|
|
workspace: effectiveWorkspace,
|
|
resourceType: rt
|
|
})
|
|
)
|
|
)
|
|
const nc = resources
|
|
.flat()
|
|
.filter((x) => x.resource_type != 'state' && x.resource_type != 'cache')
|
|
.filter((x) => !excludedValues || !excludedValues.includes(x.path))
|
|
.map((x) => ({
|
|
value: x.path,
|
|
label: x.path,
|
|
type: x.resource_type
|
|
}))
|
|
|
|
if (datatableAsPgResource && resourceType === 'postgresql') {
|
|
try {
|
|
const datatables = (
|
|
await WorkspaceService.listDataTables({
|
|
workspace: effectiveWorkspace
|
|
})
|
|
).map((d) => d.name)
|
|
for (const dt of datatables) {
|
|
nc.push({
|
|
value: `datatable://${dt}`,
|
|
label: `datatable://${dt}`,
|
|
type: 'postgresql'
|
|
})
|
|
}
|
|
} catch (e) {
|
|
console.error('Failed to load data tables', e)
|
|
}
|
|
}
|
|
|
|
// TODO check if this is needed
|
|
if (!nc.find((x) => x.value == value) && (initialValue || value)) {
|
|
nc.push({ value: value ?? initialValue!, label: value ?? initialValue!, type: '' })
|
|
}
|
|
collection = nc
|
|
if (collection.length == 1 && selectFirst && (value == undefined || value == '')) {
|
|
value = collection[0].value
|
|
valueType = collection[0].type
|
|
onValueChange?.(value, valueType)
|
|
}
|
|
} catch (e) {
|
|
sendUserToast('Failed to load resource types', true)
|
|
console.error(e)
|
|
}
|
|
loading = false
|
|
}
|
|
|
|
let previousResourceType = untrack(() => resourceType)
|
|
|
|
$effect(() => {
|
|
effectiveWorkspace && resourceType
|
|
untrack(() => {
|
|
if (previousResourceType != resourceType) {
|
|
previousResourceType = resourceType
|
|
value = undefined
|
|
}
|
|
})
|
|
untrack(() => loadResources(resourceType))
|
|
})
|
|
|
|
$effect(() => {
|
|
excludedValues
|
|
if (effectiveWorkspace && resourceType && !disabled) {
|
|
untrack(() => loadResources(resourceType))
|
|
}
|
|
})
|
|
|
|
let appConnect: AppConnect | undefined = $state()
|
|
let resourceEditor: ResourceEditorDrawer | undefined = $state()
|
|
let hovering = $state(false)
|
|
let isDatatableSelected = $derived(value?.startsWith('datatable://') ?? false)
|
|
let typeByPath = $derived(new Map(collection.map((x) => [x.value, x.type])))
|
|
let SelectedIcon = $derived(appIconComponent(typeByPath.get(value!)))
|
|
</script>
|
|
|
|
<AppConnect
|
|
on:refresh={async (e) => {
|
|
await loadResources(resourceType)
|
|
value = e.detail
|
|
valueType = collection.find((x) => x?.value == value)?.type
|
|
onValueChange?.(value, valueType)
|
|
}}
|
|
bind:this={appConnect}
|
|
{expressOAuthSetup}
|
|
{workspace}
|
|
{disableChatOffset}
|
|
/>
|
|
<ResourceEditorDrawer
|
|
bind:this={resourceEditor}
|
|
{workspace}
|
|
{disableChatOffset}
|
|
on:refresh={async (e) => {
|
|
await loadResources(resourceType)
|
|
if (e.detail) {
|
|
value = e.detail
|
|
valueType = collection.find((x) => x?.value == value)?.type
|
|
onValueChange?.(value, valueType)
|
|
// valueSelect = { value: e.detail, label: e.detail, type: valueType ?? '' }
|
|
}
|
|
}}
|
|
/>
|
|
{#snippet selectedIconSnippet()}
|
|
{#if SelectedIcon}
|
|
<SelectedIcon height="14px" width="14px" size={14} />
|
|
{/if}
|
|
{/snippet}
|
|
|
|
<!-- {JSON.stringify({ value, collection })} -->
|
|
<div class="flex flex-col w-full items-start {className}">
|
|
<div
|
|
class="flex flex-row w-full items-center relative"
|
|
role="group"
|
|
onmouseenter={() => (hovering = true)}
|
|
onmouseleave={() => (hovering = false)}
|
|
>
|
|
<Select
|
|
{disabled}
|
|
{disablePortal}
|
|
bind:value={
|
|
() => value,
|
|
(v) => {
|
|
value = v
|
|
valueType = collection.find((x) => x?.value == v)?.type
|
|
onValueChange?.(value, valueType)
|
|
}
|
|
}
|
|
onClear={() => {
|
|
initialValue = undefined
|
|
value = undefined
|
|
valueType = undefined
|
|
onValueChange?.(undefined, undefined)
|
|
onClear?.()
|
|
}}
|
|
items={collection}
|
|
clearable
|
|
{error}
|
|
class="text-clip grow min-w-0"
|
|
inputClass={selectInputClass}
|
|
placeholder={placeholder ?? `${resourceType ?? 'any'} resource`}
|
|
itemLabelWrapperClasses="flex-1"
|
|
id="resource-picker-select"
|
|
inputLeadingSnippet={SelectedIcon ? selectedIconSnippet : undefined}
|
|
>
|
|
{#snippet startSnippet({ item })}
|
|
{@const Icon = appIconComponent(typeByPath.get(item.value))}
|
|
{#if Icon}
|
|
<span class="shrink-0 text-secondary">
|
|
<Icon height="14px" width="14px" size={14} />
|
|
</span>
|
|
{/if}
|
|
{/snippet}
|
|
{#snippet endSnippet({ item, close })}
|
|
{#if !item.value?.startsWith('datatable://')}
|
|
<Button
|
|
{disabled}
|
|
variant="subtle"
|
|
size="xs2"
|
|
wrapperClasses="-mr-2 pl-1 -my-2"
|
|
btnClasses="hover:bg-surface-tertiary"
|
|
on:click={() => (resourceEditor?.initEdit?.(item.value ?? ''), close())}
|
|
startIcon={{ icon: Pen }}
|
|
iconOnly
|
|
/>
|
|
{/if}
|
|
{/snippet}
|
|
{#snippet bottomSnippet({ close })}
|
|
<div class="flex bg-surface border-t divide-x">
|
|
{#if resourceType?.includes(',')}
|
|
<DropdownV2
|
|
class="flex-1 justify-stretch"
|
|
enableFlyTransition
|
|
items={resourceType?.split(',').map((rt) => ({
|
|
displayName: `${rt} resource`,
|
|
icon: Plus,
|
|
action: () => (appConnect?.open?.(rt), close())
|
|
})) ?? []}
|
|
>
|
|
{#snippet buttonReplacement()}
|
|
<Button
|
|
{disabled}
|
|
color="light"
|
|
variant="contained"
|
|
wrapperClasses="flex-1"
|
|
btnClasses="rounded-none"
|
|
size="sm"
|
|
startIcon={{ icon: Plus }}
|
|
>
|
|
Add a resource
|
|
</Button>
|
|
{/snippet}
|
|
</DropdownV2>
|
|
{:else}
|
|
<Button
|
|
{disabled}
|
|
color="light"
|
|
variant="contained"
|
|
wrapperClasses="flex-1"
|
|
btnClasses="rounded-none"
|
|
size="sm"
|
|
on:click={() => (appConnect?.open?.(resourceType), close())}
|
|
startIcon={{ icon: Plus }}
|
|
>
|
|
Add a {resourceType} resource
|
|
</Button>
|
|
{/if}
|
|
<Button
|
|
variant="contained"
|
|
color="light"
|
|
btnClasses="rounded-none"
|
|
size="sm"
|
|
on:click={() => {
|
|
loadResources(resourceType)
|
|
}}
|
|
startIcon={loading ? { icon: Loader2, classes: 'animate-spin' } : { icon: RotateCw }}
|
|
iconOnly
|
|
/>
|
|
</div>
|
|
{/snippet}
|
|
</Select>
|
|
{#if value && hovering && !isDatatableSelected}
|
|
<div class="absolute {disabled ? 'right-2' : 'right-10'} z-20">
|
|
<Button
|
|
variant="subtle"
|
|
size="xs2"
|
|
wrapperClasses="pl-1"
|
|
btnClasses="hover:bg-surface-tertiary"
|
|
on:click={() => resourceEditor?.initEdit?.(value ?? '')}
|
|
startIcon={{ icon: Pen }}
|
|
iconOnly
|
|
/>
|
|
</div>
|
|
{/if}
|
|
</div>
|
|
{#if showSchemaExplorer && value && assetCanBeExplored({ kind: 'resource', path: value }, { resource_type: resourceType })}
|
|
<ExploreAssetButton
|
|
class="mt-1"
|
|
_resourceMetadata={{ resource_type: resourceType }}
|
|
asset={{ kind: 'resource', path: value }}
|
|
workspace={effectiveWorkspace}
|
|
/>
|
|
{/if}
|
|
</div>
|