mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-09-13 00:03:57 +00:00
* feat: responsive modal step panel for the flow editor in sessions On narrow layouts the flow editor's step-details pane opens as a modal (double-click a graph node) instead of a split pane, with a dock/float toggle. Scoped to sessions via allowModalPanel; the full-page editor is unchanged. - FlowEditor: modal/docked modes gated by mount width + allowModalPanel, small header (step-id Badge + subtle dock/close), standing double-click hint, and a per-step hint in the name tooltip - selectionManager: onSelectIntent hook so flow-level panels (settings, input, triggers…) open the modal on single click - PropPickerWrapper: collapse the prop picker until connect and animate it in via AnimatedPane (runs-page pattern), no blue connect ring in modal mode - StepInputGen: drop the TAB/Wand autocompletion button + spinner (feature still works via focus + Tab) - InputTransformForm: decouple the Help dropdown from the AI suggestion - FlowModuleHeader: move 'Save to workspace' into an ellipsis dropdown Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix: loop editor rendering and nested splitpanes splitters in the sessions modal - Loop iterator/parallelism: keep the picker split pane (forceExpanded) so the editor fills its box and the picker shows; the collapse-until-connect mode stays for the step inputs - Remove the intrusive AI TAB/Wand autocompletion button from IteratorGen (generation still runs headless via focus + Tab) - Size the iterator connect plug and restyle the loop header/labels/toggles - Scope the global `.splitter-hidden` splitter-hiding rule to direct children so it no longer leaks into nested Splitpanes under the sessions preview Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat: redesign flow step advanced settings as a single toggle-first column Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat: taller step test pane by default and restyle advanced section titles Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat: show flow run-settings params disabled when a setting is toggled off Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat: single-column for-loop panel reusing the run-settings accordion Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat: single-column while-loop panel reusing the run-settings accordion Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat: single-column branch panels reusing the run-settings accordion Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix: auto-open modal panel when creating an AI agent tool Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat: redesign branch panels with card layout and shared predicate editor Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor: remove per-setting status badges from flow map nodes Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore: sync package-lock after windmill-utils-internal bump Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * style: polish prop-picker plug button and branch panel layouts * fix: persist skip-if-stopped toggles in early stop settings * fix: open the step panel modal on demand and cap its width * fix: restore graph step setting badges, strip panel header chips instead * feat: docked panel header with detach action and open-details step menu * feat: width-based panel mode on every surface with inline detach action * refactor: single source for flow step settings and their defaults * docs: pin flow editor vocabulary in CONTEXT.md * fix: open the trigger panel on double click or a specific trigger * fix: keep module pickers inside their pane and dismissable * fix: drop the misleading chevron on the MCP tool entry * fix: resolve flow approvals against the job's workspace, not the nav one * refactor: derive the approval workspace from the job, not from callers * fix: restore S3 snippets and gate params while their setting is off * fix: restore branch mock controls and address review findings * chore: drop stray debug log from the flow map item * feat: pinned output section for loop and branch panels * fix: open the panel for deliberate navigation from the flow header * perf: mount branch predicate editors on demand * fix: skip predicate picker previews the previous step's result * fix: flow-level graph nodes open their panel on a single click * fix: open the step panel for AI chat selections, not for undo * chore: drop dead console.log and duplicated modalPanel doc * fix: re-sync expression editors and scope error-handler settings * fix: match the failure module exactly and ignore unselectable nodes * fix: keep concurrency editable, honour module cache_ttl, tighten panel ids * fix: open panel from indirect selections, use presence for value-driven toggles * fix: don't open settings on error-handler delete, flush editors on unmount * fix: guard editor destroy flush, keep retry kind reachable * refactor: name the run settings panel after the domain vocabulary * fix: only write editor flushes to the step they belong to * fix: bind step panels by id so a delete can't retarget editor writes * fix: don't let the trigger picker's escape close the drawer beneath it * docs: condense two comments to the constraint they record * fix: arbitrate escape through the overlay stack instead of deferring to it * fix: key nested step blocks by identity so anchored bindings can't go stale * fix: untrack the overlay-stack push and drop the frozen branch binding * chore: state the escape rationale once, key branch lists, format * fix: let the topmost overlay own escape instead of the graph * fix: keep the dynamic-input help box out of static template fields * fix: restore the graph connect on the for-loop iterator * fix: end connect mode with the modal and keep it to docked panels * fix: never enter graph connect mode from the modal panel * fix: reveal inserted steps, restore editor pane size, unleak the drawer stack * fix: keep the enable-AI popover reachable in session panes * feat: add the connect policy and its single armed slot * refactor: one picker for every expression input * refactor: route every connect through one armed slot * fix: give every connect button the same footprint * fix: keep the connect ring from showing through the button * fix: keep flow card actions right-aligned beside the detach button * fix: give the connect ring an opaque ground to mask against * feat: dock the panel back without reopening it * feat: dock the panel from the graph control bar * style: round the graph control bar and size its glyphs * style: customize the graph controls through their supported api * style: build the graph control bar from lucide icons * fix: use the graph's tooltip component in the zoom controls * style: pad the graph controls and enlarge their glyphs * style: pad the graph controls and put dock at the bar's end * refactor: give settings rows the same popover picker as other expressions * fix: pass the wrapper's pickable properties to nested inputs * refactor: stack step settings and render every expression through the step input form * feat: split loop panels into tabs and rework the approval form * feat: anchor drawers to their host pane and give them a size floor * fix: mark the loop iterator expression as required * refactor: badge ee-only toggles instead of a warning line * fix: flag an empty loop iterator expression as an error * refactor: pick the early-stop flow status from one toggle group * fix: keep parallel loops uncapped unless a limit is opted into * fix: scope the overlay stack to its host and disarm connect on dismissal * fix: anchor the trigger picker to its host pane * feat: move diff into the menu when the top bar is narrow * fix: gate the result logs toggle to the graph popover * feat: raise the modal-panel breakpoint to 1280 * fix: anchor flow editor popovers and fullscreen to their host pane * fix: anchor overlays to their host pane and mute them when hidden * fix: portal hosted modals and menus into the pane they anchor to * fix: keep non-listening dialogs off the overlay stack * fix: drop the topmost gate from confirmation dialogs * fix: silence overlays in a collapsed preview panel * feat: rework the branch panels with tabs, reordering and add/delete * refactor: fold the detached-panel chrome into the card header * fix: give every flow panel a titled card header * fix: stop the step panel oscillating on an auto-height editor * feat: consolidate script panel actions and restore branch predicate AI * fix: restore the logs toggle on the flow result popover * fix: collapse the idle property picker in modal step panels * fix: stop the docked pane scrolling alongside its panel * fix: space the last settings row off the panel bottom * revert: always show the property picker pane in step panels * chore: keep the inline script AI button identical to main * fix: ask for AI input suggestions on click, not on hover * fix: keep graph connects armed and remount the parallelism input * style: reveal the predicate AI button on row hover * style: give branch cards a handle and delete column * refactor: arbitrate flow overlay escape through Disposable * fix: give the popover picker its results and re-narrow the EE badge * docs: correct loopSubset and guard the modal width measurement * fix: insert picked properties at the cursor in expression inputs * fix: give the expanded-subflow panel the shared header chrome * style: rename the suspend setting to Suspend until approval/resume * feat: open a step's modal when clicking the step already selected * feat: add an auto/attached/detached toggle for the step panel * refactor: pick the step panel's placement from one named menu * refactor: keep the panel-mode module's exports to what is consumed * feat: show each configured setting's value on its badge * fix: carry the suspend rename into the step settings registry * docs: name both gestures in the step explore hint * test: pin where the step panel goes for a given width and preference --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
179 lines
5.8 KiB
Svelte
179 lines
5.8 KiB
Svelte
<script lang="ts">
|
|
import Toggle from '$lib/components/Toggle.svelte'
|
|
import Tooltip from '$lib/components/Tooltip.svelte'
|
|
import { SecondsInput } from '$lib/components/common'
|
|
import { enterpriseLicense } from '$lib/stores'
|
|
import Label from '../Label.svelte'
|
|
import type { Schema } from '$lib/common'
|
|
import { slideDynamic } from '$lib/transitions'
|
|
|
|
let {
|
|
debounce_delay_s = $bindable(),
|
|
debounce_key = $bindable(),
|
|
debounce_args_to_accumulate = $bindable(),
|
|
max_total_debouncing_time = $bindable(),
|
|
max_total_debounces_amount = $bindable(),
|
|
schema = undefined,
|
|
placeholder,
|
|
size = 'xs',
|
|
color = undefined,
|
|
fontClass = 'font-normal',
|
|
indentContent = false
|
|
}: {
|
|
debounce_delay_s: number | undefined
|
|
debounce_key: string | undefined
|
|
debounce_args_to_accumulate: string[] | undefined
|
|
max_total_debouncing_time: number | undefined
|
|
max_total_debounces_amount: number | undefined
|
|
schema?: Schema
|
|
placeholder: string
|
|
size: 'xs' | 'sm'
|
|
color?: 'nord' | undefined
|
|
fontClass?: string
|
|
/** Align the fields under the toggle's label, as the flow step settings do. */
|
|
indentContent?: boolean
|
|
} = $props()
|
|
|
|
// Check if an originalType like "string | string[]" is a top-level
|
|
// union where at least one member is an array type (ends with "[]").
|
|
// Splits on "|" only at the top level (not inside {}, <>, or ()).
|
|
function isUnionWithArray(originalType: string | undefined): boolean {
|
|
if (!originalType) return false
|
|
let depth = 0
|
|
const parts: string[] = []
|
|
let cur = ''
|
|
for (const ch of originalType) {
|
|
if (ch === '{' || ch === '<' || ch === '(') depth++
|
|
else if (ch === '}' || ch === '>' || ch === ')') depth--
|
|
else if (ch === '|' && depth === 0) {
|
|
parts.push(cur.trim())
|
|
cur = ''
|
|
continue
|
|
}
|
|
cur += ch
|
|
}
|
|
parts.push(cur.trim())
|
|
// Match TS array syntax (T[]) and Python list syntax (list[T] / List[T])
|
|
return parts.length > 1 && parts.some((p) => p.endsWith('[]') || /^[Ll]ist\[.+\]$/.test(p))
|
|
}
|
|
|
|
// Get list of arguments eligible for accumulation from schema.
|
|
// Includes array-type arguments and union types like T | T[]
|
|
// whose scalar values are wrapped into single-element arrays
|
|
// at aggregation time.
|
|
let arrayArgs = $derived(
|
|
schema?.properties
|
|
? Object.entries(schema.properties)
|
|
.filter(([_, prop]) => prop.type === 'array' || isUnionWithArray(prop.originalType))
|
|
.map(([key, _]) => key)
|
|
: []
|
|
)
|
|
|
|
// Single selected arg for UI (convert between single selection and array)
|
|
let selectedArg = $state(debounce_args_to_accumulate?.[0] ?? '')
|
|
|
|
$effect(() => {
|
|
if (selectedArg && selectedArg !== '') {
|
|
debounce_args_to_accumulate = [selectedArg]
|
|
} else {
|
|
debounce_args_to_accumulate = undefined
|
|
}
|
|
})
|
|
|
|
// Convert 0 to undefined for max values
|
|
$effect(() => {
|
|
if (max_total_debouncing_time === 0) {
|
|
max_total_debouncing_time = undefined
|
|
}
|
|
if (max_total_debounces_amount === 0) {
|
|
max_total_debounces_amount = undefined
|
|
}
|
|
})
|
|
|
|
// Presence, not truthiness: a single backspace takes the seeded 1s to 0 while the
|
|
// user is still typing, and reading that as off would disable the field mid-edit.
|
|
let off = $derived(!$enterpriseLicense || debounce_delay_s === undefined)
|
|
</script>
|
|
|
|
<div>
|
|
<div class="flex flex-row items-center gap-2">
|
|
<Toggle
|
|
textClass={fontClass}
|
|
{color}
|
|
{size}
|
|
disabled={!$enterpriseLicense}
|
|
checked={debounce_delay_s !== undefined}
|
|
on:change={() => {
|
|
if (debounce_delay_s !== undefined) {
|
|
debounce_delay_s = undefined
|
|
debounce_key = undefined
|
|
} else {
|
|
debounce_delay_s = 1
|
|
}
|
|
}}
|
|
options={{
|
|
right: 'Debouncing',
|
|
rightTooltip: 'Consolidate multiple executions into a single run within a time window',
|
|
rightDocumentationLink: 'https://www.windmill.dev/docs/core_concepts/job_debouncing'
|
|
}}
|
|
class="py-1"
|
|
eeOnly={true}
|
|
/>
|
|
</div>
|
|
|
|
{#if !off}
|
|
<div class="flex flex-col gap-4 mt-2 {indentContent ? 'pl-9' : ''}" transition:slideDynamic>
|
|
<Label label="Delay in seconds">
|
|
<SecondsInput disabled={off} bind:seconds={debounce_delay_s} />
|
|
</Label>
|
|
<Label label="Custom debounce key (optional)">
|
|
{#snippet header()}
|
|
<Tooltip>
|
|
Debounce keys are global, you can have them be workspace specific using the variable
|
|
`$workspace`. You can also use an argument's value using `$args[name_of_arg]`</Tooltip
|
|
>
|
|
{/snippet}
|
|
<input type="text" disabled={off} bind:value={debounce_key} {placeholder} />
|
|
</Label>
|
|
<Label label="Argument to accumulate (optional)">
|
|
{#snippet header()}
|
|
<Tooltip>
|
|
Select a list-type argument to accumulate across debounced executions. Values from each
|
|
debounced execution will be appended together.</Tooltip
|
|
>
|
|
{/snippet}
|
|
<select disabled={off} bind:value={selectedArg}>
|
|
<option value="">None</option>
|
|
{#each arrayArgs as arg}
|
|
<option value={arg}>{arg}</option>
|
|
{/each}
|
|
</select>
|
|
{#if arrayArgs.length === 0}
|
|
<div class="text-xs text-gray-500 mt-1">
|
|
No list-type arguments found in schema. Define arguments with type "array" to enable
|
|
accumulation.
|
|
</div>
|
|
{/if}
|
|
</Label>
|
|
<Label label="Max total debouncing time (optional)">
|
|
{#snippet header()}
|
|
<Tooltip>
|
|
Maximum total time (in seconds) that a job can be debounced before it must execute. Once
|
|
this time is reached, the job will run regardless of ongoing debouncing.</Tooltip
|
|
>
|
|
{/snippet}
|
|
<SecondsInput disabled={off} bind:seconds={max_total_debouncing_time} />
|
|
</Label>
|
|
<Label label="Max total debounces amount (optional)">
|
|
{#snippet header()}
|
|
<Tooltip>
|
|
Maximum number of times a job can be debounced before it must execute. Once this count
|
|
is reached, the job will run regardless of ongoing debouncing.</Tooltip
|
|
>
|
|
{/snippet}
|
|
<input type="number" disabled={off} bind:value={max_total_debounces_amount} min="0" />
|
|
</Label>
|
|
</div>
|
|
{/if}
|
|
</div>
|