windmill

mirror of https://github.com/windmill-labs/windmill.git synced 2026-09-04 16:03:06 +00:00

Files

T

Ruben Fiszel be475a7947 fix(debounce): claim whole batch in one UPDATE (no deadlock); assert test setup

Both Codex (P1) and Claude (P2) flagged a deadlock: the claim used two writable
CTEs (claim_self then claim_rest), locking the self row before siblings, so two
survivors of the same batch pulled concurrently acquired row locks in opposite
order and PostgreSQL aborted one with deadlock_detected (a transient pull error
on exactly the two-survivors race this path handles).

Replace with a single `UPDATE ... WHERE debounce_batch = (...) AND consumed_at IS
NULL RETURNING id` that claims the whole batch: both transactions lock rows in
the same scan order, so one simply waits and re-evaluates under EvalPlanQual.
A `claimed_self` flag (EXISTS id = self in the claimed set) plus the `mine`
snapshot still distinguishes fresh-claim / consumed-by-other / own-re-pull.

Also assert add_survivor_to_batch_of actually inserts a row (rows_affected == 1)
so a mis-set-up test can't pass vacuously.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2026-06-25 16:25:17 +00:00

fixtures

feat: store hashed tokens instead of plaintext (#8217 )

2026-03-17 01:15:38 +00:00

concurrency_counter_test.rs

fix(concurrency): two-phase admit to skip FOR UPDATE on over-limit pulls (#9064 )

2026-05-07 09:43:33 +00:00

debounce_test.rs

fix(debounce): claim whole batch in one UPDATE (no deadlock); assert test setup

2026-06-25 16:25:17 +00:00

job_cleanup_test.rs

refactor: move integration tests to subcrates to reduce recompilation