mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-10-14 16:02:57 +00:00
* feat: edit variables, resources and triggers in their own session tab Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix: take a trigger's flow kind from its config and name the written trigger Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor: one operating-workspace context for editors acting on a session's workspace Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix: reload page item tabs only in sessions acting on the tool's workspace Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix: resolve open in workspace for every preview tab kind in one place Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix: guard every component under a session editor against the navigation workspace Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix: show a page item tab whose item is gone instead of mounting its editor Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix: follow a saved page item in the tab's own workspace and restore in-frame rows Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * feat: close a page item tab from its editor header Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix: judge trigger permissions by the user acting in the session workspace Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix: judge every session-editor permission by the user acting in that workspace Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix: keep session permissions reactive to the acting role and restore tabs as last seen Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix: default Path's owner controls to the user acting in its workspace Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-authored-by: Ruben Fiszel <ruben@windmill.dev>
206 lines
6.7 KiB
Svelte
206 lines
6.7 KiB
Svelte
<script lang="ts">
|
|
import FlowStatusViewerInner from './FlowStatusViewerInner.svelte'
|
|
import type { FlowState } from './flows/flowState'
|
|
import { setContext, untrack } from 'svelte'
|
|
import type { DurationStatus, FlowStatusViewerContext, GraphModuleState } from './graph'
|
|
import { isOwner as loadIsOwner, type StateStore } from '$lib/utils'
|
|
import { userStore } from '$lib/stores'
|
|
import type { CompletedJob, FlowModule, FlowNote, FlowValue, Job } from '$lib/gen'
|
|
import { useOperatingWorkspace } from '$lib/components/operatingWorkspace.svelte'
|
|
|
|
const operatingWorkspace = useOperatingWorkspace()
|
|
|
|
interface Props {
|
|
jobId: string
|
|
initialJob?: Job | undefined
|
|
workspaceId?: string | undefined
|
|
flowState?: FlowState
|
|
selectedJobStep?: string | undefined
|
|
hideFlowResult?: boolean
|
|
hideTimeline?: boolean
|
|
hideDownloadInGraph?: boolean
|
|
hideNodeDefinition?: boolean
|
|
hideJobId?: boolean
|
|
hideDownloadLogs?: boolean
|
|
rightColumnSelect?: 'timeline' | 'node_status' | 'node_definition' | 'user_states'
|
|
isOwner?: boolean
|
|
wideResults?: boolean
|
|
localModuleStates?: Record<string, GraphModuleState>
|
|
/** Cached subflow definitions, keyed by graph node id (subflow step id, with
|
|
* `subflow:` prefix for nested subflows). Populated as the user expands a
|
|
* subflow in the graph. Bindable so callers can use it to walk inside
|
|
* subflows (e.g. for nested-restart path-finding). */
|
|
expandedSubflows?: Record<string, { modules: FlowModule[]; groups?: any[] }>
|
|
localDurationStatuses?: Record<string, DurationStatus>
|
|
job?: Job | undefined
|
|
render?: boolean
|
|
suspendStatus?: StateStore<Record<string, { job: Job; nb: number }>>
|
|
customUi?: {
|
|
tagLabel?: string | undefined
|
|
}
|
|
onStart?: () => void
|
|
onJobsLoaded?: ({ job, force }: { job: Job; force: boolean }) => void
|
|
onDone?: ({ job }: { job: CompletedJob }) => void
|
|
showLogsWithResult?: boolean
|
|
notes?: FlowNote[]
|
|
groups?: FlowValue['groups']
|
|
}
|
|
|
|
let {
|
|
jobId,
|
|
initialJob = undefined,
|
|
workspaceId = undefined,
|
|
flowState = $bindable({}),
|
|
selectedJobStep = $bindable(undefined),
|
|
hideFlowResult = false,
|
|
hideTimeline = false,
|
|
hideDownloadInGraph = false,
|
|
hideNodeDefinition = false,
|
|
hideJobId = false,
|
|
hideDownloadLogs = false,
|
|
rightColumnSelect = $bindable('timeline'),
|
|
isOwner = $bindable(false),
|
|
wideResults = false,
|
|
localModuleStates = $bindable({}),
|
|
// `$bindable({})` is the right shape for this prop despite CLAUDE.md's
|
|
// general guidance against `$bindable(default_value)`: that rule targets
|
|
// props where `undefined` has distinct semantics from "empty default".
|
|
// For a Map-typed cache populated by the inner component, callers that
|
|
// don't bind it should still see a usable empty map (the inner writes to
|
|
// it when the user expands a subflow). Without the `{}` default, those
|
|
// callers would crash at write time. Same reasoning applies to the
|
|
// pre-existing `localModuleStates`/`localDurationStatuses` bindables.
|
|
expandedSubflows = $bindable({}),
|
|
localDurationStatuses = $bindable({}),
|
|
job = $bindable(undefined),
|
|
render = true,
|
|
suspendStatus = $bindable({ val: {} }),
|
|
customUi,
|
|
onStart,
|
|
onJobsLoaded,
|
|
onDone,
|
|
showLogsWithResult = false,
|
|
notes: notesProp = undefined,
|
|
groups: groupsProp = undefined
|
|
}: Props = $props()
|
|
|
|
let lastJobId: string = untrack(() => jobId)
|
|
|
|
let retryStatus = $state({ val: {} })
|
|
let globalRefreshes: Record<string, ((clear, root) => Promise<void>)[]> = $state({})
|
|
|
|
setContext<FlowStatusViewerContext>('FlowStatusViewer', {
|
|
flowState,
|
|
suspendStatus,
|
|
retryStatus,
|
|
hideDownloadInGraph: untrack(() => hideDownloadInGraph),
|
|
hideNodeDefinition: untrack(() => hideNodeDefinition),
|
|
hideTimeline: untrack(() => hideTimeline),
|
|
hideJobId: untrack(() => hideJobId),
|
|
hideDownloadLogs: untrack(() => hideDownloadLogs)
|
|
})
|
|
|
|
function loadOwner(path: string) {
|
|
isOwner = loadIsOwner(path, $userStore!, workspaceId ?? $operatingWorkspace!)
|
|
}
|
|
|
|
async function updateJobId() {
|
|
if (jobId !== lastJobId) {
|
|
console.log('updateJobId 3', jobId)
|
|
lastJobId = jobId
|
|
retryStatus.val = {}
|
|
suspendStatus.val = {}
|
|
globalRefreshes = {}
|
|
for (let key in localModuleStates) delete flowState[key]
|
|
localDurationStatuses = {}
|
|
localModuleStates = {}
|
|
// Reset the subflow definition cache too — a new run can reference
|
|
// different subflow versions; stale entries would confuse nested
|
|
// restart path-finding.
|
|
expandedSubflows = {}
|
|
}
|
|
}
|
|
|
|
let lastScriptPath: string | undefined = $state(undefined)
|
|
|
|
$effect.pre(() => {
|
|
jobId
|
|
untrack(() => {
|
|
jobId && updateJobId()
|
|
})
|
|
})
|
|
|
|
let refreshGlobal = async (moduleId: string, clear: boolean, root: string) => {
|
|
let allFns = globalRefreshes?.[moduleId]?.map((x) => x(clear, root)) ?? []
|
|
await Promise.all(allFns)
|
|
}
|
|
|
|
let updateGlobalRefresh = (moduleId: string, updateFn: (clear, root) => Promise<void>) => {
|
|
globalRefreshes[moduleId] = [...(globalRefreshes[moduleId] ?? []), updateFn]
|
|
}
|
|
|
|
let storedToolCallJobs: Record<string, Job> = $state({})
|
|
let toolCallIndicesToLoad: string[] = $state([])
|
|
</script>
|
|
|
|
{#key jobId}
|
|
<FlowStatusViewerInner
|
|
onJobsLoaded={({ job, force }) => {
|
|
if (job.script_path != lastScriptPath && job.script_path) {
|
|
lastScriptPath = job.script_path
|
|
loadOwner(lastScriptPath ?? '')
|
|
}
|
|
onJobsLoaded?.({ job, force })
|
|
}}
|
|
globalModuleStates={[]}
|
|
bind:localModuleStates
|
|
bind:expandedSubflows
|
|
bind:selectedNode={selectedJobStep}
|
|
bind:localDurationStatuses
|
|
{onStart}
|
|
{onDone}
|
|
bind:job
|
|
{initialJob}
|
|
{jobId}
|
|
{workspaceId}
|
|
{wideResults}
|
|
bind:rightColumnSelect
|
|
{render}
|
|
{customUi}
|
|
graphTabOpen={true}
|
|
isNodeSelected={true}
|
|
{refreshGlobal}
|
|
{updateGlobalRefresh}
|
|
toolCallStore={{
|
|
getStoredToolCallJob: (storeKey: string) => storedToolCallJobs[storeKey],
|
|
setStoredToolCallJob: (storeKey: string, job: Job) => {
|
|
storedToolCallJobs[storeKey] = job
|
|
},
|
|
getLocalToolCallJobs: (prefix: string) => {
|
|
// we return a map from tool call index to job
|
|
// to do so, we filter the storedToolCallJobs object by the prefix and we make sure what's left in the key is a tool call index: 2 part of format agentModuleId-toolCallIndex
|
|
// and not a further nested tool call index
|
|
return Object.fromEntries(
|
|
Object.entries(storedToolCallJobs)
|
|
.filter(
|
|
([key]) => key.startsWith(prefix) && key.replace(prefix, '').split('-').length === 2
|
|
)
|
|
.map(([key, job]) => [Number(key.replace(prefix, '').split('-').pop()), job])
|
|
)
|
|
},
|
|
isToolCallToBeLoaded: (storeKey: string) => {
|
|
return toolCallIndicesToLoad.includes(storeKey)
|
|
},
|
|
addToolCallToLoad: (storeKey: string) => {
|
|
if (!toolCallIndicesToLoad.includes(storeKey)) {
|
|
toolCallIndicesToLoad.push(storeKey)
|
|
}
|
|
}
|
|
}}
|
|
{showLogsWithResult}
|
|
{hideFlowResult}
|
|
notes={notesProp}
|
|
groups={groupsProp}
|
|
/>
|
|
{/key}
|