mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-10-21 16:03:26 +00:00
* feat: let a workspace withdraw operator schedule and trigger writes Operators can create, edit and delete schedules and triggers today through the API, CLI and MCP, while the operator_settings flags beside them only hide those pages. An admin who wants operators to see what is scheduled without letting them change it cannot express that. Add manage_schedules and manage_triggers as enforced settings, gated at the schedule handlers and at the generic TriggerCrud routes so every trigger kind is covered by one check. They name capabilities operators already hold, so they are granted unless withdrawn, and absence has to mean "never configured" rather than a value. The read coalesces to true; the update endpoint merges into the stored jsonb with the two fields as Option<bool>, so an omitted key keeps what is stored. operator_settings is git-synced as a whole object, so a settings file written before these keys existed reaches the endpoint on every pull, and a serde or SQL default of either polarity would turn that pull into a silent withdrawal or restoration. The rights are read through a per-process cache, so withdrawing one publishes a notify_event that drops the entry on every replica. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dsf6VC4MVLisiEoeQkgbr4 * feat: enforce operator write rights on the router and in the UI Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix: close the capture gap and gate the trigger editors' write actions Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix: gate acl writes and the native trigger drawer behind manage rights Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix: refuse operator writes with 403 and gate sharing at the drawer Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * perf: resolve identity in the operator write gate only for writes Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix: gate the suspended-jobs actions and stop the route check refusing reads Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix: explain the empty-state create button when operator writes are withdrawn Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix: audit operator settings changes and fold path writes into native rows Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix: open locked editors read-only and group the operator settings Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix: skip email and azure lookups on editor open while triggers are locked Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * docs: state each operator-rights rationale once in comments Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix: address CI review findings on operator write rights Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix: keep capture move gated and skip it in the builders while locked Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix: keep admin and operator exclusive when setting a workspace role Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * refactor: use the shared section component for operator settings groups Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: Ruben Fiszel <ruben@windmill.dev>
219 lines
7.1 KiB
Svelte
219 lines
7.1 KiB
Svelte
<script lang="ts">
|
|
import { Button } from '$lib/components/common'
|
|
import ToggleButtonGroup from '$lib/components/common/toggleButton-v2/ToggleButtonGroup.svelte'
|
|
import ToggleButton from '$lib/components/common/toggleButton-v2/ToggleButton.svelte'
|
|
import DataTable from '$lib/components/table/DataTable.svelte'
|
|
import Section from '$lib/components/Section.svelte'
|
|
import Head from '$lib/components/table/Head.svelte'
|
|
import Cell from '$lib/components/table/Cell.svelte'
|
|
import Toggle from '$lib/components/Toggle.svelte'
|
|
import { WorkspaceService } from '$lib/gen'
|
|
import { workspaceStore } from '$lib/stores'
|
|
import { sendUserToast } from '$lib/toast'
|
|
import { SaveIcon, EyeIcon, EyeOffIcon } from 'lucide-svelte'
|
|
import { untrack } from 'svelte'
|
|
|
|
let operatorWorkspaceSettings = $state({
|
|
runs: true,
|
|
schedules: true,
|
|
resources: true,
|
|
variables: true,
|
|
assets: true,
|
|
triggers: true,
|
|
audit_logs: true,
|
|
groups: true,
|
|
folders: true,
|
|
workers: true
|
|
})
|
|
|
|
// Kept out of `operatorWorkspaceSettings` so the visibility table's "Enable all" never flips a
|
|
// write right, and so these rows stay out of that table. Withdrawable rather than granted:
|
|
// operators hold them until an admin turns them off.
|
|
let manageSchedules = $state(true)
|
|
let manageTriggers = $state(true)
|
|
|
|
let originalSettings = $state({
|
|
...untrack(() => operatorWorkspaceSettings),
|
|
manage_schedules: true,
|
|
manage_triggers: true
|
|
})
|
|
let isChanged = $state(false)
|
|
let currentWorkspace: string | null = $state(null)
|
|
// Saving sends every key, so saving before the load, or over a late response for another
|
|
// workspace, would write defaults over the rights stored there.
|
|
let loadedWorkspace: string | null = $state(null)
|
|
|
|
const settingsPayload = $derived({
|
|
...operatorWorkspaceSettings,
|
|
manage_schedules: manageSchedules,
|
|
manage_triggers: manageTriggers
|
|
})
|
|
|
|
async function saveSettings() {
|
|
try {
|
|
await WorkspaceService.updateOperatorSettings({
|
|
workspace: $workspaceStore!,
|
|
requestBody: settingsPayload
|
|
})
|
|
originalSettings = { ...settingsPayload }
|
|
isChanged = false
|
|
sendUserToast('Operator settings saved successfully!', false)
|
|
} catch (error) {
|
|
console.error('Error updating operator settings:', error)
|
|
sendUserToast('Failed to save operator settings.', true)
|
|
}
|
|
}
|
|
|
|
const descriptions = {
|
|
runs: { title: 'Runs', description: 'View runs' },
|
|
schedules: { title: 'Schedules', description: 'View schedules' },
|
|
resources: { title: 'Resources', description: 'View resources' },
|
|
variables: { title: 'Variables', description: 'View variables' },
|
|
assets: { title: 'Assets', description: 'View assets' },
|
|
triggers: { title: 'Triggers', description: 'View all triggers (HTTP, Websocket, Kafka)' },
|
|
audit_logs: { title: 'Audit Logs', description: 'View audit logs' },
|
|
groups: { title: 'Groups', description: 'View groups and group members' },
|
|
folders: { title: 'Folders', description: 'View folders' },
|
|
workers: { title: 'Workers', description: 'View workers and worker groups' }
|
|
}
|
|
|
|
$effect(() => {
|
|
if ($workspaceStore && $workspaceStore !== currentWorkspace) {
|
|
;(async () => {
|
|
const ws = $workspaceStore
|
|
currentWorkspace = ws
|
|
const settings = await WorkspaceService.getSettings({ workspace: ws })
|
|
if (ws !== currentWorkspace) return
|
|
if (settings.operator_settings !== null) {
|
|
const {
|
|
manage_schedules: remoteSchedules,
|
|
manage_triggers: remoteTriggers,
|
|
...remoteVisibility
|
|
} = settings.operator_settings ?? {}
|
|
operatorWorkspaceSettings = { ...operatorWorkspaceSettings, ...remoteVisibility }
|
|
manageSchedules = remoteSchedules ?? true
|
|
manageTriggers = remoteTriggers ?? true
|
|
originalSettings = {
|
|
...operatorWorkspaceSettings,
|
|
manage_schedules: manageSchedules,
|
|
manage_triggers: manageTriggers
|
|
}
|
|
}
|
|
loadedWorkspace = ws
|
|
})()
|
|
}
|
|
})
|
|
|
|
$effect(() => {
|
|
isChanged = JSON.stringify(settingsPayload) !== JSON.stringify(originalSettings)
|
|
})
|
|
|
|
const allDisabled = $derived(
|
|
Object.values(operatorWorkspaceSettings).every((value) => value === false)
|
|
)
|
|
const allEnabled = $derived(
|
|
Object.values(operatorWorkspaceSettings).every((value) => value === true)
|
|
)
|
|
</script>
|
|
|
|
<Section
|
|
label="Operator settings"
|
|
collapsable={true}
|
|
tooltip="Operators run what is shared with them. Choose what else they can change and see in this workspace."
|
|
description="Operators run what is shared with them. Choose what else they can change and see in this workspace."
|
|
>
|
|
{#snippet action()}
|
|
<Button
|
|
on:click={saveSettings}
|
|
startIcon={{ icon: SaveIcon }}
|
|
disabled={!isChanged || loadedWorkspace !== $workspaceStore}
|
|
variant="accent"
|
|
>
|
|
Save operator settings
|
|
</Button>
|
|
{/snippet}
|
|
|
|
<Section
|
|
small
|
|
label="Change schedules and triggers"
|
|
description="Operators can create, edit and delete schedules and triggers wherever their folder permissions let them write. When turned off, the server refuses these changes, including through the API and the CLI."
|
|
wrapperClass="mb-6"
|
|
class="flex flex-col gap-y-1"
|
|
>
|
|
<Toggle
|
|
bind:checked={manageSchedules}
|
|
options={{ right: 'Operators can manage schedules' }}
|
|
size="xs"
|
|
/>
|
|
<Toggle
|
|
bind:checked={manageTriggers}
|
|
options={{ right: 'Operators can manage triggers' }}
|
|
size="xs"
|
|
/>
|
|
</Section>
|
|
|
|
<Section
|
|
small
|
|
label="Pages in their menu"
|
|
description="Hides pages from an operator's menu. It does not block access through the API: use folder and item permissions to restrict what they can read."
|
|
>
|
|
<DataTable tableFixed={true} size="xs">
|
|
<Head>
|
|
<tr>
|
|
<Cell head first>Section</Cell>
|
|
<Cell head>Description</Cell>
|
|
<Cell head last>
|
|
<ToggleButtonGroup
|
|
bind:selected={
|
|
() => (allDisabled ? 'false' : allEnabled ? 'true' : ''),
|
|
(v) => {
|
|
Object.keys(operatorWorkspaceSettings).forEach((key) => {
|
|
if (v === 'true') operatorWorkspaceSettings[key] = true
|
|
if (v === 'false') operatorWorkspaceSettings[key] = false
|
|
})
|
|
}
|
|
}
|
|
>
|
|
{#snippet children({ item })}
|
|
<ToggleButton
|
|
icon={EyeIcon}
|
|
small={true}
|
|
value={'true'}
|
|
label="Enable All"
|
|
{item}
|
|
/>
|
|
<ToggleButton
|
|
icon={EyeOffIcon}
|
|
small={true}
|
|
value={'false'}
|
|
label="Disable All"
|
|
{item}
|
|
/>
|
|
{/snippet}
|
|
</ToggleButtonGroup>
|
|
</Cell>
|
|
</tr>
|
|
</Head>
|
|
<tbody class="divide-y bg-surface">
|
|
{#each Object.entries(descriptions) as [key, { title, description }]}
|
|
<tr>
|
|
<Cell first>{title}</Cell>
|
|
<Cell>{description}</Cell>
|
|
<Cell last class="pl-8">
|
|
<ToggleButtonGroup
|
|
selected={operatorWorkspaceSettings[key] ? 'on' : 'off'}
|
|
on:selected={({ detail }) => (operatorWorkspaceSettings[key] = detail === 'on')}
|
|
>
|
|
{#snippet children({ item })}
|
|
<ToggleButton icon={EyeIcon} small={true} value={'on'} label="On" {item} />
|
|
<ToggleButton icon={EyeOffIcon} small={true} value={'off'} label="Off" {item} />
|
|
{/snippet}
|
|
</ToggleButtonGroup>
|
|
</Cell>
|
|
</tr>
|
|
{/each}
|
|
</tbody>
|
|
</DataTable>
|
|
</Section>
|
|
</Section>
|