mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-08-18 16:02:10 +00:00
a22d179903
* feat(cli): add GitHub Actions CI and raw app sync tests - Add CLI tests GitHub Action that runs on Linux and Windows - Add build check job that runs on CLI and openapi.yaml changes - Uses Rust cargo backend instead of Docker for better CI compatibility - Add cargo_backend.ts and test_backend.ts for test infrastructure - Fix Windows path separator bug in raw_apps.ts (use "/" for relative paths) - Fix PostgreSQL URL parsing in cargo_backend.ts - Update tests to use gitBranches format instead of deprecated overrides - Add raw_app_sync.test.ts for raw app sync workflow testing (ignored for now - needs EE) - Skip tests that require EE features (git sync settings, raw apps) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(cli): Fix Windows path compatibility issues in tests - Use fromFileUrl() in cargo_backend.ts for proper Windows path handling - Normalize path separators to forward slashes in resource_folders.ts - Fix readDirRecursive to return normalized paths in test helper - Use forward slashes consistently in buildMetadataPath and detection functions Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(cli): Use SEP in test assertions instead of modifying logic - Revert resource_folders.ts to use SEP as intended - Update test assertions to use SEP for platform-specific paths - Keep readDirRecursive normalization for consistent test comparisons Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(cli): Use SEP for all path separators in test assertions Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(cli): Use resolve() for proper cross-platform path handling in cargo_backend String concatenation with path separators creates malformed paths on Windows. Use path.resolve() instead for proper cross-platform path resolution. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(backend): Add cfg attributes for Windows compatibility - Add #[cfg(unix)] to anyhow::anyhow import (only used in unix cfg block) - Add #[cfg(not(windows))] to parse_file function (uses cat, only for cgroups) - Remove unused std::io import, use std::io::Result directly Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: Windows compilation + convert integration tests to withTestBackend - Fix unused import SYSTEM_ROOT in csharp_executor.rs on Windows by requiring both windows and csharp feature - Fix unused variable id in handle_child.rs on Windows by adding #[allow(unused_variables)] since id is only used in cfg(unix) code - Convert all RUN_INTEGRATION_TESTS dependent tests in sync_pull_push.test.ts to use withTestBackend pattern for automatic backend setup Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat: configurable test features with CI_MINIMAL_FEATURES env var - Default: full features (zip, private, enterprise) for local development - CI mode: minimal features (zip only) when CI_MINIMAL_FEATURES=true - Add shouldSkipOnCI() helper for tests requiring EE features - Update EE-dependent tests to use shouldSkipOnCI() - Add test instructions to cli/README.md Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: enable raw app tests (not EE-dependent) Raw apps work with minimal features. 2 tests pass, 2 have test logic bugs to investigate separately: - "delete file and push" - file deletion not syncing correctly - "dry-run push shows expected changes" - JSON output parsing issue Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: gate cgroups module to Linux only cgroups are Linux-specific, the module was causing dead_code warnings on Windows compilation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(ci): add CI_MINIMAL_FEATURES env var to CLI tests workflow Set CI_MINIMAL_FEATURES=true in both Linux and Windows test jobs so the backend compiles with minimal features (zip only) and EE-dependent tests self-skip via shouldSkipOnCI(). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(cli): raw app tests and backend startup timing - Add 5s delay after backend ready for migrations to complete - Fix dry-run JSON output parsing (handle pretty-printed JSON) - Temporarily ignore "delete file" test (needs isSuperset fix) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(cli): raw app file deletion sync - Add deepEqual check for files in raw_apps.ts isSuperset comparison - Handle raw_app file deletions in sync.ts by re-pushing the entire app - Fix test to remove CSS import before deleting the file When deleting a file from a raw app, the sync now properly updates the backend with the new file list (excluding the deleted file). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(cli): Windows path separators in tests Normalize paths for cross-platform comparison by converting backslashes to forward slashes before path assertions. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(cli): normalize featurePaths in multi_instance_workspace test Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test(cli): add mixed case paths sync tests for Windows compatibility Add comprehensive tests for sync pull/push with capitalized folder paths to catch Windows case-insensitivity issues: - Scripts in f/MyFolder/MyScript - Flows in f/MyFlows/DataProcessor - Apps in f/MyApps/Dashboard - Variables in f/MyVars/ApiKey - Deeply nested paths with mixed case - Multiple resources in same capitalized folder - CamelCase folder names with numbers Each test verifies the full pull -> modify -> push -> verify cycle. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test(cli): add idempotency check to mixed case paths tests After each push, pull again with --dry-run --json-output and verify that no changes are detected. This ensures the sync is stable and catches issues where pull/push cycles cause spurious diffs. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
192 lines
6.2 KiB
TypeScript
192 lines
6.2 KiB
TypeScript
import { assertEquals, assertStringIncludes } from "https://deno.land/std@0.224.0/assert/mod.ts";
|
|
import { withTestBackend } from "./test_backend.ts";
|
|
import { shouldSkipOnCI } from "./cargo_backend.ts";
|
|
import { addWorkspace } from "../workspace.ts";
|
|
|
|
// =============================================================================
|
|
// GITSYNC-SETTINGS COMMAND FEATURES
|
|
// Tests for additional gitsync-settings command functionality
|
|
// These tests require EE features (private, enterprise) and are skipped in CI
|
|
// =============================================================================
|
|
|
|
Deno.test({
|
|
name: "GitSync Settings: default mode writes to top-level",
|
|
ignore: shouldSkipOnCI(), // Requires EE features
|
|
sanitizeResources: false,
|
|
sanitizeOps: false,
|
|
fn: async () => {
|
|
await withTestBackend(async (backend, tempDir) => {
|
|
// Set up workspace
|
|
const testWorkspace = {
|
|
remote: backend.baseUrl,
|
|
workspaceId: backend.workspace,
|
|
name: "default_mode_test",
|
|
token: backend.token
|
|
};
|
|
await addWorkspace(testWorkspace, { force: true, configDir: backend.testConfigDir });
|
|
|
|
// Configure backend with specific settings
|
|
await backend.updateGitSyncConfig!({
|
|
git_sync_settings: {
|
|
repositories: [{
|
|
git_repo_resource_path: "u/test/default_repo",
|
|
script_path: "f/**",
|
|
group_by_folder: false,
|
|
use_individual_branch: false,
|
|
settings: {
|
|
include_path: ["f/special/**"],
|
|
include_type: ["script"],
|
|
exclude_path: ["*.test.ts"],
|
|
extra_include_path: ["g/**"]
|
|
}
|
|
}]
|
|
}
|
|
});
|
|
|
|
// Create initial wmill.yaml with different settings
|
|
await Deno.writeTextFile(`${tempDir}/wmill.yaml`, `defaultTs: bun
|
|
includes:
|
|
- f/**
|
|
excludes: []
|
|
skipVariables: false`);
|
|
|
|
// Pull with default flag
|
|
const result = await backend.runCLICommand([
|
|
'gitsync-settings', 'pull',
|
|
'--repository', 'u/test/default_repo',
|
|
'--default'
|
|
], tempDir);
|
|
|
|
assertEquals(result.code, 0, `Default mode pull should succeed: ${result.stderr}`);
|
|
|
|
// Read updated config
|
|
const updatedConfig = await Deno.readTextFile(`${tempDir}/wmill.yaml`);
|
|
|
|
// Should update top-level settings, not create overrides
|
|
assertStringIncludes(updatedConfig, "includes:\n - f/special/**");
|
|
assertStringIncludes(updatedConfig, "excludes:\n - '*.test.ts'");
|
|
assertStringIncludes(updatedConfig, "extraIncludes:\n - g/**");
|
|
});
|
|
}
|
|
});
|
|
|
|
Deno.test({
|
|
name: "GitSync Settings: pull shows correct diff output",
|
|
ignore: shouldSkipOnCI(), // Requires EE features
|
|
sanitizeResources: false,
|
|
sanitizeOps: false,
|
|
fn: async () => {
|
|
await withTestBackend(async (backend, tempDir) => {
|
|
// Set up workspace
|
|
const testWorkspace = {
|
|
remote: backend.baseUrl,
|
|
workspaceId: backend.workspace,
|
|
name: "diff_test",
|
|
token: backend.token
|
|
};
|
|
await addWorkspace(testWorkspace, { force: true, configDir: backend.testConfigDir });
|
|
|
|
// Configure backend
|
|
await backend.updateGitSyncConfig!({
|
|
git_sync_settings: {
|
|
repositories: [{
|
|
git_repo_resource_path: "u/test/diff_repo",
|
|
script_path: "f/**",
|
|
group_by_folder: false,
|
|
use_individual_branch: false,
|
|
settings: {
|
|
include_path: ["f/**"],
|
|
include_type: ["script", "flow"],
|
|
exclude_path: [],
|
|
extra_include_path: []
|
|
}
|
|
}]
|
|
}
|
|
});
|
|
|
|
// Create wmill.yaml with different settings
|
|
await Deno.writeTextFile(`${tempDir}/wmill.yaml`, `defaultTs: bun
|
|
includes:
|
|
- f/**
|
|
excludes: []
|
|
skipVariables: true
|
|
skipResources: false`);
|
|
|
|
// Pull with diff flag
|
|
const result = await backend.runCLICommand([
|
|
'gitsync-settings', 'pull',
|
|
'--repository', 'u/test/diff_repo',
|
|
'--diff'
|
|
], tempDir);
|
|
|
|
assertEquals(result.code, 0, `Diff mode should succeed: ${result.stderr}`);
|
|
|
|
// Should show differences
|
|
assertStringIncludes(result.stdout, "Changes that would be applied locally:");
|
|
// Should show the change for skipResources (ignoring ANSI color codes)
|
|
assertStringIncludes(result.stdout, "skipResources:");
|
|
});
|
|
}
|
|
});
|
|
|
|
Deno.test({
|
|
name: "GitSync Settings: replace mode overwrites existing config",
|
|
ignore: shouldSkipOnCI(), // Requires EE features
|
|
sanitizeResources: false,
|
|
sanitizeOps: false,
|
|
fn: async () => {
|
|
await withTestBackend(async (backend, tempDir) => {
|
|
// Set up workspace
|
|
const testWorkspace = {
|
|
remote: backend.baseUrl,
|
|
workspaceId: backend.workspace,
|
|
name: "replace_test",
|
|
token: backend.token
|
|
};
|
|
await addWorkspace(testWorkspace, { force: true, configDir: backend.testConfigDir });
|
|
|
|
// Configure backend with specific settings
|
|
await backend.updateGitSyncConfig!({
|
|
git_sync_settings: {
|
|
repositories: [{
|
|
git_repo_resource_path: "u/test/replace_repo",
|
|
script_path: "f/**",
|
|
group_by_folder: false,
|
|
use_individual_branch: false,
|
|
settings: {
|
|
include_path: ["f/replaced/**"],
|
|
include_type: ["script", "flow"],
|
|
exclude_path: ["*.backup.ts"],
|
|
extra_include_path: []
|
|
}
|
|
}]
|
|
}
|
|
});
|
|
|
|
// Create initial wmill.yaml with settings that should be replaced
|
|
await Deno.writeTextFile(`${tempDir}/wmill.yaml`, `defaultTs: bun
|
|
includes:
|
|
- f/old/**
|
|
excludes:
|
|
- "*.old.ts"
|
|
skipVariables: true`);
|
|
|
|
// Pull with replace flag
|
|
const result = await backend.runCLICommand([
|
|
'gitsync-settings', 'pull',
|
|
'--repository', 'u/test/replace_repo',
|
|
'--replace'
|
|
], tempDir);
|
|
|
|
assertEquals(result.code, 0, `Replace mode pull should succeed: ${result.stderr}`);
|
|
|
|
// Read updated config
|
|
const updatedConfig = await Deno.readTextFile(`${tempDir}/wmill.yaml`);
|
|
|
|
// Should have replaced settings from backend
|
|
assertStringIncludes(updatedConfig, "f/replaced/**");
|
|
assertStringIncludes(updatedConfig, "*.backup.ts");
|
|
});
|
|
}
|
|
});
|