mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-08-18 16:02:10 +00:00
a22d179903
* feat(cli): add GitHub Actions CI and raw app sync tests - Add CLI tests GitHub Action that runs on Linux and Windows - Add build check job that runs on CLI and openapi.yaml changes - Uses Rust cargo backend instead of Docker for better CI compatibility - Add cargo_backend.ts and test_backend.ts for test infrastructure - Fix Windows path separator bug in raw_apps.ts (use "/" for relative paths) - Fix PostgreSQL URL parsing in cargo_backend.ts - Update tests to use gitBranches format instead of deprecated overrides - Add raw_app_sync.test.ts for raw app sync workflow testing (ignored for now - needs EE) - Skip tests that require EE features (git sync settings, raw apps) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(cli): Fix Windows path compatibility issues in tests - Use fromFileUrl() in cargo_backend.ts for proper Windows path handling - Normalize path separators to forward slashes in resource_folders.ts - Fix readDirRecursive to return normalized paths in test helper - Use forward slashes consistently in buildMetadataPath and detection functions Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(cli): Use SEP in test assertions instead of modifying logic - Revert resource_folders.ts to use SEP as intended - Update test assertions to use SEP for platform-specific paths - Keep readDirRecursive normalization for consistent test comparisons Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(cli): Use SEP for all path separators in test assertions Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(cli): Use resolve() for proper cross-platform path handling in cargo_backend String concatenation with path separators creates malformed paths on Windows. Use path.resolve() instead for proper cross-platform path resolution. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(backend): Add cfg attributes for Windows compatibility - Add #[cfg(unix)] to anyhow::anyhow import (only used in unix cfg block) - Add #[cfg(not(windows))] to parse_file function (uses cat, only for cgroups) - Remove unused std::io import, use std::io::Result directly Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: Windows compilation + convert integration tests to withTestBackend - Fix unused import SYSTEM_ROOT in csharp_executor.rs on Windows by requiring both windows and csharp feature - Fix unused variable id in handle_child.rs on Windows by adding #[allow(unused_variables)] since id is only used in cfg(unix) code - Convert all RUN_INTEGRATION_TESTS dependent tests in sync_pull_push.test.ts to use withTestBackend pattern for automatic backend setup Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat: configurable test features with CI_MINIMAL_FEATURES env var - Default: full features (zip, private, enterprise) for local development - CI mode: minimal features (zip only) when CI_MINIMAL_FEATURES=true - Add shouldSkipOnCI() helper for tests requiring EE features - Update EE-dependent tests to use shouldSkipOnCI() - Add test instructions to cli/README.md Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: enable raw app tests (not EE-dependent) Raw apps work with minimal features. 2 tests pass, 2 have test logic bugs to investigate separately: - "delete file and push" - file deletion not syncing correctly - "dry-run push shows expected changes" - JSON output parsing issue Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: gate cgroups module to Linux only cgroups are Linux-specific, the module was causing dead_code warnings on Windows compilation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(ci): add CI_MINIMAL_FEATURES env var to CLI tests workflow Set CI_MINIMAL_FEATURES=true in both Linux and Windows test jobs so the backend compiles with minimal features (zip only) and EE-dependent tests self-skip via shouldSkipOnCI(). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(cli): raw app tests and backend startup timing - Add 5s delay after backend ready for migrations to complete - Fix dry-run JSON output parsing (handle pretty-printed JSON) - Temporarily ignore "delete file" test (needs isSuperset fix) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(cli): raw app file deletion sync - Add deepEqual check for files in raw_apps.ts isSuperset comparison - Handle raw_app file deletions in sync.ts by re-pushing the entire app - Fix test to remove CSS import before deleting the file When deleting a file from a raw app, the sync now properly updates the backend with the new file list (excluding the deleted file). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(cli): Windows path separators in tests Normalize paths for cross-platform comparison by converting backslashes to forward slashes before path assertions. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(cli): normalize featurePaths in multi_instance_workspace test Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test(cli): add mixed case paths sync tests for Windows compatibility Add comprehensive tests for sync pull/push with capitalized folder paths to catch Windows case-insensitivity issues: - Scripts in f/MyFolder/MyScript - Flows in f/MyFlows/DataProcessor - Apps in f/MyApps/Dashboard - Variables in f/MyVars/ApiKey - Deeply nested paths with mixed case - Multiple resources in same capitalized folder - CamelCase folder names with numbers Each test verifies the full pull -> modify -> push -> verify cycle. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test(cli): add idempotency check to mixed case paths tests After each push, pull again with --dry-run --json-output and verify that no changes are detected. This ensures the sync is stable and catches issues where pull/push cycles cause spurious diffs. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
220 lines
8.5 KiB
TypeScript
220 lines
8.5 KiB
TypeScript
import { assertEquals, assertStringIncludes, assert } from "https://deno.land/std@0.224.0/assert/mod.ts";
|
|
import { readConfigFile, getEffectiveSettings } from "../src/core/conf.ts";
|
|
import { withTestBackend } from "./test_backend.ts";
|
|
import { addWorkspace } from "../workspace.ts";
|
|
import { parseJsonFromCLIOutput } from "./test_config_helpers.ts";
|
|
|
|
// =============================================================================
|
|
// SYNC CONFIGURATION RESOLUTION TESTS
|
|
// Tests for configuration resolution and integration with backend
|
|
// =============================================================================
|
|
|
|
// Helper function to set up workspace profile with localhost_test name
|
|
async function setupWorkspaceProfile(backend: any): Promise<void> {
|
|
const testWorkspace = {
|
|
remote: backend.baseUrl, // "http://localhost:8001/"
|
|
workspaceId: backend.workspace, // "test"
|
|
name: "localhost_test", // This is what the tests expect!
|
|
token: backend.token
|
|
};
|
|
|
|
await addWorkspace(testWorkspace, { force: true, configDir: backend.testConfigDir });
|
|
}
|
|
|
|
|
|
// =============================================================================
|
|
// INTEGRATION TESTS WITH REAL BACKEND
|
|
// =============================================================================
|
|
|
|
Deno.test({
|
|
name: "Integration: wmill.yaml configuration produces expected results",
|
|
sanitizeResources: false,
|
|
sanitizeOps: false,
|
|
fn: async () => {
|
|
await withTestBackend(async (backend, tempDir) => {
|
|
// Set up workspace profile with name "localhost_test"
|
|
await setupWorkspaceProfile(backend);
|
|
|
|
// Create wmill.yaml with settings
|
|
await Deno.writeTextFile(`${tempDir}/wmill.yaml`, `defaultTs: bun
|
|
includes:
|
|
- f/**
|
|
- settings.yaml
|
|
excludes:
|
|
- "*.test.ts"
|
|
skipVariables: true
|
|
skipResources: true
|
|
includeSettings: true
|
|
includeSchedules: true
|
|
includeTriggers: true`);
|
|
|
|
// Test pull with wmill.yaml configuration
|
|
const yamlResult = await backend.runCLICommand(['sync', 'pull', '--dry-run', '--json-output'], tempDir);
|
|
if (yamlResult.code !== 0) {
|
|
console.log("YAML command failed!");
|
|
console.log("Exit code:", yamlResult.code);
|
|
console.log("Stdout:", yamlResult.stdout);
|
|
console.log("Stderr:", yamlResult.stderr);
|
|
}
|
|
assertEquals(yamlResult.code, 0);
|
|
|
|
// Extract JSON from CLI output (skip log messages)
|
|
const yamlData = parseJsonFromCLIOutput(yamlResult.stdout);
|
|
|
|
// Should include settings.yaml due to includeSettings: true
|
|
const hasSettings = (yamlData.changes || []).some((change: any) =>
|
|
change.type === 'added' && change.path === 'settings.yaml'
|
|
);
|
|
assertEquals(hasSettings, true);
|
|
|
|
// Should NOT include resources or variables (due to skip flags)
|
|
const hasResources = (yamlData.changes || []).some((change: any) =>
|
|
change.type === 'added' && change.path?.includes('.resource.yaml')
|
|
);
|
|
const hasVariables = (yamlData.changes || []).some((change: any) =>
|
|
change.type === 'added' && change.path?.includes('.variable.yaml')
|
|
);
|
|
assertEquals(hasResources, false);
|
|
assertEquals(hasVariables, false);
|
|
});
|
|
}});
|
|
|
|
Deno.test({
|
|
name: "Integration: settings.yaml inclusion respects includeSettings flag",
|
|
sanitizeResources: false,
|
|
sanitizeOps: false,
|
|
fn: async () => {
|
|
await withTestBackend(async (backend, tempDir) => {
|
|
// Set up workspace profile with name "localhost_test"
|
|
await setupWorkspaceProfile(backend);
|
|
|
|
// Test 1: includeSettings: true should include settings.yaml
|
|
await Deno.writeTextFile(`${tempDir}/wmill.yaml`, `defaultTs: bun
|
|
includes:
|
|
- "**"
|
|
includeSettings: true`);
|
|
|
|
const includeResult = await backend.runCLICommand(['sync', 'pull', '--dry-run', '--json-output'], tempDir);
|
|
assertEquals(includeResult.code, 0);
|
|
|
|
// Extract JSON from CLI output (skip log messages)
|
|
const includeData = parseJsonFromCLIOutput(includeResult.stdout);
|
|
const hasSettingsInclude = (includeData.changes || []).some((change: any) =>
|
|
change.type === 'added' && change.path === 'settings.yaml'
|
|
);
|
|
assertEquals(hasSettingsInclude, true);
|
|
|
|
// Test 2: includeSettings: false should NOT include settings.yaml
|
|
await Deno.writeTextFile(`${tempDir}/wmill.yaml`, `defaultTs: bun
|
|
includes:
|
|
- "**"
|
|
includeSettings: false`);
|
|
|
|
const excludeResult = await backend.runCLICommand(['sync', 'pull', '--dry-run', '--json-output'], tempDir);
|
|
assertEquals(excludeResult.code, 0);
|
|
|
|
// Extract JSON from CLI output (skip log messages)
|
|
const excludeData = parseJsonFromCLIOutput(excludeResult.stdout);
|
|
const hasSettingsExclude = (excludeData.changes || []).some((change: any) =>
|
|
change.type === 'added' && change.path === 'settings.yaml'
|
|
);
|
|
assertEquals(hasSettingsExclude, false);
|
|
});
|
|
}});
|
|
|
|
Deno.test({
|
|
name: "Integration: resource/variable filtering respects skip flags",
|
|
sanitizeResources: false,
|
|
sanitizeOps: false,
|
|
fn: async () => {
|
|
await withTestBackend(async (backend, tempDir) => {
|
|
// Set up workspace profile with name "localhost_test"
|
|
await setupWorkspaceProfile(backend);
|
|
|
|
// Test skipResources: true
|
|
await Deno.writeTextFile(`${tempDir}/wmill.yaml`, `defaultTs: bun
|
|
includes:
|
|
- "**"
|
|
skipResources: true
|
|
skipVariables: false`);
|
|
|
|
const result = await backend.runCLICommand(['sync', 'pull', '--dry-run', '--json-output'], tempDir);
|
|
assertEquals(result.code, 0);
|
|
|
|
// Extract JSON from CLI output (skip log messages)
|
|
const data = parseJsonFromCLIOutput(result.stdout);
|
|
|
|
// Should NOT include resources
|
|
const hasResources = (data.changes || []).some((change: any) =>
|
|
change.type === 'added' && change.path?.includes('.resource.yaml')
|
|
);
|
|
assertEquals(hasResources, false);
|
|
|
|
// Should include variables (not skipped)
|
|
const hasVariables = (data.changes || []).some((change: any) =>
|
|
change.type === 'added' && change.path?.includes('.variable.yaml')
|
|
);
|
|
assertEquals(hasVariables, true);
|
|
});
|
|
}});
|
|
|
|
// =============================================================================
|
|
// CLI FLAG OVERRIDE TESTS
|
|
// Tests for CLI flags overriding configuration file settings
|
|
// =============================================================================
|
|
|
|
Deno.test({
|
|
name: "CLI skip flags override wmill.yaml configuration",
|
|
sanitizeResources: false,
|
|
sanitizeOps: false,
|
|
fn: async () => {
|
|
await withTestBackend(async (backend, tempDir) => {
|
|
// Set up workspace profile with name "localhost_test"
|
|
await setupWorkspaceProfile(backend);
|
|
|
|
// Create wmill.yaml that INCLUDES resources by default (skipResources: false)
|
|
await Deno.writeTextFile(`${tempDir}/wmill.yaml`, `defaultTs: bun
|
|
includes:
|
|
- f/**
|
|
- u/**
|
|
skipResources: false
|
|
skipResourceTypes: false
|
|
includeSettings: true`);
|
|
|
|
// Test 1: Without CLI flags - should respect wmill.yaml (include resources)
|
|
const configResult = await backend.runCLICommand(['sync', 'pull', '--dry-run', '--json-output'], tempDir);
|
|
assertEquals(configResult.code, 0);
|
|
|
|
const configData = parseJsonFromCLIOutput(configResult.stdout);
|
|
|
|
|
|
// Should include resources (not skipped by config)
|
|
const hasResources = (configData.changes || []).some((change: any) =>
|
|
change.type === 'added' && change.path?.includes('.resource.yaml')
|
|
);
|
|
assertEquals(hasResources, true, "Resources should be included by wmill.yaml config");
|
|
|
|
// Test 2: With CLI --skip-resources flag - should override wmill.yaml to skip resources
|
|
const overrideResult = await backend.runCLICommand([
|
|
'sync', 'pull', '--dry-run', '--json-output',
|
|
'--skip-resources', // CLI flag should override config to skip resources
|
|
'--skip-resource-types' // CLI flag should override config to skip resource types
|
|
], tempDir);
|
|
assertEquals(overrideResult.code, 0);
|
|
|
|
const overrideData = parseJsonFromCLIOutput(overrideResult.stdout);
|
|
|
|
// Should NOT include resources (CLI flag overrides config)
|
|
const hasResourcesOverride = (overrideData.changes || []).some((change: any) =>
|
|
change.type === 'added' && change.path?.includes('.resource.yaml')
|
|
);
|
|
assertEquals(hasResourcesOverride, false, "CLI --skip-resources flag should override wmill.yaml to exclude resources");
|
|
|
|
// Should NOT include resource types (CLI flag overrides config)
|
|
const hasResourceTypesOverride = (overrideData.changes || []).some((change: any) =>
|
|
change.type === 'added' && change.path?.includes('.resource-type.yaml')
|
|
);
|
|
assertEquals(hasResourceTypesOverride, false, "CLI --skip-resource-types flag should override wmill.yaml to exclude resource types");
|
|
});
|
|
}});
|