rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2026-05-19 06:20:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(mito): remove Compactor::compact method (#7968)

Browse Source 
refactor/remove-compactor-compact:
 ### Remove Unused Compaction Functionality

 - **Removed `compact` Method**: Eliminated the `compact` method from the `Compactor` trait and its default implementation, which was primarily used for local compaction in testing. This change affects `compactor.rs`.
 - **Code Cleanup**: Removed associated code and comments related to the `compact` method, streamlining the `Compactor` trait interface.

Signed-off-by: Lei, HUANG <mrsatangel@gmail.com>
This commit is contained in:
Lei, HUANG
2026-04-15 10:50:47 +08:00
committed by GitHub
parent a870b53f68
commit 00d67d6fa1
1 changed files with 2 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
src/mito2/src/compaction/compactor.rs
View File

@@ -16,7 +16,6 @@ use std::num::NonZero;
use std::sync::Arc;
use std::time::Duration;
use api::v1::region::compact_request;
use common_meta::key::SchemaMetadataManagerRef;
use common_telemetry::{info, warn};
use common_time::TimeToLive;
@@ -34,9 +33,10 @@ use crate::access_layer::{
AccessLayer, AccessLayerRef, Metrics, OperationType, SstWriteRequest, WriteType,
};
use crate::cache::{CacheManager, CacheManagerRef};
use crate::compaction::picker::{PickerOutput, new_picker};
use crate::compaction::picker::PickerOutput;
use crate::compaction::{CompactionOutput, CompactionSstReaderBuilder, find_dynamic_options};
use crate::config::MitoConfig;
use crate::error;
use crate::error::{
EmptyRegionDirSnafu, InvalidPartitionExprSnafu, ObjectStoreNotFoundSnafu, Result,
};
@@ -55,7 +55,6 @@ use crate::sst::index::puffin_manager::PuffinManagerFactory;
use crate::sst::location::region_dir_from_table_dir;
use crate::sst::parquet::WriteOptions;
use crate::sst::version::{SstVersion, SstVersionRef};
use crate::{error, metrics};
/// Region version for compaction that does not hold memtables.
#[derive(Clone)]
@@ -290,13 +289,6 @@ pub trait Compactor: Send + Sync + 'static {
compaction_region: &CompactionRegion,
merge_output: MergeOutput,
) -> Result<RegionEdit>;
/// Execute compaction for a region.
async fn compact(
&self,
compaction_region: &CompactionRegion,
compact_request_options: compact_request::Options,
) -> Result<()>;
}
/// Trait for merging a single compaction output into SST files.
@@ -588,50 +580,6 @@ where
Ok(edit)
}
// The default implementation of compact combines the merge_ssts and update_manifest functions.
// Note: It's local compaction and only used for testing purpose.
async fn compact(
&self,
compaction_region: &CompactionRegion,
compact_request_options: compact_request::Options,
) -> Result<()> {
let picker_output = {
let picker_output = new_picker(
&compact_request_options,
&compaction_region.region_options.compaction,
compaction_region.region_options.append_mode,
None,
)
.pick(compaction_region);
if let Some(picker_output) = picker_output {
picker_output
} else {
info!(
"No files to compact for region_id: {}",
compaction_region.region_id
);
return Ok(());
}
};
let merge_output = self.merge_ssts(compaction_region, picker_output).await?;
if merge_output.is_empty() {
info!(
"No files to compact for region_id: {}",
compaction_region.region_id
);
return Ok(());
}
metrics::COMPACTION_INPUT_BYTES.inc_by(merge_output.input_file_size() as f64);
metrics::COMPACTION_OUTPUT_BYTES.inc_by(merge_output.output_file_size() as f64);
self.update_manifest(compaction_region, merge_output)
.await?;
Ok(())
}
}
#[cfg(test)]