rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2026-01-06 05:12:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: remove one clone on constructing partition (#4028)

Browse Source 
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
This commit is contained in:
Ruihang Xia
2024-05-24 12:01:19 +08:00
committed by GitHub
parent a3a2c8d063
commit 0101657649
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/partition/src/manager.rs
View File

@@ -290,7 +290,7 @@ fn create_partitions_from_region_routes(
let partition = r
.region
.partition
.clone()
.as_ref()
.context(error::FindRegionRoutesSnafu {
region_id: r.region.id,
table_id,

14
src/partition/src/partition.rs
View File

@@ -99,23 +99,23 @@ impl PartitionDef {
}
}
impl TryFrom<MetaPartition> for PartitionDef {
impl TryFrom<&MetaPartition> for PartitionDef {
type Error = Error;
fn try_from(partition: MetaPartition) -> Result<Self> {
fn try_from(partition: &MetaPartition) -> Result<Self> {
let MetaPartition {
column_list,
value_list,
} = partition;
let partition_columns = column_list
.into_iter()
.map(|x| String::from_utf8_lossy(&x).to_string())
.iter()
.map(|x| String::from_utf8_lossy(x).to_string())
.collect::<Vec<String>>();
let partition_bounds = value_list
.into_iter()
.map(|x| serde_json::from_str(&String::from_utf8_lossy(&x)))
.iter()
.map(|x| serde_json::from_str(&String::from_utf8_lossy(x)))
.collect::<std::result::Result<Vec<PartitionBound>, serde_json::Error>>()
.context(error::DeserializeJsonSnafu)?;
@@ -197,7 +197,7 @@ mod tests {
);
// MetaPartition -> PartitionDef
let partition = MetaPartition {
let partition = &MetaPartition {
column_list: vec![b"a".to_vec(), b"b".to_vec()],
value_list: vec![
b"\"MaxValue\"".to_vec(),