mirror of
https://github.com/GreptimeTeam/greptimedb.git
synced 2026-01-07 22:02:56 +00:00
chore: add some trace logs in fetching data from cache and object store (#6877)
* chore: add some important debug logs Signed-off-by: zyy17 <zyylsxm@gmail.com> * chore: add traces logs in `fetch_byte_ranges()` Signed-off-by: zyy17 <zyylsxm@gmail.com> --------- Signed-off-by: zyy17 <zyylsxm@gmail.com>
This commit is contained in:
@@ -14,8 +14,10 @@
|
||||
|
||||
use std::ops::Range;
|
||||
use std::sync::Arc;
|
||||
use std::time::Instant;
|
||||
|
||||
use bytes::Bytes;
|
||||
use common_telemetry::trace;
|
||||
use object_store::ObjectStore;
|
||||
use parquet::basic::ColumnOrder;
|
||||
use parquet::file::metadata::{FileMetaData, ParquetMetaData, RowGroupMetaData};
|
||||
@@ -100,7 +102,10 @@ pub async fn fetch_byte_ranges(
|
||||
object_store: ObjectStore,
|
||||
ranges: &[Range<u64>],
|
||||
) -> object_store::Result<Vec<Bytes>> {
|
||||
Ok(object_store
|
||||
let total_size = ranges.iter().map(|r| r.end - r.start).sum::<u64>();
|
||||
let start = Instant::now();
|
||||
|
||||
let result = object_store
|
||||
.reader_with(file_path)
|
||||
.concurrent(FETCH_PARALLELISM)
|
||||
.gap(MERGE_GAP)
|
||||
@@ -109,5 +114,14 @@ pub async fn fetch_byte_ranges(
|
||||
.await?
|
||||
.into_iter()
|
||||
.map(|buf| buf.to_bytes())
|
||||
.collect::<Vec<_>>())
|
||||
.collect::<Vec<_>>();
|
||||
|
||||
trace!(
|
||||
"Fetch {} bytes from '{}' in object store, cost: {:?}",
|
||||
total_size,
|
||||
file_path,
|
||||
start.elapsed()
|
||||
);
|
||||
|
||||
Ok(result)
|
||||
}
|
||||
|
||||
@@ -14,7 +14,7 @@
|
||||
|
||||
use std::sync::Arc;
|
||||
|
||||
use common_telemetry::debug;
|
||||
use common_telemetry::{debug, trace};
|
||||
use futures::{FutureExt, TryStreamExt};
|
||||
use moka::future::Cache;
|
||||
use moka::notification::ListenerFuture;
|
||||
@@ -290,6 +290,11 @@ impl<C: Access> ReadCache<C> {
|
||||
let (_, reader) = inner.read(path, args).await?;
|
||||
let result = self.try_write_cache::<I>(reader, read_key).await;
|
||||
|
||||
trace!(
|
||||
"Read cache miss for key '{}' and fetch file '{}' from object store",
|
||||
read_key, path,
|
||||
);
|
||||
|
||||
match result {
|
||||
Ok(read_bytes) => {
|
||||
OBJECT_STORE_LRU_CACHE_ENTRIES.inc();
|
||||
|
||||
Reference in New Issue
Block a user