rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2026-07-04 21:10:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: load page index in opener (#8269)

Browse Source 
Signed-off-by: evenyag <realevenyag@gmail.com>
This commit is contained in:
Yingwen
2026-06-11 17:09:18 +08:00
committed by GitHub
parent 565899e482
commit 340f22f301
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/mito2/src/region/opener.rs
View File

@@ -30,6 +30,7 @@ use log_store::raft_engine::log_store::RaftEngineLogStore;
use object_store::ObjectStore;
use object_store::manager::ObjectStoreManagerRef;
use object_store::util::{is_object_storage, normalize_dir};
use parquet::file::metadata::PageIndexPolicy;
use snafu::{OptionExt, ResultExt, ensure};
use store_api::logstore::LogStore;
use store_api::logstore::provider::Provider;
@@ -1079,7 +1080,7 @@ async fn preload_parquet_meta_cache_for_files(
let file_id = file_handle.file_id();
let mut cache_metrics = MetadataCacheMetrics::default();
if let Some(metadata) = cache_manager
.get_parquet_meta_data(file_id, &mut cache_metrics, Default::default())
.get_parquet_meta_data(file_id, &mut cache_metrics, PageIndexPolicy::Optional)
.await
{
if file_handle.primary_key_range().is_none()
@@ -1101,7 +1102,8 @@ async fn preload_parquet_meta_cache_for_files(
let file_size = file_handle.meta_ref().file_size;
let file_path = file_handle.file_path(&table_dir, path_type);
let loader = MetadataLoader::new(object_store.clone(), &file_path, file_size);
let mut loader = MetadataLoader::new(object_store.clone(), &file_path, file_size);
loader.with_page_index_policy(PageIndexPolicy::Optional);
match loader.load(&mut cache_metrics).await {
Ok(metadata) => {
if let Some(primary_key_range) =
@@ -1439,6 +1441,16 @@ mod tests {
.get_parquet_meta_data_from_mem_cache(region_file_id)
.is_some()
);
// The cached entry must carry the page index so that later `Optional` queries hit
// the in-memory cache instead of reloading metadata on demand.
assert!(
cache_manager
.get_sst_meta_data_from_mem_cache(
region_file_id,
parquet::file::metadata::PageIndexPolicy::Optional,
)
.is_some()
);
assert!(file_handle.primary_key_range().is_some());
}