rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2025-12-27 16:32:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: decimal128 ScalarValue to Value (#3019)

Browse Source 
fix: decimal128 scalarvalue to value
This commit is contained in:
Wei
2023-12-27 18:03:37 +08:00
committed by GitHub
parent d1ee1ba56a
commit 43e3a77263
1 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/datatypes/src/value.rs
View File

@@ -827,8 +827,10 @@ impl TryFrom<ScalarValue> for Value {
ScalarValue::DurationNanosecond(d) => d
.map(|x| Value::Duration(Duration::new(x, TimeUnit::Nanosecond)))
.unwrap_or(Value::Null),
ScalarValue::Decimal128(_, _, _)
| ScalarValue::Decimal256(_, _, _)
ScalarValue::Decimal128(v, p, s) => v
.map(|v| Value::Decimal128(Decimal128::new(v, p, s)))
.unwrap_or(Value::Null),
ScalarValue::Decimal256(_, _, _)
| ScalarValue::Struct(_, _)
| ScalarValue::Dictionary(_, _) => {
return error::UnsupportedArrowTypeSnafu {
@@ -1475,11 +1477,14 @@ mod tests {
ScalarValue::DurationNanosecond(None).try_into().unwrap()
);
let result: Result<Value> = ScalarValue::Decimal128(Some(1), 0, 0).try_into();
assert!(result
.unwrap_err()
.to_string()
.contains("Unsupported arrow data type, type: Decimal128(0, 0)"));
assert_eq!(
Value::Decimal128(Decimal128::new(1, 38, 10)),
ScalarValue::Decimal128(Some(1), 38, 10).try_into().unwrap()
);
assert_eq!(
Value::Null,
ScalarValue::Decimal128(None, 0, 0).try_into().unwrap()
);
}
#[test]