fix: demote expected remote dynamic filter misses (#8574)

Signed-off-by: discord9 <discord9@163.com>
This commit is contained in:
discord9
2026-07-23 04:39:56 +00:00
committed by GitHub
parent 9b579c7618
commit 45fc51ebd2
2 changed files with 6 additions and 7 deletions
@@ -21,7 +21,7 @@ use common_query::request::{
DynFilterPayload, INITIAL_REMOTE_DYN_FILTER_REGISTRATIONS_EXTENSION_KEY, InitialDynFilterReg,
InitialDynFilterRegs, REMOTE_DYN_FILTER_PAYLOAD_MAX_BYTES,
};
use common_telemetry::warn;
use common_telemetry::{debug, warn};
use dashmap::DashMap;
use datafusion::arrow::datatypes::{Schema, SchemaRef};
use datafusion::execution::{SessionStateBuilder, TaskContext};
@@ -557,7 +557,7 @@ pub(super) fn apply_remote_dyn_filter_update(
REMOTE_DYN_FILTER_PAYLOAD_BYTES.observe(payload.len() as f64);
let Some(query_regs) = regs_by_query.get_query(query_id) else {
warn!(
debug!(
"Ignored remote dynamic filter update without query registration, query_id: {}, filter_id: {}",
query_id, filter_id
);
@@ -568,7 +568,7 @@ pub(super) fn apply_remote_dyn_filter_update(
let mut query_regs = query_regs.lock().unwrap();
let Some(registered) = query_regs.get_mut(filter_id) else {
warn!(
debug!(
"Ignored remote dynamic filter update without filter registration, query_id: {}, filter_id: {}",
query_id, filter_id
);
@@ -589,7 +589,7 @@ pub(super) fn unregister_remote_dyn_filter(
filter_id: &RemoteDynFilterId,
) -> RemoteDynFilterUpdateOutcome {
let Some(query_regs) = regs_by_query.get_query(query_id) else {
warn!(
debug!(
"Ignored remote dynamic filter unregister without query registration, query_id: {}, filter_id: {}",
query_id, filter_id
);
@@ -601,7 +601,7 @@ pub(super) fn unregister_remote_dyn_filter(
let (registered, should_remove_query) = {
let mut locked = query_regs.lock().unwrap();
let Some(registered) = locked.remove(filter_id) else {
warn!(
debug!(
"Ignored remote dynamic filter unregister without filter registration, query_id: {}, filter_id: {}",
query_id, filter_id
);
@@ -225,8 +225,7 @@ impl RegionServer {
) {
if matches!(
outcome,
RemoteDynFilterUpdateOutcome::MissingRegistration
| RemoteDynFilterUpdateOutcome::AlreadyComplete
RemoteDynFilterUpdateOutcome::AlreadyComplete
| RemoteDynFilterUpdateOutcome::PayloadTooLarge
| RemoteDynFilterUpdateOutcome::DecodeFailed
) {