rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2026-09-12 00:12:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(mito2): avoid panic-based compaction status lookups

Browse Source 
Signed-off-by: Lei, HUANG <ratuthomm@gmail.com>
This commit is contained in:
Lei, HUANG
2026-07-23 23:48:30 +08:00
parent 419f558afd
commit 4f6d48fc5e
1 changed files with 26 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/mito2/src/compaction.rs
+26 -30
View File
@@ -351,27 +351,22 @@ impl CompactionScheduler {
max_parallelism,
} = pending_request;
let request = {
status.new_compaction_request(
self.request_sender.clone(),
self.engine_config.clone(),
self.cache_manager.clone(),
manifest_ctx,
self.listener.clone(),
schema_metadata_manager,
max_parallelism,
)
};
self.region_status
.get_mut(&region_id)
.unwrap()
.merge_waiter(waiter);
let version_control = self.region_status[&region_id].version_control.clone();
let request = status.new_compaction_request(
self.request_sender.clone(),
self.engine_config.clone(),
self.cache_manager.clone(),
manifest_ctx,
self.listener.clone(),
schema_metadata_manager,
max_parallelism,
);
status.merge_waiter(waiter);
let version_control = status.version_control.clone();
let plan_id = self.next_plan_id();
self.region_status
.get_mut(&region_id)
.unwrap()
.start_picking(plan_id);
let Some(status) = self.region_status.get_mut(&region_id) else {
return true;
};
status.start_picking(plan_id);
self.dispatch_compaction_planning(plan_id, version_control, request, options);
debug!(
"Successfully scheduled manual compaction planning for region id: {}",
@@ -508,12 +503,12 @@ impl CompactionScheduler {
schema_metadata_manager,
MAX_PARALLEL_COMPACTION,
);
let version_control = self.region_status[&region_id].version_control.clone();
let version_control = status.version_control.clone();
let plan_id = self.next_plan_id();
self.region_status
.get_mut(&region_id)
.unwrap()
.start_regular_picking(plan_id);
let Some(status) = self.region_status.get_mut(&region_id) else {
return false;
};
status.start_regular_picking(plan_id);
self.dispatch_compaction_planning(
plan_id,
version_control,
@@ -810,10 +805,7 @@ impl CompactionScheduler {
match finished.result {
CompactionPlanningResult::Prepared(mut prepared) => {
let current = self.region_status[&region_id]
.version_control
.current()
.version;
let current = status.version_control.current().version;
let Some(picker_output) =
refresh_picker_output(prepared.picker_output, &current.ssts)
else {
@@ -931,7 +923,11 @@ impl CompactionScheduler {
return Vec::new();
}
if self.region_status[&region_id].regular_replan_pending {
if self
.region_status
.get(&region_id)
.is_some_and(|status| status.regular_replan_pending)
{
self.schedule_next_compaction(region_id, manifest_ctx, schema_metadata_manager);
return Vec::new();
}