rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2026-01-08 22:32:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: show proper error msg, when executing non-admin functions as admin functions (#7061)

Browse Source 
Signed-off-by: Shyamnatesan <shyamnatesan21@gmail.com>
This commit is contained in:
shyam
2025-10-10 06:55:49 +05:30
committed by GitHub
parent 979c8be51b
commit 591b9f3e81
1 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/operator/src/statement/admin.rs
View File

@@ -49,15 +49,22 @@ impl StatementExecutor {
let Admin::Func(func) = &stmt;
// the function name should be in lower case.
let func_name = func.name.to_string().to_lowercase();
let factory = FUNCTION_REGISTRY
.get_function(&func_name)
.context(error::AdminFunctionNotFoundSnafu { name: func_name })?;
let factory = FUNCTION_REGISTRY.get_function(&func_name).context(
error::AdminFunctionNotFoundSnafu {
name: func_name.clone(),
},
)?;
let func_ctx = FunctionContext {
query_ctx: query_ctx.clone(),
state: self.query_engine.engine_state().function_state(),
};
let admin_udf = factory.provide(func_ctx);
let admin_async_fn = admin_udf
.as_async()
.context(error::AdminFunctionNotFoundSnafu { name: func_name })?;
let fn_name = admin_udf.name();
let signature = admin_udf.signature();
@@ -122,11 +129,7 @@ impl StatementExecutor {
};
// Execute the async UDF
let result_columnar = admin_udf
.as_async()
.with_context(|| error::BuildAdminFunctionArgsSnafu {
msg: format!("Function {} is not async", fn_name),
})?
let result_columnar = admin_async_fn
.invoke_async_with_args(func_args)
.await
.with_context(|_| ExecuteAdminFunctionSnafu {