rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2026-01-03 20:02:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: refactor execute_stream to non-async method (#980)

Browse Source
This commit is contained in:
Weny Xu
2023-02-14 15:41:22 +08:00
committed by GitHub
parent 7b98718cd9
commit 5e6f340dd9
2 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/query/src/datafusion.rs
View File

@@ -119,14 +119,12 @@ impl QueryEngine for DatafusionQueryEngine {
let physical_plan = self.create_physical_plan(&mut ctx, &logical_plan).await?;
let physical_plan = self.optimize_physical_plan(&mut ctx, physical_plan)?;
Ok(Output::Stream(
self.execute_stream(&ctx, &physical_plan).await?,
))
Ok(Output::Stream(self.execute_stream(&ctx, &physical_plan)?))
}
async fn execute_physical(&self, plan: &Arc<dyn PhysicalPlan>) -> Result<Output> {
let ctx = QueryEngineContext::new(self.state.clone());
Ok(Output::Stream(self.execute_stream(&ctx, plan).await?))
Ok(Output::Stream(self.execute_stream(&ctx, plan)?))
}
fn register_udf(&self, udf: ScalarUdf) {
@@ -237,9 +235,8 @@ impl PhysicalOptimizer for DatafusionQueryEngine {
}
}
#[async_trait::async_trait]
impl QueryExecutor for DatafusionQueryEngine {
async fn execute_stream(
fn execute_stream(
&self,
ctx: &QueryEngineContext,
plan: &Arc<dyn PhysicalPlan>,

3
src/query/src/executor.rs
View File

@@ -21,9 +21,8 @@ use crate::error::Result;
use crate::query_engine::QueryEngineContext;
/// Executor to run [ExecutionPlan].
#[async_trait::async_trait]
pub trait QueryExecutor {
async fn execute_stream(
fn execute_stream(
&self,
ctx: &QueryEngineContext,
plan: &Arc<dyn PhysicalPlan>,