rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2026-05-26 09:50:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: cleanup todos that should be panic (#3720)

Browse Source 
Signed-off-by: tison <wander4096@gmail.com>
This commit is contained in:
tison
2024-04-17 13:04:14 +08:00
committed by GitHub
parent 3e9bda3267
commit 786f43da91
2 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/catalog/src/kvbackend/client.rs
View File

@@ -506,32 +506,32 @@ mod tests {
}
async fn range(&self, _req: RangeRequest) -> Result<RangeResponse, Self::Error> {
todo!()
unimplemented!()
}
async fn batch_put(&self, _req: BatchPutRequest) -> Result<BatchPutResponse, Self::Error> {
todo!()
unimplemented!()
}
async fn compare_and_put(
&self,
_req: CompareAndPutRequest,
) -> Result<CompareAndPutResponse, Self::Error> {
todo!()
unimplemented!()
}
async fn delete_range(
&self,
_req: DeleteRangeRequest,
) -> Result<DeleteRangeResponse, Self::Error> {
todo!()
unimplemented!()
}
async fn batch_delete(
&self,
_req: BatchDeleteRequest,
) -> Result<BatchDeleteResponse, Self::Error> {
todo!()
unimplemented!()
}
}

12
src/script/src/python/engine.rs
View File

@@ -446,13 +446,13 @@ def test(**params) -> vector[i64]:
("a".to_string(), "30".to_string()),
("b".to_string(), "12".to_string()),
]);
let _output = script
let output = script
.execute(params, EvalContext::default())
.await
.unwrap();
let res = match _output.data {
let res = match output.data {
OutputData::RecordBatches(s) => s,
_ => todo!(),
data => unreachable!("data: {data:?}"),
};
let rb = res.iter().next().expect("One and only one recordbatch");
assert_eq!(rb.column(0).len(), 1);
@@ -476,13 +476,13 @@ def test(number) -> vector[u32]:
.compile(script, CompileContext::default())
.await
.unwrap();
let _output = script
let output = script
.execute(HashMap::new(), EvalContext::default())
.await
.unwrap();
let res = common_recordbatch::util::collect_batches(match _output.data {
let res = common_recordbatch::util::collect_batches(match output.data {
OutputData::Stream(s) => s,
_ => todo!(),
data => unreachable!("data: {data:?}"),
})
.await
.unwrap();