rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2025-12-22 22:20:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: increase in progress scan gauge and adjust histogram buckets (#5370)

Browse Source 
* fix: in progress scan doesn't inc

* feat(mito): adjust mito histogram buckets

* chore(metric-engine): adjust metric engine histogram bucket
This commit is contained in:
Yingwen
2025-01-16 20:53:03 +08:00
committed by GitHub
parent 3a55f5d17c
commit 7eaabb3ca2
3 changed files with 32 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/metric-engine/src/metrics.rs
View File

@@ -46,7 +46,8 @@ lazy_static! {
"greptime_metric_engine_mito_op_elapsed",
"metric engine's mito operation elapsed",
&[OPERATION_LABEL],
vec![0.005, 0.01, 0.05, 0.1, 0.5, 1.0, 5.0, 10.0, 60.0, 300.0]
// 0.01 ~ 10000
exponential_buckets(0.01, 10.0, 7).unwrap(),
)
.unwrap();
}

39
src/mito2/src/metrics.rs
View File

@@ -48,7 +48,8 @@ lazy_static! {
"greptime_mito_handle_request_elapsed",
"mito handle request elapsed",
&[TYPE_LABEL],
vec![0.005, 0.01, 0.05, 0.1, 0.5, 1.0, 2.5, 5.0, 10.0, 60.0, 300.0]
// 0.01 ~ 10000
exponential_buckets(0.01, 10.0, 7).unwrap(),
)
.unwrap();
@@ -69,7 +70,8 @@ lazy_static! {
"greptime_mito_flush_elapsed",
"mito flush elapsed",
&[TYPE_LABEL],
vec![0.005, 0.01, 0.05, 0.1, 0.5, 1.0, 5.0, 10.0, 60.0, 300.0]
// 1 ~ 625
exponential_buckets(1.0, 5.0, 6).unwrap(),
)
.unwrap();
/// Histogram of flushed bytes.
@@ -99,7 +101,8 @@ lazy_static! {
"greptime_mito_write_stage_elapsed",
"mito write stage elapsed",
&[STAGE_LABEL],
vec![0.005, 0.01, 0.05, 0.1, 0.5, 1.0, 5.0, 10.0, 60.0, 300.0]
// 0.01 ~ 1000
exponential_buckets(0.01, 10.0, 6).unwrap(),
)
.unwrap();
/// Counter of rows to write.
@@ -118,12 +121,18 @@ lazy_static! {
"greptime_mito_compaction_stage_elapsed",
"mito compaction stage elapsed",
&[STAGE_LABEL],
vec![0.005, 0.01, 0.05, 0.1, 0.5, 1.0, 5.0, 10.0, 60.0, 300.0]
// 1 ~ 100000
exponential_buckets(1.0, 10.0, 6).unwrap(),
)
.unwrap();
/// Timer of whole compaction task.
pub static ref COMPACTION_ELAPSED_TOTAL: Histogram =
register_histogram!("greptime_mito_compaction_total_elapsed", "mito compaction total elapsed").unwrap();
register_histogram!(
"greptime_mito_compaction_total_elapsed",
"mito compaction total elapsed",
// 1 ~ 100000
exponential_buckets(1.0, 10.0, 6).unwrap(),
).unwrap();
/// Counter of all requested compaction task.
pub static ref COMPACTION_REQUEST_COUNT: IntCounter =
register_int_counter!("greptime_mito_compaction_requests_total", "mito compaction requests total").unwrap();
@@ -145,7 +154,8 @@ lazy_static! {
"greptime_mito_read_stage_elapsed",
"mito read stage elapsed",
&[STAGE_LABEL],
vec![0.005, 0.01, 0.05, 0.1, 0.5, 1.0, 5.0, 10.0, 60.0, 300.0]
// 0.01 ~ 10000
exponential_buckets(0.01, 10.0, 7).unwrap(),
)
.unwrap();
pub static ref READ_STAGE_FETCH_PAGES: Histogram = READ_STAGE_ELAPSED.with_label_values(&["fetch_pages"]);
@@ -222,6 +232,8 @@ lazy_static! {
"mito_write_cache_download_elapsed",
"mito write cache download elapsed",
&[TYPE_LABEL],
// 0.1 ~ 10000
exponential_buckets(0.1, 10.0, 6).unwrap(),
).unwrap();
/// Upload bytes counter.
pub static ref UPLOAD_BYTES_TOTAL: IntCounter = register_int_counter!(
@@ -243,6 +255,8 @@ lazy_static! {
"greptime_index_apply_elapsed",
"index apply elapsed",
&[TYPE_LABEL],
// 0.01 ~ 1000
exponential_buckets(0.01, 10.0, 6).unwrap(),
)
.unwrap();
/// Gauge of index apply memory usage.
@@ -256,7 +270,8 @@ lazy_static! {
"greptime_index_create_elapsed",
"index create elapsed",
&[STAGE_LABEL, TYPE_LABEL],
vec![0.005, 0.01, 0.05, 0.1, 0.5, 1.0, 5.0, 10.0, 60.0, 300.0]
// 0.1 ~ 10000
exponential_buckets(0.1, 10.0, 6).unwrap(),
)
.unwrap();
/// Counter of rows indexed.
@@ -337,7 +352,8 @@ lazy_static! {
"greptime_partition_tree_buffer_freeze_stage_elapsed",
"mito partition tree data buffer freeze stage elapsed",
&[STAGE_LABEL],
vec![0.005, 0.01, 0.05, 0.1, 0.5, 1.0, 5.0, 10.0, 60.0]
// 0.01 ~ 1000
exponential_buckets(0.01, 10.0, 6).unwrap(),
)
.unwrap();
@@ -346,7 +362,8 @@ lazy_static! {
"greptime_partition_tree_read_stage_elapsed",
"mito partition tree read stage elapsed",
&[STAGE_LABEL],
vec![0.005, 0.01, 0.05, 0.1, 0.5, 1.0, 5.0, 10.0, 60.0]
// 0.01 ~ 1000
exponential_buckets(0.01, 10.0, 6).unwrap(),
)
.unwrap();
@@ -359,6 +376,8 @@ lazy_static! {
pub static ref MANIFEST_OP_ELAPSED: HistogramVec = register_histogram_vec!(
"greptime_manifest_op_elapsed",
"mito manifest operation elapsed",
&["op"]
&["op"],
// 0.01 ~ 1000
exponential_buckets(0.01, 10.0, 6).unwrap(),
).unwrap();
}

1
src/mito2/src/read/scan_util.rs
View File

@@ -82,6 +82,7 @@ impl PartitionMetrics {
) -> Self {
let partition_str = partition.to_string();
let in_progress_scan = IN_PROGRESS_SCAN.with_label_values(&[scanner_type, &partition_str]);
in_progress_scan.inc();
let inner = PartitionMetricsInner {
region_id,
partition,