refactor: remove open metrics parser (#8905)

This commit is contained in:
Ning Sun
2026-08-19 03:47:44 +00:00
committed by GitHub
parent b96ea86a62
commit 8dbfbee611
7 changed files with 2 additions and 51 deletions
Generated
-18
View File
@@ -977,12 +977,6 @@ dependencies = [
"syn 2.0.117",
]
[[package]]
name = "auto_ops"
version = "0.3.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "7460f7dd8e100147b82a63afca1a20eb6c231ee36b90ba7272e14951cb58af59"
[[package]]
name = "autocfg"
version = "1.5.0"
@@ -9802,17 +9796,6 @@ dependencies = [
"url",
]
[[package]]
name = "openmetrics-parser"
version = "0.4.4"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "e40a68c62e09c5dfec2f6472af3bd5e8ddf506fcf14c78ece23794ffbb874eca"
dependencies = [
"auto_ops",
"pest",
"pest_derive",
]
[[package]]
name = "opensrv-mysql"
version = "0.8.0"
@@ -13461,7 +13444,6 @@ dependencies = [
"notify",
"object-pool",
"once_cell",
"openmetrics-parser",
"opensrv-mysql",
"opentelemetry-proto",
"operator",
+1 -9
View File
@@ -47,7 +47,7 @@ use servers::http::header::{CONTENT_ENCODING_SNAPPY, CONTENT_TYPE_PROTOBUF, coll
use servers::http::prom_store::PHYSICAL_TABLE_PARAM;
use servers::interceptor::{PromStoreProtocolInterceptor, PromStoreProtocolInterceptorRef};
use servers::pending_rows_batcher::PendingRowsSchemaAlterer;
use servers::prom_store::{self, Metrics};
use servers::prom_store;
use servers::query_handler::{
PromStoreProtocolHandler, PromStoreProtocolHandlerRef, PromStoreResponse,
};
@@ -648,10 +648,6 @@ impl PromStoreProtocolHandler for Instance {
.fail(),
}
}
async fn ingest_metrics(&self, _metrics: Metrics) -> ServerResult<()> {
todo!();
}
}
impl Instance {
@@ -791,10 +787,6 @@ impl PromStoreProtocolHandler for ExportMetricHandler {
) -> ServerResult<PromStoreResponse> {
unreachable!();
}
async fn ingest_metrics(&self, _metrics: Metrics) -> ServerResult<()> {
unreachable!();
}
}
#[cfg(test)]
-1
View File
@@ -87,7 +87,6 @@ mysql_common = "0.38"
notify.workspace = true
object-pool = "0.5"
once_cell.workspace = true
openmetrics-parser = "0.4"
# Wait for https://github.com/databendlabs/opensrv/pull/81
opensrv-mysql = { git = "https://github.com/GreptimeTeam/opensrv", rev = "6c5a451544194b7bb60a8318d155d4f892b49f2c" }
opentelemetry-proto.workspace = true
-9
View File
@@ -770,7 +770,6 @@ mod tests {
use super::*;
use crate::prom_remote_write::validation::PromValidationMode;
use crate::prom_store::Metrics;
use crate::query_handler::PromStoreProtocolHandler;
#[test]
@@ -966,10 +965,6 @@ mod tests {
) -> Result<PromStoreResponse> {
unimplemented!()
}
async fn ingest_metrics(&self, _metrics: Metrics) -> Result<()> {
unimplemented!()
}
}
#[tokio::test]
@@ -1067,9 +1062,5 @@ mod tests {
) -> Result<PromStoreResponse> {
unimplemented!()
}
async fn ingest_metrics(&self, _metrics: Metrics) -> Result<()> {
unimplemented!()
}
}
}
-6
View File
@@ -34,7 +34,6 @@ use datafusion::dataframe::DataFrame;
use datafusion::prelude::{Expr, col, lit, regexp_match};
use datafusion_common::ScalarValue;
use datafusion_expr::LogicalPlan;
use openmetrics_parser::{MetricsExposition, PrometheusType, PrometheusValue};
use snafu::{OptionExt, ResultExt, ensure};
use snap::raw::{Decoder, Encoder};
@@ -95,11 +94,6 @@ pub fn is_physical_table_selection_label(label: &str) -> bool {
label == PHYSICAL_TABLE_LABEL || label == PHYSICAL_TABLE_LABEL_ALT
}
/// Metrics for push gateway protocol
pub struct Metrics {
pub exposition: MetricsExposition<PrometheusType, PrometheusValue>,
}
/// Get table name from remote query
pub fn table_name(q: &Query) -> Result<String> {
let mut matchers = q
-3
View File
@@ -54,7 +54,6 @@ use crate::error::Result;
use crate::http::jaeger::QueryTraceParams;
use crate::influxdb::InfluxdbRequest;
use crate::opentsdb::codec::DataPoint;
use crate::prom_store::Metrics;
pub type OpentsdbProtocolHandlerRef = Arc<dyn OpentsdbProtocolHandler + Send + Sync>;
pub type InfluxdbLineProtocolHandlerRef = Arc<dyn InfluxdbLineProtocolHandler + Send + Sync>;
pub type PromStoreProtocolHandlerRef = Arc<dyn PromStoreProtocolHandler + Send + Sync>;
@@ -125,8 +124,6 @@ pub trait PromStoreProtocolHandler {
/// Handling prometheus remote read requests
async fn read(&self, request: ReadRequest, ctx: QueryContextRef) -> Result<PromStoreResponse>;
/// Handling push gateway requests
async fn ingest_metrics(&self, metrics: Metrics) -> Result<()>;
}
#[async_trait]
+1 -5
View File
@@ -44,7 +44,7 @@ use servers::http::{HttpOptions, HttpServerBuilder};
use servers::prom_remote_write::v2::test_util as remote_write_v2;
use servers::prom_remote_write::validation::PromValidationMode;
use servers::prom_store;
use servers::prom_store::{Metrics, snappy_compress};
use servers::prom_store::snappy_compress;
use servers::query_handler::sql::SqlQueryHandler;
use servers::query_handler::{PromStoreProtocolHandler, PromStoreResponse};
use session::context::QueryContextRef;
@@ -146,10 +146,6 @@ impl PromStoreProtocolHandler for DummyInstance {
body: response.encode_to_vec(),
})
}
async fn ingest_metrics(&self, _metrics: Metrics) -> Result<()> {
unimplemented!();
}
}
#[async_trait]