rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2026-05-17 13:30:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove sequence number from ScanRequest (#2785)

Browse Source 
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
This commit is contained in:
Ruihang Xia
2023-11-21 15:38:30 +08:00
committed by GitHub
parent a7bbd61f28
commit 99dbb7401c
3 changed files with 1 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/metric-engine/src/metadata_region.rs
View File

@@ -262,7 +262,6 @@ impl MetadataRegion {
let filter_expr = col(METADATA_SCHEMA_KEY_COLUMN_NAME).eq(lit(key));
ScanRequest {
sequence: None,
projection: Some(vec![METADATA_SCHEMA_VALUE_COLUMN_INDEX]),
filters: vec![filter_expr.into()],
output_ordering: None,
@@ -390,7 +389,6 @@ mod test {
let key = "test_key";
let expected_filter_expr = col(METADATA_SCHEMA_KEY_COLUMN_NAME).eq(lit(key));
let expected_scan_request = ScanRequest {
sequence: None,
projection: Some(vec![METADATA_SCHEMA_VALUE_COLUMN_INDEX]),
filters: vec![expected_filter_expr.into()],
output_ordering: None,

1
src/mito2/src/engine/projection_test.rs
View File

@@ -74,7 +74,6 @@ async fn test_scan_projection() {
// Scans tag_1, field_1, ts
let request = ScanRequest {
sequence: None,
projection: Some(vec![1, 3, 4]),
filters: Vec::new(),
output_ordering: None,

7
src/store-api/src/storage/requests.rs
View File

@@ -26,7 +26,7 @@ use snafu::{OptionExt, ResultExt};
use crate::error::{
BuildColumnDescriptorSnafu, Error, InvalidDefaultConstraintSnafu, InvalidRawRegionRequestSnafu,
};
use crate::storage::{ColumnDescriptor, ColumnDescriptorBuilder, RegionDescriptor, SequenceNumber};
use crate::storage::{ColumnDescriptor, ColumnDescriptorBuilder, RegionDescriptor};
/// Write request holds a collection of updates to apply to a region.
///
@@ -48,11 +48,6 @@ pub trait WriteRequest: Send {
#[derive(Default, Clone, Debug, PartialEq, Eq)]
pub struct ScanRequest {
/// Max sequence number to read, None for latest sequence.
///
/// Default is None. Only returns data whose sequence number is less than or
/// equal to the `sequence`.
pub sequence: Option<SequenceNumber>,
/// Indices of columns to read, `None` to read all columns.
pub projection: Option<Vec<usize>>,
/// Filters pushed down